Solved

ATL COM Object GET property using BSTR

Posted on 2002-07-26
2
368 Views
Last Modified: 2013-11-25
Is this code correct..IE will it product memory leaks?


STDMETHODIMP CUPS::get_m_strLastError(BSTR *pVal)
{
    AFX_MANAGE_STATE(AfxGetStaticModuleState())

    // TODO: Add your implementation code here
    SysFreeString(*pVal);
    CString strError;

    strError="<font style='font-size:10pt;font-family:Verdana,Arial;'>";
    strError+=m_strLastError+"</font>\0";

    int iSize=strError.GetLength();
    char* str = strError.GetBuffer(iSize);
    unsigned short *newstr= NULL;
   
    int iWideSize=MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,0);

    newstr = new unsigned short[iWideSize];
    memset(newstr,0,iWideSize);

    MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,iWideSize);
    *pVal=SysAllocString(newstr);

    delete (unsigned short*)newstr;
    strError.ReleaseBuffer();
    return S_OK;
}
0
Comment
Question by:Dredwick
2 Comments
 
LVL 12

Accepted Solution

by:
migel earned 50 total points
ID: 7183276
Hi!
no your code will not lead to memory leak
but some additions:

// here you jave to use WCHAR
 newstr = new WCHAR[iWideSize]; //<<
   memset(newstr,0,iWideSize*sizeof(WCHAR));//<<

   MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,iWideSize);
   *pVal=SysAllocString(newstr);

   delete[] newstr; //<<<
   strError.ReleaseBuffer();
0
 

Author Comment

by:Dredwick
ID: 7183553
Thanks Migel!
0

Featured Post

Live: Real-Time Solutions, Start Here

Receive instant 1:1 support from technology experts, using our real-time conversation and whiteboard interface. Your first 5 minutes are always free.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

With most software applications trying to cater to multiple user needs nowadays, the focus is to make them as configurable as possible. For e.g., when creating Silverlight applications which will connect to WCF services, the service end point usuall…
For most people, the WrapPanel seems like a magic when they switch from WinForms to WPF. Most of us will think that the code that is used to write a control like that would be difficult. However, most of the work is done by the WPF engine, and the W…
This video will show you how to get GIT to work in Eclipse.   It will walk you through how to install the EGit plugin in eclipse and how to checkout an existing repository.
This is Part 3 in a 3-part series on Experts Exchange to discuss error handling in VBA code written for Excel. Part 1 of this series discussed basic error handling code using VBA. http://www.experts-exchange.com/videos/1478/Excel-Error-Handlin…

776 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question