Want to protect your cyber security and still get fast solutions? Ask a secure question today.Go Premium

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 379
  • Last Modified:

ATL COM Object GET property using BSTR

Is this code correct..IE will it product memory leaks?


STDMETHODIMP CUPS::get_m_strLastError(BSTR *pVal)
{
    AFX_MANAGE_STATE(AfxGetStaticModuleState())

    // TODO: Add your implementation code here
    SysFreeString(*pVal);
    CString strError;

    strError="<font style='font-size:10pt;font-family:Verdana,Arial;'>";
    strError+=m_strLastError+"</font>\0";

    int iSize=strError.GetLength();
    char* str = strError.GetBuffer(iSize);
    unsigned short *newstr= NULL;
   
    int iWideSize=MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,0);

    newstr = new unsigned short[iWideSize];
    memset(newstr,0,iWideSize);

    MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,iWideSize);
    *pVal=SysAllocString(newstr);

    delete (unsigned short*)newstr;
    strError.ReleaseBuffer();
    return S_OK;
}
0
Dredwick
Asked:
Dredwick
1 Solution
 
migelCommented:
Hi!
no your code will not lead to memory leak
but some additions:

// here you jave to use WCHAR
 newstr = new WCHAR[iWideSize]; //<<
   memset(newstr,0,iWideSize*sizeof(WCHAR));//<<

   MultiByteToWideChar(CP_ACP,MB_PRECOMPOSED,str,-1,newstr,iWideSize);
   *pVal=SysAllocString(newstr);

   delete[] newstr; //<<<
   strError.ReleaseBuffer();
0
 
DredwickAuthor Commented:
Thanks Migel!
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Tackle projects and never again get stuck behind a technical roadblock.
Join Now