<div>
I spotted a potential memory leak, this should be better<br />
<br />
procedure TForm1.button1Click(Sender<wbr />: TObject);<br />
var<br />
PName: PChar;<br />
MaxFl,IcoIndex: Cardinal;<br />
NumIcon: Integer;<br />
hLIcon, hSIcon: THandle;<br />
begin<br />
if OpenDialog1.Execute then<br />
&nbsp; begin<br />
&nbsp; GetMem(PName, 1024);<br />
&nbsp; try<br />
&nbsp; &nbsp; StrCopy(PName, PChar(OpenDialog1.FileName<wbr />));<br />
&nbsp; &nbsp; MaxFl := 1023;<br />
&nbsp; &nbsp; IcoIndex := 0;<br />
&nbsp; &nbsp; if not PickIconDlg(Handle, PName, MaxFl, @IcoIndex) then<br />
&nbsp; &nbsp; &nbsp; Exit;<br />
&nbsp; &nbsp;NumIcon := ExtractIconEx(PName, IcoIndex, hLIcon, hSIcon, 1);<br />
&nbsp; &nbsp;finally<br />
&nbsp; &nbsp;FreeMem(PName);<br />
&nbsp; &nbsp;end;<br />
DrawIcon(Canvas.Handle,250<wbr />,43, hLIcon);<br />
end;
</div>


I spotted a potential memory leak, this should be better

procedure TForm1.button1Click(Sender: TObject);
var
PName: PChar;
MaxFl,IcoIndex: Cardinal;
NumIcon: Integer;
hLIcon, hSIcon: THandle;
begin
if OpenDialog1.Execute then
  begin
  GetMem(PName, 1024);
  try
    StrCopy(PName, PChar(OpenDialog1.FileName));
    MaxFl := 1023;
    IcoIndex := 0;
    if not PickIconDlg(Handle, PName, MaxFl, @IcoIndex) then
      Exit;
   NumIcon := ExtractIconEx(PName, IcoIndex, hLIcon, hSIcon, 1);
   finally
   FreeMem(PName);
   end;
DrawIcon(Canvas.Handle,250,43, hLIcon);
end;

<div>
Slick812, thank you!!!<br />
^-^
</div>


<div>
<div class="content wysiwyg-content">
Display it by VB:<br />
<a href="http://www.mvps.org/vbnet/index.html?code/shell/undocchangeicondlg.htm" rel="ugc">http://www.mvps.org/vbnet/index.html?code/shell/undocchangeicondlg.htm</a>
</div>
</div>


Display it by VB:
http://www.mvps.org/vbnet/index.html?code/shell/undocchangeicondlg.htm

How to display the Change Icon Dialog in delphi?

Delphi is the most powerful Object Pascal IDE and component library for cross-platform Native App Development with flexible Cloud services and broad IoT connectivity. It provides powerful VCL controls for Windows 10 and enables FMX development for Windows, Mac and Mobile. Delphi is your choice for ultrafast Enterprise Strong Development™. Look for increased memory for large projects, extended multi-monitor support, improved Object Inspector and much more. Delphi is 5x faster for development and deployment across multiple desktop, mobile, cloud and database platforms including 32-bit and 64-bit Windows 10.