redirect from servlet Filter

don't call chain.doFilter(...) after sendRedirectURL().

if you need further explanation, please let us know and post your filter code here, thanks.

I have already tried to eliminate chain.doFilter(...) and it didnt work.


here is the code:


public class SecureConnectionFilter
    implements Filter {
  private FilterConfig filterConfig = null;

  //Handle the passed-in FilterConfig
  public void init(FilterConfig config) throws ServletException {
    this.filterConfig = config;
  }

  //Process the request/response pair
  public void doFilter(ServletRequest request, ServletResponse response,
                       FilterChain filterChain)
      throws IOException, ServletException {
             
   
    HttpServletRequest httpRequest = (HttpServletRequest) request;
    HttpServletResponse httpResponse = (HttpServletResponse) response;
    HttpSession session = httpRequest.getSession();

    ServletContext context = filterConfig.getServletContext();
   
    if (httpRequest.getScheme().equalsIgnoreCase("http")) {
      String origURL = httpRequest.getRequestURL().toString();
      StringBuffer newbURL = new StringBuffer(origURL);
      newbURL.insert(origURL.indexOf(":"), 's');
      String newURL = newbURL.toString();
      if (httpRequest.getQueryString() != null) {
        newURL = newURL + "?" + httpRequest.getQueryString();
      }
     
      //this cannot be written
      // RequestDispatcher rd = context.getRequestDispatcher("http://localhost:8080/cart/index.html");
      // rd.forward(request, response);
     
     
     
      //and this didnt work
        httpResponse.sendRedirect(httpResponse.encodeRedirectURL(
            "http://localhost:8080/cart/index.html"));
     
     
     
     

    } else {
      try {

          session.setAttribute("SECURITY_SIGN", "secured");

          filterChain.doFilter(request, response);
      }
      catch (ServletException sx) {
        filterConfig.getServletContext().log(sx.getMessage());
      }
      catch (IOException iox) {
        filterConfig.getServletContext().log(iox.getMessage());
      }

    }

  }

try this:
public class SecureConnectionFilter
   implements Filter {
 private FilterConfig filterConfig = null;

 //Handle the passed-in FilterConfig
 public void init(FilterConfig config) throws ServletException {
   this.filterConfig = config;
 }

 //Process the request/response pair
 public void doFilter(ServletRequest request, ServletResponse response,
                      FilterChain filterChain)
     throws IOException, ServletException {
           
   
   HttpServletRequest httpRequest = (HttpServletRequest) request;
   HttpServletResponse httpResponse = (HttpServletResponse) response;
   HttpSession session = httpRequest.getSession();

   ServletContext context = filterConfig.getServletContext();
   
   if (httpRequest.getScheme().equalsIgnoreCase("http")) {
     String origURL = httpRequest.getRequestURL().toString();
     StringBuffer newbURL = new StringBuffer(origURL);
     newbURL.insert(origURL.indexOf(":"), 's');
     String newURL = newbURL.toString();
     if (httpRequest.getQueryString() != null) {
       newURL = newURL + "?" + httpRequest.getQueryString();
     }
     
     //this cannot be written
     // RequestDispatcher rd = context.getRequestDispatcher("http://localhost:8080/cart/index.html");
     // rd.forward(request, response);
     
     
     
     //and this didnt work
       response.sendRedirect(httpResponse.encodeRedirectURL(
           "http://localhost:8080/cart/index.html"));
     
     
     
     

   } else {
     try {

         session.setAttribute("SECURITY_SIGN", "secured");

         filterChain.doFilter(request, response);
     }
     catch (ServletException sx) {
       filterConfig.getServletContext().log(sx.getMessage());
     }
     catch (IOException iox) {
       filterConfig.getServletContext().log(iox.getMessage());
     }

   }

 }

use response instead of httpResponse.

CJ

"response" is of type javax.servlet.ServletResponse which has no sendRedirect method.

so your solution does not work.

Thanks anyway..

- Rabih

you are right.  My code I cast it as the same var.

Have you tried not encoding the URL.
 response.sendRedirect("http://localhost:8080/cart/index.html");

CJ

if you have to encode URL params just encode those.

CJ

yes, i have tried both, casting it to response and eliminating the encoding, and it didnt work!

-RAB

that's strange, you code looks fine to me. are you sure that your mapping is correct and your filter is get called?

anyway, can you try out this code, it works for me:

import javax.servlet.*;

public class MyFilter implements Filter {
 public void doFilter(ServletRequest request, ServletResponse response, FilterChain filterChain)
      throws java.io.IOException, ServletException
 {
   System.out.println( "my fileter is called" );
   ((javax.servlet.http.HttpServletResponse)response).sendRedirect("http://localhost:8080/cart/index.html");
 }

 public void init(FilterConfig filterConfig) {}
 public void destroy() {}
}

and make sure you see "my fileter is called" is printed in server log.

Thanks for your help. Actually "return" was the solution, even though i have tried it before, but i eliminated everything between the sendDirect and the return, so it worked fine. Actually the problem was a combination of also other things, because i had, and still, problem when there is many recursive sendRedirect (not in the same chain, but in the same request)... anyway, it is resolved now in some kind of workaround.. thanks... R.

Thanks for all of you..

yeah the return; statement is needed to give control back.  the smallest stmt can cause problems y'know :-)

Glad I could help and Thanx for the "A"

CJ