• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 211
  • Last Modified:

pointers and memory question

I am a novice c++ programmer and I am confused about a couple of issues with pointers and memory allocation.   I have three subquestions concerning a class that contains a pointer member variable, but I don't explicitly assign it to a memory location on the free store using new within the class anywhere.  

Part One:
Do I need to worry about deleting it in the destructor?

 For example, here is a Node class that could be used in a linked list.

class Node
Node(): next(0) {};
~Node(); // need to delete next here?
Node * next;  // Here is the pointer in question
double its_length;

Now imagine I make a pointer to a Node and allocate it some space on the heap with new:

int main()
Node * pNode = new Node;  // Line 3
delete pNode;
pNode = 0;
return 0;
Part two :
After the use of new in line three, I have pNode point to an object Node allocated on the free store, is the member variable next now on the free store and do I have to worry about delete within the destructor of Node?  This brings up the point that as the author of the class Node but not the main function necesssarily, I don't know whether the Node objects will be placed on the heap or not.  

Part three:
If I don't need to use delete in this simple example, that means the default copy constructor, and assignment operators are also fine?

Thanks for helping me clear up this confusion!
  • 2
1 Solution
Part 1:
~Node(); // need to delete next here?

I think if you call delete here for "Next",
you will be in effect calling delete on every next node in the list. Unless that is what you want to do, the answer to #1 is no.

is the member variable next now on the free store ...

When you call delete on a node, you are freeing the memory for that instance.
The "Next" pointer doesn't need to be deleted.
Pointers are usualy alllocated from the stack, and hold the memory address, in this case of the "node" which is allocated from the heap by calling "new".

A pointer to the head of the list should be passed to the constructor to initialise the "Next" member.
If you are creating the first node, you should pass it NULL.

does this make any sense ?
Example: constructor for linked list class.
(this class uses the default destructor)

__fastcall TTileNumber::TTileNumber(int number, int posX,
                                           int posY, TTileNumber* Next)
    FTileNumber = number;
    FX = posX;
    FY = posY;
    FNext = Next;

Example: searching through linked list.

TTileNumber*__fastcall TTileNumber::FindNumber(int number)
    if(number == FTileNumber)
        return (TTileNumber*) this;
        return (TTileNumber*) 0;
    return FNext->FindNumber(number);

if you call delete on "FNext" in the destructor, there would be nothing to search for. :)

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now