• C

Simple message relay using Fifo IPC's & file locking

Hi im new to C programming.

Im trying to create a simple program which relays messages between two users on a linux machine using IPC's.
At the moment a sent message may arrive at the source or destonation program. How could i fix this problem?

I want a message from 1st program to arrive at the 2nd program and vice versa.  


I assume 1 way would be to lock/unlock the fifo file, so that only one user may send, while the other recives and vice versa.
How could i do this, and are the other solutions?

Here is some of the code

pid = fork()

for(;;)
{
      if(pid == 0) // child
      {            
            mkfifo(fifo, 0666); // create fifo if it already doesnt exist
      
            if((fd = open(fifo, O_RDWR)) <0) // open fifo for reading and writing
              printf("fifo failed");

            for(;;)  // recive and print msg
            {
            read(fd, msgbuf, MAXLEN+1)
            printf("\n\n messgae rcvd: %s", msgbuf);
            //sleep(1);
            }
      }

       while(waitpid(pid, &status, WNOHANG) == 0)

                    {      // create and send msg
            fd = open(fifo, O_WRONLY | O_NONBLOCK)
                        
            printf("\n\n please enter a message :");
            load_string(msgbuf, MAXLEN);

            nwrite = write(fd, msgbuf, MAXLEN+1)
            //sleep(3);
            
      }
}

Thanx = )
FOXBATAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Kent OlsenData Warehouse Architect / DBACommented:

From the looks of your code, the "while(waitpid(...))" block of code is executed by both the parent and child, but the upper block is execute only by the child.

The child task opens the fifo and waits for a message.  The parent falls through to the while() block, opens the fifo, prints a message and writes a string to the fifo.

The child tries to continually reopen the fifo.  First in O_RDWR, then in O_WRONLY, then looping on the sequence.  The parent only opens the fifo O_WRONLY.



Kent
0
AjarCommented:
kdo ,
      The code is ok in regards of  upper block getting invoked only by child process and lower by the parent .This is due to the infinite loop in the upper block.

Coming back to the original problem ,
     Using two fifos/pipes instead of one  for establishing the duplex link will  be easier to implement
rather than using locks and  some technique to synchronize the two  process read and writes .


0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
FOXBATAuthor Commented:
ok thanx i thought about the two pipes b4, Im gonna try implement that now.

But getting back to the lock issue,  i added this code to sending program part

char * lck ="lck";
int lk;
extern int errno;

if((lk = open(lck, O_RDWR | O_CREAT | O_EXCL, 0600)) < 0)
{
      if(errno == EEXIST)
            { printf("lck exists"); exit(1); }
      else
            { printf("WTF"); exit(127); }
}
which works fine, creating the lock.

however i cannot remove it. i tried using close(lk); But it didnt work.

as when the program was run again 'lck exists" was displayed and lck file was still in directory

How can i remove the lock?
0
What were the top attacks of Q1 2018?

The Threat Lab team analyzes data from WatchGuard’s Firebox Feed, internal and partner threat intelligence, and a research honeynet, to provide insightful analysis about the top threats on the Internet. Check out our Q1 2018 report for smart, practical security advice today!

Sys_ProgCommented:
For implementing two way messaging,

U can also think of Message Queues



0
FOXBATAuthor Commented:
Thanx i got it 2 work, how ever im wondering if i could ask you  some easy, genral questions about linux.

1) how can i copy to floppy, i went mnt/floppy, but was unable to read/write to it.
The floppy drive works fine under windows.

0
Kent OlsenData Warehouse Architect / DBACommented:

Many linux implementations have a complete library of tools to read DOS formatted devices.  You can get a pretty good list with:

man -k DOS

In particular, look at mtools(1) and mcopy(1).


Kent
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.