• C

Urgent!!! Can't find the problem...

I wrote a program to find the bigger and the smaller number in a list but there's something wrong and don't know what it is becuse the program just gives me the biggest number while in the smaller number always appear 0.  Thanks for your help!!!
Here it is:

#include <stdio.h>

void main()
{
 int arr[10], n, dat, max=0, min=0;
 for(n=0;n<=9;n++)
 {
  printf("Number: ");
  scanf("%d",&dat);
  if(dat>max)max=dat;
 if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
}
gothic130Asked:
Who is Participating?
 
bobbit31Commented:
for(n=0;n<=9;n++)
 {
  printf("Number: ");
  scanf("%d",&dat);

  if (n == 0) min = dat;

  if(dat>max)max=dat;

  if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
0
 
gothic130Author Commented:
>>if (n == 0) min = dat;

 Please could you explain me what this line does?
0
 
guitardude101Commented:
You should initialize min to INT_MAX instead of 0
You should initialize max to INT_MIN instead of 0

They defined in <limits.h>

0
Become a Leader in Data Analytics

Gain the power to turn raw data into better business decisions and outcomes in your industry. Transform your career future by earning your MS in Data Analytics. WGU’s MSDA program curriculum features IT certifications from Oracle and SAS.  

 
bobbit31Commented:
> Please could you explain me what this line does?

basically, your min starts out at 0... if all the numbers in the array are positive, min will always be 0.

what the line above does is it sets min to the first element in the array... if the first element is the min then it stays the min, otherwise it'll keep going through and update min accordingly (note that if (n==0) will only happen once)
0
 
Kent OlsenData Warehouse Architect / DBACommented:

Using the code in the original question, a small change (similar to bobbit31's) should do just fine:

#include <stdio.h>

void main()
{
 int arr[10], n, dat, min, max;

 min = arr[0];                /*  Default min to the first value  */
 max = arr[0];               /*  Default max to the first value  */
 for(n=1;n<=9;n++)      /*  Search the rest of the list  */
 {
  printf("Number: ");
  scanf("%d",&dat);
  if(dat>max)max=dat;
 if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
}


Kent
0
 
guitardude101Commented:
gothic130 your algrythm will work if you just change the initialization as above.
It would also allow you to enter negative numbers.
0
 
gothic130Author Commented:
Thank you all:)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.