Solved

# Urgent!!! Can't find the problem...

Posted on 2003-10-29
189 Views
I wrote a program to find the bigger and the smaller number in a list but there's something wrong and don't know what it is becuse the program just gives me the biggest number while in the smaller number always appear 0.  Thanks for your help!!!
Here it is:

#include <stdio.h>

void main()
{
int arr[10], n, dat, max=0, min=0;
for(n=0;n<=9;n++)
{
printf("Number: ");
scanf("%d",&dat);
if(dat>max)max=dat;
if(dat<min)min=dat;
}
printf("Bigger %d Smaller %d",max,min);
}
0
Question by:gothic130
• 2
• 2
• 2
• +1

LVL 18

Accepted Solution

bobbit31 earned 150 total points
for(n=0;n<=9;n++)
{
printf("Number: ");
scanf("%d",&dat);

if (n == 0) min = dat;

if(dat>max)max=dat;

if(dat<min)min=dat;
}
printf("Bigger %d Smaller %d",max,min);
0

Author Comment

>>if (n == 0) min = dat;

Please could you explain me what this line does?
0

LVL 1

Expert Comment

You should initialize min to INT_MAX instead of 0
You should initialize max to INT_MIN instead of 0

They defined in <limits.h>

0

LVL 18

Expert Comment

> Please could you explain me what this line does?

basically, your min starts out at 0... if all the numbers in the array are positive, min will always be 0.

what the line above does is it sets min to the first element in the array... if the first element is the min then it stays the min, otherwise it'll keep going through and update min accordingly (note that if (n==0) will only happen once)
0

LVL 45

Assisted Solution

Kdo earned 100 total points

Using the code in the original question, a small change (similar to bobbit31's) should do just fine:

#include <stdio.h>

void main()
{
int arr[10], n, dat, min, max;

min = arr[0];                /*  Default min to the first value  */
max = arr[0];               /*  Default max to the first value  */
for(n=1;n<=9;n++)      /*  Search the rest of the list  */
{
printf("Number: ");
scanf("%d",&dat);
if(dat>max)max=dat;
if(dat<min)min=dat;
}
printf("Bigger %d Smaller %d",max,min);
}

Kent
0

LVL 1

Expert Comment

gothic130 your algrythm will work if you just change the initialization as above.
It would also allow you to enter negative numbers.
0

Author Comment

Thank you all:)
0

## Featured Post

### Suggested Solutions

Have you thought about creating an iPhone application (app), but didn't even know where to get started? Here's how: ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ Important pre-programming comments: I’ve never tri…
Preface I don't like visual development tools that are supposed to write a program for me. Even if it is Xcode and I can use Interface Builder. Yes, it is a perfect tool and has helped me a lot, mainly, in the beginning, when my programs were small…
The goal of this video is to provide viewers with basic examples to understand opening and writing to files in the C programming language.
The goal of this video is to provide viewers with basic examples to understand opening and reading files in the C programming language.