Solved

Urgent!!! Can't find the problem...

Posted on 2003-10-29
7
192 Views
Last Modified: 2010-04-15
I wrote a program to find the bigger and the smaller number in a list but there's something wrong and don't know what it is becuse the program just gives me the biggest number while in the smaller number always appear 0.  Thanks for your help!!!
Here it is:

#include <stdio.h>

void main()
{
 int arr[10], n, dat, max=0, min=0;
 for(n=0;n<=9;n++)
 {
  printf("Number: ");
  scanf("%d",&dat);
  if(dat>max)max=dat;
 if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
}
0
Comment
Question by:gothic130
  • 2
  • 2
  • 2
  • +1
7 Comments
 
LVL 18

Accepted Solution

by:
bobbit31 earned 150 total points
ID: 9645336
for(n=0;n<=9;n++)
 {
  printf("Number: ");
  scanf("%d",&dat);

  if (n == 0) min = dat;

  if(dat>max)max=dat;

  if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
0
 

Author Comment

by:gothic130
ID: 9645408
>>if (n == 0) min = dat;

 Please could you explain me what this line does?
0
 
LVL 1

Expert Comment

by:guitardude101
ID: 9645745
You should initialize min to INT_MAX instead of 0
You should initialize max to INT_MIN instead of 0

They defined in <limits.h>

0
Free learning courses: Active Directory Deep Dive

Get a firm grasp on your IT environment when you learn Active Directory best practices with Veeam! Watch all, or choose any amount, of this three-part webinar series to improve your skills. From the basics to virtualization and backup, we got you covered.

 
LVL 18

Expert Comment

by:bobbit31
ID: 9645842
> Please could you explain me what this line does?

basically, your min starts out at 0... if all the numbers in the array are positive, min will always be 0.

what the line above does is it sets min to the first element in the array... if the first element is the min then it stays the min, otherwise it'll keep going through and update min accordingly (note that if (n==0) will only happen once)
0
 
LVL 45

Assisted Solution

by:Kent Olsen
Kent Olsen earned 100 total points
ID: 9645850

Using the code in the original question, a small change (similar to bobbit31's) should do just fine:

#include <stdio.h>

void main()
{
 int arr[10], n, dat, min, max;

 min = arr[0];                /*  Default min to the first value  */
 max = arr[0];               /*  Default max to the first value  */
 for(n=1;n<=9;n++)      /*  Search the rest of the list  */
 {
  printf("Number: ");
  scanf("%d",&dat);
  if(dat>max)max=dat;
 if(dat<min)min=dat;
 }
 printf("Bigger %d Smaller %d",max,min);
}


Kent
0
 
LVL 1

Expert Comment

by:guitardude101
ID: 9645854
gothic130 your algrythm will work if you just change the initialization as above.
It would also allow you to enter negative numbers.
0
 

Author Comment

by:gothic130
ID: 9645950
Thank you all:)
0

Featured Post

Master Your Team's Linux and Cloud Stack

Come see why top tech companies like Mailchimp and Media Temple use Linux Academy to build their employee training programs.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This tutorial is posted by Aaron Wojnowski, administrator at SDKExpert.net.  To view more iPhone tutorials, visit www.sdkexpert.net. This is a very simple tutorial on finding the user's current location easily. In this tutorial, you will learn ho…
Examines three attack vectors, specifically, the different types of malware used in malicious attacks, web application attacks, and finally, network based attacks.  Concludes by examining the means of securing and protecting critical systems and inf…
The goal of this video is to provide viewers with basic examples to understand how to use strings and some functions related to them in the C programming language.
Video by: Grant
The goal of this video is to provide viewers with basic examples to understand and use nested-loops in the C programming language.

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question