Solved

VBA problem

Posted on 2003-10-29
6
232 Views
Last Modified: 2008-02-01
Hi,
I have a worksheet as below:
        columnA  columnB  columnC  columnD  columnE
        48.00        44.00      44.00       48.00

in the VBE, i will create a macro that will insert a formula into columnE.
this is my formula:
cells(1,5).formula="=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))"
(the value in cells(1,5) should be 46.00)

then i write a coding to change the value in cells(1,5)  :
if cells(1,5) mod 4 <1 then
     cells(1,5).formula="=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                                   (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))"
elseif cells(1,5) mod 4 <2 then
     cells(1,5).formula="=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                                   (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))-1"
elseif cells(1,5) mod 4<3 then
     cells(1,5).formula="=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                                   (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))+2"
else
     cells(1,5).formula="=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                                   (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))+1"
end if


The coding above meaning it will round the number.
For example, if the value is 5, it will be rounded to 4
                    if the value is 7, it will be rounded to 8
                    if the value is 6, it will be rounded to 8
                    if the value is 3, it will be rounded to 4
                                                                       
so, after i run the macro, the final value for cells(1,5) should be 48.00. Agree?
Now the value in cells(1.5) is 48.00, it will add 2 to the 46.00.

The problem is when i change the value in cells(1,1) to 100.00, the value in cells(1,5) is 61.00. By right the value should be 60.00. What can i do to the coding so that i will get the value of 60.00 in cells(1,5) when i change the value in cells(1,1) to 100. (Meaning i don't wan to run the macro again, i just have to run the macro once, and in the future, when i change the value in cells(1,1), it will gives me the correct value for the cells(1,5) ).

Anyone know how to do it?


cheers,
brandon
0
Comment
Question by:brandonsinger
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
6 Comments
 
LVL 5

Expert Comment

by:drnick
ID: 9647970
maybe you can concatenate all the formulas together.
like:
"if(mod(" & cells(1,5).value & ",4)<1," & _
"IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                  (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))" &_
",if(mod("& cells(1,5).value & ",4)<2," &
"IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1),TRUNC(AVERAGE
                  (A1:D1)),ROUNDUP(AVERAGE(A1:D1),0)))-1"

and so on.
you can include the old cells value in your formula "the hard way", and thus, it should work.
ok, you formula gets a little bit longer, but whatever..
0
 
LVL 24

Accepted Solution

by:
R_Rajesh earned 345 total points
ID: 9653699
Hey !   brandonsinger,

the problem is that macors dont monitor sheets for changes. so when you change the value of A1 to 100 sheet E1 will contain the previous foumula which calculates it to 61. running the macro again will change the foumula which will change it to 60.

to automate this process so that you dont have to run the macro again copy this code the workbook_change function of your work book. this code recalculates the formula whenever a value in any of the 4 columns of first row is changed

(in your workbook hit ALT+F11 and paste the following code and return to excel)

------------
Private Sub Workbook_SheetChange(ByVal Sh As Object, ByVal Target As Range)
If Target.Column < 5 And Target.Row = 1 Then
Cells(1, 5).Formula = "=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1)," & _
"TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0))"
If Cells(1, 5) Mod 4 < 1 Then
Cells(1, 5).Formula = "=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1)," & _
"TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0))"
ElseIf Cells(1, 5) Mod 4 < 2 Then
Cells(1, 5).Formula = "=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1)," & _
"TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0))-1"
ElseIf Cells(1, 5) Mod 4 < 3 Then
Cells(1, 5).Activate
ActiveCell.Formula = "=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1)," & _
"TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0))+2"
Else
Cells(1, 5).Formula = "=IF(AND(MOD(AVERAGE(A1:D1),1)<0.1,AVERAGE(A1:D1)>1)," & _
"TRUNC(AVERAGE(A1:D1)),ROUNDUP(AVERAGE(A1:D1),0))+1"
End If
End If
End Sub
-------------
0
 

Author Comment

by:brandonsinger
ID: 9654464
R_Rajesh,
What is the meaning og the "target.column" ?
Where the parameter that pass to this function come from?

cheers,
brandon
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 24

Expert Comment

by:R_Rajesh
ID: 9654535
target.column gives you the column number of the cell thats being changed. say you changed the value in B4, here the column is 4 so target.column will contain 4 and B is second column so target.column will contain 2. As soon as you change any value a workbook_change event will be triggered, we can trap these events using worksheet of workbook funcitons and the parameters from these functions will contain various information regarding the current state of the application.

in vbe press F1 go to answer wizard and make a search for type application object events.

btw did it solve the problem
0
 
LVL 24

Expert Comment

by:R_Rajesh
ID: 9654599
here the column is 4 so target.column will contain 4 and B is second column so target.column will contain 2   <----------

in my previous post the above line should read

here the row is 4 so target.row will contain 4 and B is second column so target.column will contain 2
0
 
LVL 5

Expert Comment

by:drnick
ID: 9655680
what is wrong with concatenating the formulas and inserting the old value of cells(1,5)?
this'll do also and is simple
0

Featured Post

Salesforce Has Never Been Easier

Improve and reinforce salesforce training & adoption using WalkMe's digital adoption platform. Start saving on costly employee training by creating fast intuitive Walk-Thrus for Salesforce. Claim your Free Account Now

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Since upgrading to Office 2013 or higher installing the Smart Indenter addin will fail. This article will explain how to install it so it will work regardless of the Office version installed.
In Part II of this series, I will discuss how to identify all open instances of Excel and enumerate the workbooks, spreadsheets, and named ranges within each of those instances.
The viewer will learn how to make their project stand out over others by learning how to change colors and shapes, add spaces, change directions, and add bullets to their charts.
Learn how to create and modify your own paragraph styles in Microsoft Word. This can be helpful when wanting to make consistently referenced styles throughout a document or template.

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question