Solved

C characters and strings

Posted on 2003-10-31
13
345 Views
Last Modified: 2012-05-04
#include <stdio.h>
#include <conio.h>
#include <stdlib.h>
#include <string.h>


int main()
{
      char *LineOfText;
      char *StringToSearch;
      char *SearchPtr;
      clrscr();
      printf("\n Enter a line of text :");
      gets(LineOfText);
      printf("Enter the search string :");
      gets(StringToSearch);
      for(int i=0;strlen(LineOfText)>0;i++)
      {
            SearchPtr = strstr(LineOfText,StringToSearch);
            printf("SearchPtr = %s\n",SearchPtr);
            sprintf(LineOfText,SearchPtr);
            printf("Line      = %s\n",LineOfText);
      }
      return 0;
}

I made this code, but it didn't work well. Could you tell me which codes are wrong and how I can fix them?

Thanks
0
Comment
Question by:john2789
  • 6
  • 4
  • 2
  • +1
13 Comments
 
LVL 19

Expert Comment

by:Dexstar
Comment Utility
john2789:

Well, what do you want it to do?

Try removing this line, for starters:
     for(int i=0;strlen(LineOfText)>0;i++)

Hope that helps,
Dex*
0
 

Author Comment

by:john2789
Comment Utility
I don't need it?
0
 
LVL 1

Expert Comment

by:guitardude101
Comment Utility
Your first bug is that you are reading a string into LineOfText and *StringToSearch without having allocated any memory.
change
     char *LineOfText;
     char *StringToSearch;

to
     char LineOfText[1024];
     char StringToSearch[1024];

This will allow you to use strings that are up to 1023 bytes long
0
 
LVL 19

Expert Comment

by:Dexstar
Comment Utility
john2789:

> I don't need it?

You don't seem to need it, but you should tell me WHAT the program is SUPPOSED to do, so I can help you make it do that.  Otherwise, I can't really help you.

But guitardude101's suggestions are also valid.  Be sure to incorporate them.

Dex*
0
 

Author Comment

by:john2789
Comment Utility
Original problem is like this:
write a program that inputs a line of text and a search string from the keyboard. Using function strstr, locate the first occurence of the search string in the line of text, and assign the location to variable searchptr of type char*. If the search string is found, print the reminder of the line of text beginning with the search string. Then, use strstr again to locate the next occurrence of the search string in the line of text. If a second occurrence is found, print the remainder of the line of text beginning with the second occurrence.
0
 

Author Comment

by:john2789
Comment Utility
TO: guitardude101

hmm... I still have some error... I changed the code you suggested me, but still I have the error. Could you please tell me how I can do?
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 19

Expert Comment

by:Dexstar
Comment Utility
This is clearly a homework problem.  If you didn't already have a good start on it, I wouldn't help you.  It's against the site rules.

Try this:

      #include <stdio.h>
      #include <conio.h>
      #include <stdlib.h>
      #include <string.h>


      int main()
      {
            char LineOfText[1024];
            char StringToSearch[1024];
            char *SearchPtr;

            clrscr();
            printf("\n Enter a line of text :");
            gets(LineOfText);
            printf("Enter the search string :");
            gets(StringToSearch);
            for ( SearchPtr = strstr(LineOfText, StringToSearch) ;
                        SearchPtr != NULL ;
                        SearchPtr = strstr(SearchPtr+1, StringToSearch) )
            {
                  printf("SearchPtr = %s\n",SearchPtr);
            }
            return 0;
      }

HTH,
Dex*

Boo!
0
 

Author Comment

by:john2789
Comment Utility
TO: Dexstar

This is not an assignment. I do not goto school right now. I am in home and study C programming by myself. I just picked one problem and have tried to solve problems, and try to understand how C programming will work.


          printf("\n Enter a line of text :");
          fflush (stdin);
          gets(LineOfText);
          printf("Enter the search string :");
          fflush(stdin);
          gets(StringToSearch);
         

           getch();
           return 0;
Do I need fflush(stdin); after printf and gectch() before return 0? Because some of C programming reference books write fflush(..) and gech(). What are these codes and am I better to use these codes for this problem, too?

Thanks
0
 
LVL 19

Accepted Solution

by:
Dexstar earned 125 total points
Comment Utility
john2789:

> This is not an assignment. I do not goto school right now. I am in home and
> study C programming by myself. I just picked one problem and have tried to
> solve problems, and try to understand how C programming will work.

Okay, that's fair.  And a good way to learn.

> Do I need fflush(stdin); after printf and gectch() before return 0? Because
> some of C programming reference books write fflush(..) and gech(). What are
> these codes and am I better to use these codes for this problem, too?

I don't think you need them.  Try it without them, and see if it works.  gets() should be all you need.

Dex*
0
 

Author Comment

by:john2789
Comment Utility
ok, I will try now
0
 
LVL 1

Expert Comment

by:guitardude101
Comment Utility
no assisist??
0
 

Author Comment

by:john2789
Comment Utility
TO:guitardude101
how can I put the score on you, too?
0
 

Expert Comment

by:bojojo
Comment Utility
hi

0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Have you thought about creating an iPhone application (app), but didn't even know where to get started? Here's how: ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ Important pre-programming comments: I’ve never tri…
This is a short and sweet, but (hopefully) to the point article. There seems to be some fundamental misunderstanding about the function prototype for the "main" function in C and C++, more specifically what type this function should return. I see so…
The goal of this video is to provide viewers with basic examples to understand how to use strings and some functions related to them in the C programming language.
The goal of this video is to provide viewers with basic examples to understand and use switch statements in the C programming language.

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now