Solved

Optional Parameters for Update

Posted on 2003-11-06
13
1,764 Views
Last Modified: 2010-05-18
Hello all,

I am building an ASP application which will update a SQL Server database.

The app will, at various times, update several different fields within the same table.  For example, if I am updating a customers table, I may need to update only address one time, and only phone number another time, and still yet other times, I may need to update all fields in the table.  It seems like I shouldn't have to write separate stored procedures for each of these instances.  How can I write my stored procedure such that I can update a variable number of fields each time it is called.
0
Comment
Question by:knottydrd
  • 6
  • 3
  • 3
  • +1
13 Comments
 
LVL 58

Accepted Solution

by:
amit_g earned 250 total points
Comment Utility
Build the update statement in ASP dynamically instead of writing the stored procedure.
0
 

Author Comment

by:knottydrd
Comment Utility
I've done that in the past, but I've not been happy with the performance.  Is there a way to do it in SQL Server Stored Proc?
0
 
LVL 58

Expert Comment

by:amit_g
Comment Utility
There is no performance gain by using stored procedure vs. executing the dynamic sql as the SQL server caches last few queries irrespctive of its origin. Stored procedure are also cached in the same way as any other dynamic query and so they have no advantage performance wise.

You can have optional parameter in stored procedures and do what you are asking but that only complicates the code and spreads business logic in 2 places instead of one. That is a maintanace overhead. Unless you or your company has a standard of writing all queries in stored procedure, there is no need for writing stored procedures for simple queries like one line select, update and inserts.

If you still feel that you need to write a stored procedure we can tell you how to use optional parameters.
0
 

Author Comment

by:knottydrd
Comment Utility
I'm working with an existing application in which all other db opps are done using stored procedures.
0
 
LVL 15

Expert Comment

by:namasi_navaretnam
Comment Utility
Amit G is absolutely right!

Here is an example.

   sSQL = ""      
   sSQL = sSQL + " Update  MyTable "
   sSQL = sSQL + " Set My_id = " + CStr(aMyId) + ",  "
   sSQL = sSQL + "     Status = 'Test.' "
   sSQL = sSQL + "  Where (Status = 'A') "

   objConn1.BeginTrans  
   objConn1.Execute sSQL
   objConn1.CommitTrans

But the easiest way to to update all fields all the time if possible. It would be easier to maintain such code that way.

Even if you do that using strored proc, pass a value to all input parameters all time. But within proc update fields where the corresponding input variables are not null.

This way you have only one proc.

 
   
0
 
LVL 58

Expert Comment

by:amit_g
Comment Utility
Ok. Here is how you can create a stored procedure with optional parameters ...

CREATE PROCEDURE MyStoredProcedure
       @first int = NULL
      ,@second int = NULL
      ,@third int = 0
AS

...
...
...

You can give a null value or a predetermined value to any parameter that you make an optional parameter. Later in the logic you can check if the parameter has the default value (say null) and that means it was not passed by the caller. To call these stored procedure from the client you can use ADO's Command object with or without Parameters. For example you could call the aboove stored procedure as

    cmd.CommandText = "MyStoredProcedure"
    cmd.CommandType = adCmdStoredProc
    cmd.Parameters.Append cmd.CreateParameter("@second", adInteger, adParamInput)
    cmd.Parameters("param1") = Whatever

    cmd.Execute

This way you have passed only second parameter. You can also call this in this way ...

    cmd.CommandText = "exec MyStoredProcedure @second = " & Whatever

    cmd.Execute
0
Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

 

Author Comment

by:knottydrd
Comment Utility
Thanks!  Let me review and try this out, I'll post as to how it goes.
0
 
LVL 75

Expert Comment

by:Anthony Perkins
Comment Utility
Also, when you get a chance please maintain yur old open questions:

1 09/02/2003 250 Email a "Fillable" PDF  Open JavaScript
2 08/07/2003 125 Unable to open registry key  Open Active Server Pages (ASP)
3 09/14/2003 250 NVidia Video Card only 16 colors  Open Windows ME
4 10/02/2003 500 Implicit conversion from data type varch...  Open Microsoft SQL Server

Thanks,
Anthony
0
 
LVL 15

Assisted Solution

by:namasi_navaretnam
namasi_navaretnam earned 250 total points
Comment Utility
Within your stored proc you write an update statement using case. This way you have single proc to update you table.

Let say for example  @col1, col2 are input parameters. (col1 is varchar, col2 is integer)

update YourTable
set col1 = CASE WHEN (@col1 IS NULL or @col1 = '') THEN col1 ELSE @col1 END,
    col2 = CASE WHEN (@col2 IS NULL) THEN col2 ELSE @col2 END
where pk_id = @pk_id


My Example that works,

declare @job_desc varchar(100),
        @min_lvl integer

select @job_desc = 'TEST', @min_lvl = 10

update Jobs
set job_desc = CASE WHEN (@job_desc IS NULL or @job_desc = '') THEN Job_Desc ELSE @Job_DESC END,
    min_lvl = CASE WHEN (@min_lvl IS NULL) THEN min_lvl ELSE @min_lvl END
where job_id = 1


HTH

Namasi Navaretnam
0
 
LVL 15

Expert Comment

by:namasi_navaretnam
Comment Utility
Would you need further help? If not, please close this issue. :)

Regards.
0
 

Author Comment

by:knottydrd
Comment Utility
Ok.  I'll close it today.
0
 

Author Comment

by:knottydrd
Comment Utility
I'm splitting the points because this project was scuttled and I never got a chance to fully implement these solutions.  I am picking the "right" answer based upon tests that I did at the time of this post.
0
 

Author Comment

by:knottydrd
Comment Utility
Amit_g's original answer turned out to be the best solution.  It is best to make the dynamic SQL statement in your ASP code, but in this particular application, I was extending functionality of an established app.  This app made strict use of keeping queries in Stored Procedures and not ASP.  I felt that it was best to continue this with the extension that I was working on.

Thanks all for the comments.
0

Featured Post

What is SQL Server and how does it work?

The purpose of this paper is to provide you background on SQL Server. It’s your self-study guide for learning fundamentals. It includes both the history of SQL and its technical basics. Concepts and definitions will form the solid foundation of your future DBA expertise.

Join & Write a Comment

Suggested Solutions

Let's review the features of new SQL Server 2012 (Denali CTP3). It listed as below: PERCENT_RANK(): PERCENT_RANK() function will returns the percentage value of rank of the values among its group. PERCENT_RANK() function value always in be…
This article explains how to reset the password of the sa account on a Microsoft SQL Server.  The steps in this article work in SQL 2005, 2008, 2008 R2, 2012, 2014 and 2016.
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.

763 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

6 Experts available now in Live!

Get 1:1 Help Now