Solved

Division Precision

Posted on 2003-11-10
10
834 Views
Last Modified: 2010-04-01
Im writing a progarm to calculate PI and my problem is c++ rounds everything in division so i have an endless answer of "3" ive done seprecsision for cout statement and that is fine but i need to fix the division my equation is PI = 4-4/3+4/5-4/7+4/9-4/11+4/13-4/15...

Here is my actual math part of my script:

  Cal = 4/Odd;
  Odd += 2;
  Calc -= Cal;
  Cal = 4/Odd;
  Odd += 2;
  Calc += Cal;
  Pi = Calc;

This is in a for loop then it saves and repeats
0
Comment
Question by:Deathbob
  • 4
  • 2
  • 2
  • +2
10 Comments
 
LVL 17

Expert Comment

by:rstaveley
ID: 9719892
C++ treats 4 as an integer.

Write 4.0 to get a division on a double.

e.g.

     Cal = 4.0/Odd;

Make sure all of your variebles are doubles for double precision.
0
 
LVL 5

Assisted Solution

by:waelothman
waelothman earned 65 total points
ID: 9719944
dividing integer with integer always give an integer value so you have to do 1 of 3 ways

as rstaveley say make any number of them float

or write it
cal = (float) 4/Odd
0
 
LVL 1

Author Comment

by:Deathbob
ID: 9720376
As i counted i think i can get 52 decimal places give or take, but can i get more?
0
Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

 
LVL 1

Author Comment

by:Deathbob
ID: 9720379
THANKS FOR YOUR HELP BY THE WAY, BUT IM GONNA TRY AND PUSH IT TO THE MAX
0
 
LVL 13

Expert Comment

by:SteH
ID: 9720762
Yes,
1) go to extended instead of double. This increases the number of bits used for the mantissa.

Then you have the problem that the mantissa is limited and the value won't change the exponent of the number 3.1415e0: At some place the number calc + 4/2n+1 can't be distinguished from calc + 4/2n+1 - 4/2n+3 with the chosen precision of your var.  To reach a higher precision you have to remove the leading. Now it helps to remove some known digits of pi and so changing the exponent of it. Thereby you increase the available bits for the mantissa to distinguish these numbers.
0
 
LVL 32

Expert Comment

by:jhance
ID: 9721385
>>BUT IM GONNA TRY AND PUSH IT TO THE MAX

I hate to be the bearer of bad news here but you're not going to live long enough to push this to the max.  PI is a transcendental irrational number and has an infinite number of digits.  Using computers PI has been calculated to many millions of digits but you're unlikely to even approach that using your methods.
0
 
LVL 1

Author Comment

by:Deathbob
ID: 9723665
Its for fun and becides just the thought of haveing a program that can attempt this is nice (sence of acomplishment).
0
 
LVL 32

Expert Comment

by:jhance
ID: 9723706
Well take at look at this:

http://projectpi.sourceforge.net/

If you're going to try and accomplish something, at least use a technique that is potentially usefule.
0
 
LVL 1

Author Comment

by:Deathbob
ID: 9723729
how do you define an extended variable?

Here is my script

//Pi Calculation Software Alpha

//START ODD VALUE : 3
//START CALC VALUE : 4
//:Placed in files:

#include <iostream.h>
#include <fstream.h>
#include <stdlib.h>
#include <math.h>
#include <iomanip>


char Buffer[100];
int Odd;
int Oddc;
double Cal;
double Calc;
double Pi;
int i;
int pre = 52;

void LoadFiles();
void DoIt();
void ShowIt();
void SaveIt();

void main ()
{
 LoadFiles();
 system("pause");
 DoIt();
}

void LoadFiles()
{
 ifstream ODDB ("Odd.txt");
 ODDB.getline(Buffer,100);
 Odd = atoi(Buffer);
 ODDB.close();

 ifstream CalcB ("Calc.txt");
 CalcB.getline(Buffer,100);
 Calc = atof(Buffer);
 CalcB.close();

}

void DoIt()
{
//Calculates and saves every 10000 calculations
 for (i = 0; i <= 5000; i++)
 {
  Cal = (float) 4/Odd;
  Odd += 2;
  Calc -= Cal;
  Cal = (float) 4/Odd;
  Odd += 2;
  Calc += Cal;
  Pi = Calc;
  ShowIt();

 }

 SaveIt();

 DoIt();

}

void ShowIt()
{

  cout << "Calc: ";
  cout << Odd/2-1;
  cout << " PI: ";
  cout << setprecision(pre) << Pi;
  cout << "\n";


}

void SaveIt()
{


 ofstream PiC ("Pi.txt");
 PiC << setprecision(pre) << Pi;
 PiC.close();


 ofstream ODDC ("Odd.txt");
 ODDC << Odd;
 ODDC.close();


 ofstream CalcC ("Calc.txt");
 CalcC << setprecision(pre) << Calc;
 CalcC.close();

}
0
 
LVL 13

Accepted Solution

by:
SteH earned 60 total points
ID: 9729349
If you arre referring to my answer:

long double      is a 80 bit floating point number

double is a 64 bit float,
and
float is 32 bit float.

In your above example you mix new and old style STL headers:
#include <iostream.h> // old style
#include <fstream.h>   // old style
#include <iomanip>      // new style
This can be dangerous. The preferred way should be only the new style (without the .h)
#include <iostream>
#include <fstream>
#include <iomanip>

0

Featured Post

Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
Introduction This article is the first in a series of articles about the C/C++ Visual Studio Express debugger.  It provides a quick start guide in using the debugger. Part 2 focuses on additional topics in breakpoints.  Lastly, Part 3 focuses on th…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.

786 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question