Solved

# Division Precision

Posted on 2003-11-10
838 Views
Im writing a progarm to calculate PI and my problem is c++ rounds everything in division so i have an endless answer of "3" ive done seprecsision for cout statement and that is fine but i need to fix the division my equation is PI = 4-4/3+4/5-4/7+4/9-4/11+4/13-4/15...

Here is my actual math part of my script:

Cal = 4/Odd;
Odd += 2;
Calc -= Cal;
Cal = 4/Odd;
Odd += 2;
Calc += Cal;
Pi = Calc;

This is in a for loop then it saves and repeats
0
Question by:Deathbob
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points
• 4
• 2
• 2
• +2

LVL 17

Expert Comment

ID: 9719892
C++ treats 4 as an integer.

Write 4.0 to get a division on a double.

e.g.

Cal = 4.0/Odd;

Make sure all of your variebles are doubles for double precision.
0

LVL 5

Assisted Solution

waelothman earned 65 total points
ID: 9719944
dividing integer with integer always give an integer value so you have to do 1 of 3 ways

as rstaveley say make any number of them float

or write it
cal = (float) 4/Odd
0

LVL 1

Author Comment

ID: 9720376
As i counted i think i can get 52 decimal places give or take, but can i get more?
0

LVL 1

Author Comment

ID: 9720379
THANKS FOR YOUR HELP BY THE WAY, BUT IM GONNA TRY AND PUSH IT TO THE MAX
0

LVL 13

Expert Comment

ID: 9720762
Yes,
1) go to extended instead of double. This increases the number of bits used for the mantissa.

Then you have the problem that the mantissa is limited and the value won't change the exponent of the number 3.1415e0: At some place the number calc + 4/2n+1 can't be distinguished from calc + 4/2n+1 - 4/2n+3 with the chosen precision of your var.  To reach a higher precision you have to remove the leading. Now it helps to remove some known digits of pi and so changing the exponent of it. Thereby you increase the available bits for the mantissa to distinguish these numbers.
0

LVL 32

Expert Comment

ID: 9721385
>>BUT IM GONNA TRY AND PUSH IT TO THE MAX

I hate to be the bearer of bad news here but you're not going to live long enough to push this to the max.  PI is a transcendental irrational number and has an infinite number of digits.  Using computers PI has been calculated to many millions of digits but you're unlikely to even approach that using your methods.
0

LVL 1

Author Comment

ID: 9723665
Its for fun and becides just the thought of haveing a program that can attempt this is nice (sence of acomplishment).
0

LVL 32

Expert Comment

ID: 9723706
Well take at look at this:

http://projectpi.sourceforge.net/

If you're going to try and accomplish something, at least use a technique that is potentially usefule.
0

LVL 1

Author Comment

ID: 9723729
how do you define an extended variable?

Here is my script

//Pi Calculation Software Alpha

//START ODD VALUE : 3
//START CALC VALUE : 4
//:Placed in files:

#include <iostream.h>
#include <fstream.h>
#include <stdlib.h>
#include <math.h>
#include <iomanip>

char Buffer[100];
int Odd;
int Oddc;
double Cal;
double Calc;
double Pi;
int i;
int pre = 52;

void DoIt();
void ShowIt();
void SaveIt();

void main ()
{
system("pause");
DoIt();
}

{
ifstream ODDB ("Odd.txt");
ODDB.getline(Buffer,100);
Odd = atoi(Buffer);
ODDB.close();

ifstream CalcB ("Calc.txt");
CalcB.getline(Buffer,100);
Calc = atof(Buffer);
CalcB.close();

}

void DoIt()
{
//Calculates and saves every 10000 calculations
for (i = 0; i <= 5000; i++)
{
Cal = (float) 4/Odd;
Odd += 2;
Calc -= Cal;
Cal = (float) 4/Odd;
Odd += 2;
Calc += Cal;
Pi = Calc;
ShowIt();

}

SaveIt();

DoIt();

}

void ShowIt()
{

cout << "Calc: ";
cout << Odd/2-1;
cout << " PI: ";
cout << setprecision(pre) << Pi;
cout << "\n";

}

void SaveIt()
{

ofstream PiC ("Pi.txt");
PiC << setprecision(pre) << Pi;
PiC.close();

ofstream ODDC ("Odd.txt");
ODDC << Odd;
ODDC.close();

ofstream CalcC ("Calc.txt");
CalcC << setprecision(pre) << Calc;
CalcC.close();

}
0

LVL 13

Accepted Solution

SteH earned 60 total points
ID: 9729349
If you arre referring to my answer:

long double      is a 80 bit floating point number

double is a 64 bit float,
and
float is 32 bit float.

In your above example you mix new and old style STL headers:
#include <iostream.h> // old style
#include <fstream.h>   // old style
#include <iomanip>      // new style
This can be dangerous. The preferred way should be only the new style (without the .h)
#include <iostream>
#include <fstream>
#include <iomanip>

0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

### Suggested Solutions

Excel/Word Add-in in what language? 5 163
Microsoft C++ code failing in executable that worked 9 144
What is sub-make ? 2 106
No module found pypyodbc, 3 57
Introduction This article is the first in a series of articles about the C/C++ Visual Studio Express debugger.  It provides a quick start guide in using the debugger. Part 2 focuses on additional topics in breakpoints.  Lastly, Part 3 focuses on thā¦
What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. ā¦
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.
###### Suggested Courses
Course of the Month5 days, 7 hours left to enroll