Email Form contents - cgi/perl - giving errors

Hello experts....

I am a total newbie to cgi/perl programming. A friend wanted to email the contents of a feedback form to his email address. The server is Apache cgi server.

I found help with the code I needed on EE, and I customised to my needs. I wrote the code in perl and saved the file as .cgi

The code for email.cgi is:
---------------
#!/usr/bin/perl
# mailform.cgi - email form contents to webmaster

# define a variable that accepts a value from the form
$in;

# assign values to the variable depending on form METHOD
if ($ENV{'REQUEST_METHOD'} eq "GET")
{
$in = $ENV{'QUERY_STRING'};
}
else {
$in = <STDIN>;
}

# fix URL-encoded strings
$in =~ s/\+/ /g;

# all variables are passed to the script as name-value pairs separated by &
# split the input string on the basis of &
@detail = split (/&/, $in);

# open mail pipe

open (MAIL,"|/usr/lib/sendmail -t") || &ErrorMessage;
print MAIL "To: myname@domain.com\n";
print MAIL "From: Feedback Form Mailer\n";
print MAIL "Subject: Feedback on your site\n\n";
print MAIL "Here is the result of your feedback form.\n\n";

foreach $details(@detail)
{
    %details = split (/=/, $details);
    while (($name, $value) = each %details)
    {
print MAIL "$name: $value\n";
    }
}

close MAIL;

print "Content-Type: text/html\n\n";
print "<center><font face=Arial size=+1>Thank you for your
feedback!</font></center>";

sub ErrorMessage{
      print "There is a problem with ther server "
}

---------------

Just to make sure, I wanted to confirm that:
1. We found the cgi-bin in /apache folder. That's where i store my email.cgi right?
2. When we hit submit on the form, we got an internal server error. The error log file showed the following:
[Sun Nov  9 10:19:08 2003] [error] (7)Arg list too long: exec of
/usr/local/apache/cgi-bin/emailform.cgi failed
[Sun Nov  9 10:19:08 2003] [error] [client 141.155.142.47] Premature
end of script headers: /usr/local/apache/cgi-bin/emailform.cgi

I then tried running a simple hello world program as:
#!/usr/bin/perl

print "Content-type: text/html\n\n";
print "<B>All is ok</B>\n";

But again i got an error as:
141.155.142.47 - - [09/Nov/2003:11:12:34 -0500] "GET /cgi-bin/test.cgi
HTTP/1.1" 500 617

I would appreciate if someone could help me with this.... a hello world program not running is frustrating!

Thanx...
poshlivinAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

djplaistowCommented:
1. Yes, Apache appears to have found the script just fine, so you have it in the right place.
2. The "Premature end of script headers" error in these situations is normally due to something being printed to STDOUT before the Content-type line or a missing blank line after the Content-type line. However, in both your examples it appears to be correct. Then I would guess that there is an error message being printed to STDOUT before the Content-type line. Run the scripts from the command line and see if there are any error messages. Post your findings.
0
poshlivinAuthor Commented:
I also have a cgi-bin folder in /usr/local/bin - do I need to store my files there?

Also, would adding
$|++;
use CGI::Carp qw( fatalsToBrowser );
open( STDERR, ">&STDOUT" );
 
after #!/usr/bin/perl line help?

I don't have access to ther server, but I am going to ask the admin to run the script from the command prompt and post the findings here.
0
djplaistowCommented:
Where you put the CGI scripts depends on how Apache is configured. The configuration file is most likely called httpd.conf but could be something different. You should see a line in there that looks about like

     ScriptAlias /cgi-bin/ "/usr/local/apache/cgi-bin/"

The second argument to the ScripAlias directive is where you put your CGI scripts. However, the error message that you posted does not say that it couldn't find the script, it says that it had a problem executing it. Thus, I am sure it found it. Rename or move the script so Apache can't find it and try the URL again. You should notice the error message changed.

Yes CGI::Crap might help you. You may also try the following after the shebang line:

$SIG{__DIE__} = \&Error_Msg;

sub Error_Msg
{
  $msg = "@_";
  print "Content-type: text/html\n\n";
  print "The following error occurred : $msg\n";
  exit;
}

Also, try making the Content-type line the very first line after the shebang line.

It may not matter that you don't have access to the server, try and execute them on your local box, and see if there is some obvious error. If you don't get an error than let the admin run them for you.

Also, get rid of the code that is attempting to get the form variables and replace it with:

    use CGI qw(:cgi-lib);
    ReadParse();

After these 2 lines of code have finished, you will have all the form variables stored in the hash name %in. They can be accessed like:

    my $varValue = $in{"variableName"};
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Cloud Class® Course: Certified Penetration Testing

This CPTE Certified Penetration Testing Engineer course covers everything you need to know about becoming a Certified Penetration Testing Engineer. Career Path: Professional roles include Ethical Hackers, Security Consultants, System Administrators, and Chief Security Officers.

poshlivinAuthor Commented:
Thanx djplaistow.

I put the error message line after the shebang line and the error did get solved (it had to do with line breaks - nothing that we anticipated). Apparently, the admin had to put special line breaks since he was using Unix on a  Mac.

Anyways, when we tried executing the script, we did get a "thank you for your feedback" message which implied there were no errors. Also, the log file didn't show any error logs. But it's been almost 24 hours and we haven't received the mail as yet.

Right now I set it as:
print MAIL "To: myname\@domain.com; colleague1\@domain.com\n";

1 Do you think the order of the To, From, etc matters?
2 Also, should the From line necessarily contain an email address in it?
3 Sendmail should normally work right? Since I didn't change the $in = <STDIN> line, would that have mattered?

Thanx again.
0
poshlivinAuthor Commented:
Sendmail is still not giving any errors and not sending any mails either.
Any ideas?
0
poshlivinAuthor Commented:
I substitued the <STDIN> with the following code
use CGI;

$form = new CGI;

my $issue          = $form->param('Issue')     || die "no Issue supplied:$! ";
(continue for all fields in form)

Now I get
nobody.....Recipient names must be specified >html>
and then
Thank you for your feedback

But no mail is sent out.
0
poshlivinAuthor Commented:
djplaistow
You told me to replace the line that attempts to read the form variables with
 use CGI qw(:cgi-lib);
    ReadParse();

Since I am totally new to perl,which lines should I exactly change and where do i put the code?
 use CGI qw(:cgi-lib);
    ReadParse();

Do I have to assign %in = ReadParse()
0
million1977Commented:
I have a similar problem-
see http://www.experts-exchange.com/Web/Web_Languages/CGI/Q_20821196.html

Maybe answers given on my page will help you.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Scripting Languages

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.