kabix
asked on
Problems with random() function
FindFilesAll function returns the list of fils in TStringList. When i use random function in on form create it generates the same number all the time when program starts. It also returns the same file all the time. How can i fix this? Any ideas?
On form create:
TStringList *lResults = new TStringList;
FindFilesAll("D:\\Document
Randomize;
int ii = random(lResults->Count);
AnsiString FileName = lResults->Strings[ii];
ShowMessage(FileName);
On form create:
TStringList *lResults = new TStringList;
FindFilesAll("D:\\Document
Randomize;
int ii = random(lResults->Count);
AnsiString FileName = lResults->Strings[ii];
ShowMessage(FileName);
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Maybe I'm missing something important, but I thought C++ did random numbers a little differently. First of all, the problem you're describing sounds like a seed problem. Random number generators aren't random, they're algorithmic and start with a seed value (usually the current time). Each seed value should give a seemingly "random" number, but the same seed value will give the same random number each time.
Now, when I do random numbers in C++, I usually use the following:
srand(unsigned int seed); // this function seeds the random number generator
// you only need to seed the generator once.
int rand(); // this function generates a random number between 0 and RAND_MAX
Anyway, you might already know all this, but if you don't, then it might help. Good luck!
Now, when I do random numbers in C++, I usually use the following:
srand(unsigned int seed); // this function seeds the random number generator
// you only need to seed the generator once.
int rand(); // this function generates a random number between 0 and RAND_MAX
Anyway, you might already know all this, but if you don't, then it might help. Good luck!
random() will create the same series of random numbers on each execution
unless you seed the random number generator with a different seed each time.
I usually seed the random number generator with the current time:
srandom(time(NULL));
...
long num = random();
BTW, Kashra's example uses rand(), which is discouraged. random() supercedes rand()
using a much better random number generator.
NAME
rand, srand, sranddev, rand_r - bad random number generator
....
DESCRIPTION
These interfaces are obsoleted by random(3).
NAME
random, srandom, srandomdev, initstate, setstate - better random number
generator; routines for changing generators
LIBRARY
Standard C Library (libc, -lc)
SYNOPSIS
#include <stdlib.h>
....
unless you seed the random number generator with a different seed each time.
I usually seed the random number generator with the current time:
srandom(time(NULL));
...
long num = random();
BTW, Kashra's example uses rand(), which is discouraged. random() supercedes rand()
using a much better random number generator.
NAME
rand, srand, sranddev, rand_r - bad random number generator
....
DESCRIPTION
These interfaces are obsoleted by random(3).
NAME
random, srandom, srandomdev, initstate, setstate - better random number
generator; routines for changing generators
LIBRARY
Standard C Library (libc, -lc)
SYNOPSIS
#include <stdlib.h>
....
While I'm no expert on ANSI standards, I'm pretty sure random() and srandom() are not a part of the standard library. They certainly don't exist in any standard reference I have. They might exist on some platforms, or they might have been added recently.
They also don't exist in Visual C++ .NET. While I know that its not the most standards compliant compiler, it comes pretty close these days. I'd be happy to be corrected if I'm wrong.
I'd find it surprising if the functions that are replacing rand and srand don't behave similarly. rand() only needs to be seeded once.
They also don't exist in Visual C++ .NET. While I know that its not the most standards compliant compiler, it comes pretty close these days. I'd be happy to be corrected if I'm wrong.
I'd find it surprising if the functions that are replacing rand and srand don't behave similarly. rand() only needs to be seeded once.
Guys,
He is obviously using some other library. TStringList, AnsiString, and ShowMessage aren't part of the standard library, either.
The problem is like I said before...
> This is not a proper C++ function call. It should be:
Randomize();
Without the parens, the compiler is ignoring this function call (I'd be surprised if you didn't at least get a warning), which is causing the random number generator to not be seeded properly, which is causing the same "random" value to come up each time.
Dex*
He is obviously using some other library. TStringList, AnsiString, and ShowMessage aren't part of the standard library, either.
The problem is like I said before...
> This is not a proper C++ function call. It should be:
Randomize();
Without the parens, the compiler is ignoring this function call (I'd be surprised if you didn't at least get a warning), which is causing the random number generator to not be seeded properly, which is causing the same "random" value to come up each time.
Dex*
TStringList, AnsiString,ShowMessage are in Borland C++ Builder... in whiich case i believe you call:
randomize();
at least it works for me ;)
randomize();
at least it works for me ;)
No comment has been added lately, so it's time to clean up this TA.
I will leave the following recommendation for this question in the Cleanup topic area:
Accept: brettmjohnson {http:#9736977}
Please leave any comments here within the next seven days.
PLEASE DO NOT ACCEPT THIS COMMENT AS AN ANSWER!
Tinchos
EE Cleanup Volunteer
I will leave the following recommendation for this question in the Cleanup topic area:
Accept: brettmjohnson {http:#9736977}
Please leave any comments here within the next seven days.
PLEASE DO NOT ACCEPT THIS COMMENT AS AN ANSWER!
Tinchos
EE Cleanup Volunteer
> Randomize;
This is not a proper C++ function call. It should be:
Randomize();
Hope that helps,
Dex*