• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 247
  • Last Modified:

insertion into linked list

I wanted to insert a value to a linked list in ascending order. But when i insert 5,10,2 - it will print out 5,2,10. When i try 4,3,8 - its correct! Pls correct my mistakes below.

void insert(nodePtr &head, value val)
{
      nodePtr newNode = new node;
      newNode->num = val;
      newNode->next = NULL;

      if(head == NULL)
            head = newNode;

      else if(head->next == NULL)
      {
            if(head->num > val)
            {
                  newNode->next = head;
                  head = newNode;
            }
      }
      else
      {
            nodePtr search = head;
            nodePtr temp;

            while(search != NULL)
            {
                  if(search->next == NULL)
                  {
                  search->next = newNode;
                        break;
                  }

                  if(search->next->num > val)
                  {
            temp = search->next;
                  search->next = newNode;
                  newNode->next = temp;
                        break;
                  }

                  search = search->next;
            }

      }
}
0
Rebecca2003
Asked:
Rebecca2003
1 Solution
 
sbooth17Commented:
Try this, untested code, I think it should work.

nodePtr newNode = new node;
newNode->num = val;
newNode->next = NULL;

if(head == NULL)
    head = newNode;
else
{
     nodePtr search = head;
     nodePtr temp;
 
  //check the first value  
  if(val < search->num)
  {
     //goes before head
     newNode->next = search;
     head = newNode;
     return;
  }
 
  while(true)
  {
    if(search->next == NULL)
    {
      search->next = newNode;
      break;
    }
    if(val < search->next->num)
    {
       temp = search;
       search->next = newNode;
       newNode->next = temp;
      break;
    }
    search = search->next;
  }
}
0
 
itsmeandnobodyelseCommented:
What type is val and num? If that are strings then "10" is less "2" because comparision works lexicographically.
Use type int if i am right.

Regards, Alex
0
 
bcladdCommented:
Rebecca2003:

You should probably keep one question in one posting rather than here and in http://www.experts-exchange.com/Programming/Programming_Languages/Cplusplus/Q_20796480.html

You should go to Community Support and have one of them removed.

-bcl
0
 
tinchosCommented:
No comment has been added lately, so it's time to clean up this TA.
I will leave the following recommendation for this question in the Cleanup topic area:

Accept: sbooth17 {http:#9740825}

Please leave any comments here within the next seven days.
PLEASE DO NOT ACCEPT THIS COMMENT AS AN ANSWER!

Tinchos
EE Cleanup Volunteer
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now