insertion into linked list

I wanted to insert a value to a linked list in ascending order. But when i insert 5,10,2 - it will print out 5,2,10. When i try 4,3,8 - its correct! Pls correct my mistakes below.

void insert(nodePtr &head, value val)
{
      nodePtr newNode = new node;
      newNode->num = val;
      newNode->next = NULL;

      if(head == NULL)
            head = newNode;

      else if(head->next == NULL)
      {
            if(head->num > val)
            {
                  newNode->next = head;
                  head = newNode;
            }
      }
      else
      {
            nodePtr search = head;
            nodePtr temp;

            while(search != NULL)
            {
                  if(search->next == NULL)
                  {
                  search->next = newNode;
                        break;
                  }

                  if(search->next->num > val)
                  {
            temp = search->next;
                  search->next = newNode;
                  newNode->next = temp;
                        break;
                  }

                  search = search->next;
            }

      }
}
Rebecca2003Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

sbooth17Commented:
Try this, untested code, I think it should work.

nodePtr newNode = new node;
newNode->num = val;
newNode->next = NULL;

if(head == NULL)
    head = newNode;
else
{
     nodePtr search = head;
     nodePtr temp;
 
  //check the first value  
  if(val < search->num)
  {
     //goes before head
     newNode->next = search;
     head = newNode;
     return;
  }
 
  while(true)
  {
    if(search->next == NULL)
    {
      search->next = newNode;
      break;
    }
    if(val < search->next->num)
    {
       temp = search;
       search->next = newNode;
       newNode->next = temp;
      break;
    }
    search = search->next;
  }
}
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
itsmeandnobodyelseCommented:
What type is val and num? If that are strings then "10" is less "2" because comparision works lexicographically.
Use type int if i am right.

Regards, Alex
0
bcladdCommented:
Rebecca2003:

You should probably keep one question in one posting rather than here and in http://www.experts-exchange.com/Programming/Programming_Languages/Cplusplus/Q_20796480.html

You should go to Community Support and have one of them removed.

-bcl
0
tinchosCommented:
No comment has been added lately, so it's time to clean up this TA.
I will leave the following recommendation for this question in the Cleanup topic area:

Accept: sbooth17 {http:#9740825}

Please leave any comments here within the next seven days.
PLEASE DO NOT ACCEPT THIS COMMENT AS AN ANSWER!

Tinchos
EE Cleanup Volunteer
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C++

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.