Solved

Image creation via PHP

Posted on 2003-11-24
11
301 Views
Last Modified: 2010-04-17
Hi, I  have recently been working on a script which will create an image via PHP, but seems to have stumbled upon a big error.

My script is..

<?

if($ploc=="Hev") { $im = imagecreatefrompng('Hev.png'); }
else if($ploc=="Sky") { $im = imagecreatefrompng('Sky.png'); }
else if($ploc=="Sur") { $im = imagecreatefrompng('Sur.png'); }
else if($ploc=="Dun") { $im = imagecreatefrompng('Dun.png'); }
else if($ploc=="Hel") { $im = imagecreatefrompng('Hel.png'); }

      $kdc=0;
      $kds=0;

      ?>
            <script language="JavaScript" type="text/javascript">
                  function loc(x,y) { s_Loc.innerHTML="Location: "+x+","+y; }
                  function ut() { s_Loc.innerHTML="<br>"; }
                  function kd(kdnum) { s_KD.innerHTML=kdnum; }
                  function kds(kdnum) { s_KDS.innerHTML=kdnum; }
            </script>
      <?

      echo "Number of kingdoms: <span id=s_KD>".$kdc."</span> || Kingdoms Checked: <span id=s_KDS>".$kds."</span><p><span id=s_Pic>Old :: <br><img src=result.jpeg></span><p>";

$width=300;
$height=300;

$image=imagecreate($width,$height);
$bg=imagecolorallocate($image, 0x00,0x00,0x00);

for ($i=0;$i<300;$i++){
      for ($j=0;$j<300;$j++){
            $start_x = $j;
            $start_y = $i;
            $color=imagecolorat($im, $start_x, $start_y);
            if($color==$colour) {
                  $kdc++;
                  imagesetpixel($image,$start_x,$start_y,$color);
            }
            $kds++;
      }
      echo "<script>kds(\"".number_format($kds)."\");</script>";
      echo "<script>kd(\"".number_format($kdc)."\");</script>";
}

imagejpeg($image,"result.jpeg");
imagedestroy($image);

echo "<p>New :: <br><img src=result.jpeg>";

?>

The imagesetpixel() seems to not be working at all and therefore it prints a fully black image. This shouldn't happen. Can anyone suggest a fix? (based on the above script). Quickest and most efficient answer gets..... ooooohh.... 75 points?

EDIT: Upped to 100
0
Comment
Question by:Vampireofdarkness
  • 5
  • 4
11 Comments
 
LVL 8

Expert Comment

by:_corey_
ID: 9812916
Where is $colour defined?

Have you verified the color value and the fact that imagesetpixel even gets called?
0
 
LVL 9

Author Comment

by:Vampireofdarkness
ID: 9812935
Oh, sorry.
   $colour is a variable from a previous page (appears in /xx.php?colour=xx)
   $ploc is also the same
0
 
LVL 9

Author Comment

by:Vampireofdarkness
ID: 9812941
and imagesetpixel does get called as it shows that there are 10,144 color matches
0
Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
LVL 9

Author Comment

by:Vampireofdarkness
ID: 9813539
Found a solution for myself... now to close this....

Thanks for your help anyway
0
 
LVL 8

Expert Comment

by:_corey_
ID: 9813874
I believe posting on the CS area will get it removed for you.

Was it a bad setting of $colour or something else?
0
 
LVL 9

Author Comment

by:Vampireofdarkness
ID: 9813901
All I needed to do was define $colour before the loop with

$black=imagecolorallocate($image, 0x00,0x00,0x00);

for a black colour, etc..etc.. then use those colours.
0
 
LVL 8

Expert Comment

by:_corey_
ID: 9813935
Ah, so $colour was simply being defined in the loop and constantly matching up with the value of black?
0
 
LVL 9

Author Comment

by:Vampireofdarkness
ID: 9813948
$colour wasn't being defined, for some reason although it should have been. Which is why it posted black.
0
 
LVL 8

Expert Comment

by:_corey_
ID: 9814000
That's what I had suspected when I saw it wasn't defined.  It was being defined with a default nothing value and so then black always matched with it.
0
 
LVL 1

Accepted Solution

by:
Computer101 earned 0 total points
ID: 9831768
PAQed, with points refunded (100)

Computer101
E-E Admin
0

Featured Post

Active Directory Webinar

We all know we need to protect and secure our privileges, but where to start? Join Experts Exchange and ManageEngine on Tuesday, April 11, 2017 10:00 AM PDT to learn how to track and secure privileged users in Active Directory.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article will show, step by step, how to integrate R code into a R Sweave document
Although it can be difficult to imagine, someday your child will have a career of his or her own. He or she will likely start a family, buy a home and start having their own children. So, while being a kid is still extremely important, it’s also …

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question