[2 days left] What’s wrong with your cloud strategy? Learn why multicloud solutions matter with Nimble Storage.Register Now

x
Solved

# Can you improve it

Posted on 2003-11-26
Medium Priority
295 Views
hi,
I make a programme but I keep the feeling that it is not good. How you will make it:

You have a massive P[10][3] contains ten triangles(its sides):
side a=P[1][1], side b=P[1][2], side c=P[1][3]. Find whitch have max surface, and whitch have min surface.
You need to try if inpud numbers can be sides of triangle.

#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p;
float S_max=0,S_min=1000,S_t;
int min, max;
for(int i=0;i<10;i++)
{

a=trian[i][1];
b=trian[i][2];
c=trian[i][3];

if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
{
p=(a+b+c)/2;
S_t=sqrt(p*(p-a)*(p-b)*(p-c));

if(min>S_t) {

S_min=S_t;
min=i;
}

else if(max<S_t) {
S_max=S_t;
max=i;
}
}
}
0
Question by:sisqu
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points

LVL 4

Expert Comment

ID: 9824006
Hi

One error noticed instantly is

a=trian[i][1];
b=trian[i][2];
c=trian[i][3];

should be

a=trian[i][0];
b=trian[i][1];
c=trian[i][2];

Dhyanesh
0

LVL 4

Expert Comment

ID: 9824041
Hi

Few more errors. First of all initializing S_min to 1000 is an error. You could have the min surface area  triangle greater than 1000. You should increase this value to the maximum possible value. Another alternative is to assume the area of first triangle i.e. trian[0] as min and then continue comparing with others as you have done.

Also following lines have errors:

if(min>S_t) {                                         //should be    S_min>S_t

S_min=S_t;
min=i;
}

else if(max<S_t) {                        //should be  S_max<S_t
S_max=S_t;
max=i;
}

Dhyanesh
0

LVL 2

Expert Comment

ID: 9824829
Since you just want to find which triangle has min/max surface, you need not calculate the sqrt of the product. However, we need be careful here if there is overflow problem.
0

LVL 4

Assisted Solution

dhyanesh earned 1000 total points
ID: 9825144
Hi

You need not have an else after the if

if(min>S_t) {                                         //should be    S_min>S_t

S_min=S_t;
min=i;
}

if(max<S_t) {                        //should be  S_max<S_t
S_max=S_t;
max=i;
}

If an 'else' statement is put then first element will be set as minimum only. However first element is max as well as min

Dhyanesh
0

LVL 45

Accepted Solution

sunnycoder earned 1000 total points
ID: 9825304
#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p,i;
float S_max=0,S_min=FLOAT_MAX,S_t;       //most compilers define constants for maximum value that a data type can hold ...
// check the header files stdlib or types.h
int min=-1, max=-1;

for(int i=0;i<10;i++)  //you had not declared i
{

a=trian[i][0];
b=trian[i][1];
c=trian[i][2];

if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
{
p=(a+b+c);                                    //you can get the result without the division
S_t=(p*(p-a)*(p-b)*(p-c));              // and ofcourse without the sqrt

if(S_min>S_t) {

S_min=S_t;
min=i;
}

if( max < S_t) {
S_max=S_t;
max=i;
}
}
}
0

Author Comment

ID: 9829239
Thank you all (dhyanesh, htang_us and sunnycoder)
for professional look, you give me good ideas. I cant deside who give the points and divide it to both.
0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Summary: This tutorial covers some basics of pointer, pointer arithmetic and function pointer. What is a pointer: A pointer is a variable which holds an address. This address might be address of another variable/address of devices/address of fu…
Windows programmers of the C/C++ variety, how many of you realise that since Window 9x Microsoft has been lying to you about what constitutes Unicode (http://en.wikipedia.org/wiki/Unicode)? They will have you believe that Unicode requires you to use…
The goal of this video is to provide viewers with basic examples to understand and use while-loops in the C programming language.
The goal of this video is to provide viewers with basic examples to understand and use switch statements in the C programming language.
###### Suggested Courses
Course of the Month15 days, left to enroll