• C

Can you improve it

hi,
I make a programme but I keep the feeling that it is not good. How you will make it:

You have a massive P[10][3] contains ten triangles(its sides):
side a=P[1][1], side b=P[1][2], side c=P[1][3]. Find whitch have max surface, and whitch have min surface.
You need to try if inpud numbers can be sides of triangle.

#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p;
float S_max=0,S_min=1000,S_t;
int min, max;
      for(int i=0;i<10;i++)
      {
            
            a=trian[i][1];
            b=trian[i][2];
            c=trian[i][3];

                  if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
                  {
                        p=(a+b+c)/2;
                        S_t=sqrt(p*(p-a)*(p-b)*(p-c));

                              if(min>S_t) {
                                    
                                    S_min=S_t;
                                    min=i;
                              }

                              else if(max<S_t) {
                                    S_max=S_t;
                                    max=i;
                              }
      }
}
sisquAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

dhyaneshCommented:
Hi

One error noticed instantly is

          a=trian[i][1];
         b=trian[i][2];
         c=trian[i][3];

should be


          a=trian[i][0];
         b=trian[i][1];
         c=trian[i][2];

Dhyanesh
0
dhyaneshCommented:
Hi

Few more errors. First of all initializing S_min to 1000 is an error. You could have the min surface area  triangle greater than 1000. You should increase this value to the maximum possible value. Another alternative is to assume the area of first triangle i.e. trian[0] as min and then continue comparing with others as you have done.


Also following lines have errors:

           if(min>S_t) {                                         //should be    S_min>S_t
                             
                             S_min=S_t;
                             min=i;
                        }

                        else if(max<S_t) {                        //should be  S_max<S_t
                             S_max=S_t;
                             max=i;
                        }

Dhyanesh
0
htang_usCommented:
Since you just want to find which triangle has min/max surface, you need not calculate the sqrt of the product. However, we need be careful here if there is overflow problem.
0
Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

dhyaneshCommented:
Hi

You need not have an else after the if

       if(min>S_t) {                                         //should be    S_min>S_t
                           
                             S_min=S_t;
                            min=i;
                       }

                       if(max<S_t) {                        //should be  S_max<S_t
                            S_max=S_t;
                            max=i;
                       }

If an 'else' statement is put then first element will be set as minimum only. However first element is max as well as min

Dhyanesh
0
sunnycoderCommented:
#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p,i;
float S_max=0,S_min=FLOAT_MAX,S_t;       //most compilers define constants for maximum value that a data type can hold ...
                                                                  // check the header files stdlib or types.h
int min=-1, max=-1;    

    for(int i=0;i<10;i++)  //you had not declared i
     {
         
          a=trian[i][0];
         b=trian[i][1];
         c=trian[i][2];

              if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
              {
                   p=(a+b+c);                                    //you can get the result without the division
                   S_t=(p*(p-a)*(p-b)*(p-c));              // and ofcourse without the sqrt

                        if(S_min>S_t) {
                             
                             S_min=S_t;
                             min=i;
                        }

                         if( max < S_t) {
                             S_max=S_t;
                             max=i;
                        }
    }
}
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
sisquAuthor Commented:
Thank you all (dhyanesh, htang_us and sunnycoder)
 for professional look, you give me good ideas. I cant deside who give the points and divide it to both.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.