Solved

Can you improve it

Posted on 2003-11-26
6
236 Views
Last Modified: 2010-04-15
hi,
I make a programme but I keep the feeling that it is not good. How you will make it:

You have a massive P[10][3] contains ten triangles(its sides):
side a=P[1][1], side b=P[1][2], side c=P[1][3]. Find whitch have max surface, and whitch have min surface.
You need to try if inpud numbers can be sides of triangle.

#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p;
float S_max=0,S_min=1000,S_t;
int min, max;
      for(int i=0;i<10;i++)
      {
            
            a=trian[i][1];
            b=trian[i][2];
            c=trian[i][3];

                  if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
                  {
                        p=(a+b+c)/2;
                        S_t=sqrt(p*(p-a)*(p-b)*(p-c));

                              if(min>S_t) {
                                    
                                    S_min=S_t;
                                    min=i;
                              }

                              else if(max<S_t) {
                                    S_max=S_t;
                                    max=i;
                              }
      }
}
0
Comment
Question by:sisqu
6 Comments
 
LVL 4

Expert Comment

by:dhyanesh
Comment Utility
Hi

One error noticed instantly is

          a=trian[i][1];
         b=trian[i][2];
         c=trian[i][3];

should be


          a=trian[i][0];
         b=trian[i][1];
         c=trian[i][2];

Dhyanesh
0
 
LVL 4

Expert Comment

by:dhyanesh
Comment Utility
Hi

Few more errors. First of all initializing S_min to 1000 is an error. You could have the min surface area  triangle greater than 1000. You should increase this value to the maximum possible value. Another alternative is to assume the area of first triangle i.e. trian[0] as min and then continue comparing with others as you have done.


Also following lines have errors:

           if(min>S_t) {                                         //should be    S_min>S_t
                             
                             S_min=S_t;
                             min=i;
                        }

                        else if(max<S_t) {                        //should be  S_max<S_t
                             S_max=S_t;
                             max=i;
                        }

Dhyanesh
0
 
LVL 2

Expert Comment

by:htang_us
Comment Utility
Since you just want to find which triangle has min/max surface, you need not calculate the sqrt of the product. However, we need be careful here if there is overflow problem.
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 4

Assisted Solution

by:dhyanesh
dhyanesh earned 250 total points
Comment Utility
Hi

You need not have an else after the if

       if(min>S_t) {                                         //should be    S_min>S_t
                           
                             S_min=S_t;
                            min=i;
                       }

                       if(max<S_t) {                        //should be  S_max<S_t
                            S_max=S_t;
                            max=i;
                       }

If an 'else' statement is put then first element will be set as minimum only. However first element is max as well as min

Dhyanesh
0
 
LVL 45

Accepted Solution

by:
sunnycoder earned 250 total points
Comment Utility
#include <stdio.h>
#include <math.h>

int main(void) {

float trian[10][3];
float a,b,c,p,i;
float S_max=0,S_min=FLOAT_MAX,S_t;       //most compilers define constants for maximum value that a data type can hold ...
                                                                  // check the header files stdlib or types.h
int min=-1, max=-1;    

    for(int i=0;i<10;i++)  //you had not declared i
     {
         
          a=trian[i][0];
         b=trian[i][1];
         c=trian[i][2];

              if((a+b)>c && (b+c)>a && (c+a)>b) // can be sides of triangle
              {
                   p=(a+b+c);                                    //you can get the result without the division
                   S_t=(p*(p-a)*(p-b)*(p-c));              // and ofcourse without the sqrt

                        if(S_min>S_t) {
                             
                             S_min=S_t;
                             min=i;
                        }

                         if( max < S_t) {
                             S_max=S_t;
                             max=i;
                        }
    }
}
0
 

Author Comment

by:sisqu
Comment Utility
Thank you all (dhyanesh, htang_us and sunnycoder)
 for professional look, you give me good ideas. I cant deside who give the points and divide it to both.
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

An Outlet in Cocoa is a persistent reference to a GUI control; it connects a property (a variable) to a control.  For example, it is common to create an Outlet for the text field GUI control and change the text that appears in this field via that Ou…
This tutorial is posted by Aaron Wojnowski, administrator at SDKExpert.net.  To view more iPhone tutorials, visit www.sdkexpert.net. This is a very simple tutorial on finding the user's current location easily. In this tutorial, you will learn ho…
The goal of this video is to provide viewers with basic examples to understand and use pointers in the C programming language.
The goal of this video is to provide viewers with basic examples to understand recursion in the C programming language.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now