portscanner, works slow in windows

I suspect that it is related to SendMessage/UpdateWindow and the fact that your message pump isn't pumped. Is it faster if you use PostMessage instead of SendMessage and finish up with a PostMessage to update the window? Sorry, I'm not much of a Windows programmer... this is pure guess-work!

> finish up with a PostMessage to update the window

i.e. don't call UpdateWindow(ListOfOpenPorts) locally, but do that in a message handler

its nothing to do with UpdateWindow/SendMessage ... etc.. its a problem in winsock. Even if i rewrite the code as below..its equally slow
---------------------------------------------------------------------------
#include <stdio.h>
#include <winsock2.h>

void main()
{
      WSADATA wsad;
      WSAStartup(MAKEWORD(2,0),&wsad);

      struct sockaddr_in thePC;
      memset(&thePC,0,sizeof(thePC));
      thePC.sin_family=AF_INET;
      thePC.sin_addr.S_un.S_addr=inet_addr("10.108.7.52");

      unsigned int theP;
      char thePort[8];
      for (theP=20;theP<=30;theP++)
      {
            SOCKET SockFDS = socket(AF_INET,SOCK_STREAM,0);
            thePC.sin_port=htons(theP);
            int n = connect(SockFDS,(sockaddr*)&thePC,sizeof(thePC));
            if (n>=0)
            {
                   itoa(theP,thePort,10);
                  printf("%s\n",thePort);
            }
                 closesocket(SockFDS);
      }

      WSACleanup();
}
------------------------------------------------------

I've just tried this myself, and it looks like the Berkley sockets implementation in Winsock doesn't detect connect failure quickly as you surmised. Sorry for the bum steer.

You get good results, if you make sockets non-blocking for the connect and select looking for exceptions or writable descriptors:
--------8<--------
#include <iostream>
#include <winsock2.h>

bool missing_result(bool [],int);

int main()
{
      WSADATA wsad;
      WSAStartup(MAKEWORD(2,0),&wsad);

      struct sockaddr_in addr;
      memset(&addr,0,sizeof(addr));
      addr.sin_family = AF_INET;
      addr.sin_addr.s_addr = inet_addr("10.108.7.52");

      const unsigned short first_port = 20;
      const int ports = 10;
      SOCKET sock[ports];
      bool result[ports];
      bool listening[ports];
      unsigned long now_nonblocking = 1;

      for (int i = 0;i < ports;i++) {
            sock[i] = socket(AF_INET,SOCK_STREAM,0);
            ioctlsocket(sock[i],FIONBIO,&now_nonblocking); // Make it a non-blocking
            addr.sin_port=htons(first_port+i);
            if (connect(sock[i],(sockaddr*)&addr,sizeof(addr)) != -1) // Non-blocking connect attempt
                  listening[i] = result[i] = true; // Immediate success is unlikely, but possible
            else
                  result[i] = false; // More likely to have to wait for a result
      }

      while (missing_result(result,ports)) { // While we are waiting for results
            fd_set wdesc,edesc;
            FD_ZERO(&wdesc); // This picks up on connection successes
            FD_ZERO(&edesc); // This picks up on connection failures
            for (int i = 0;i < ports;i++)
                  if (!result[i]) {
                        FD_SET(sock[i],&wdesc);
                        FD_SET(sock[i],&edesc);
                  }
            select(sock[ports-1]+1,(fd_set*)0,&wdesc,&edesc,0);
            for (int i = 0;i < ports;i++)
                  if (FD_ISSET(sock[i],&wdesc)) {
                        listening[i] = result[i] = true;
                        //std::cout << "Listening on port " << first_port+i << '\n';
                  }
                      else if (FD_ISSET(sock[i],&edesc)) {
                        listening[i] = false;
                        result[i] = true;
                        //std::cout << "Not listening on port " << first_port+i << '\n';
                      }
      }
      WSACleanup();

      for (int i = 0;i < ports;i++)
            if (listening[i])
                  std::cout << "Listening on port " << first_port+i << '\n';
}

bool missing_result(bool result[],int ports)
{
      for (int i = 0;i < ports;i++)
            if (result[i] == false)
                  return true;
      return false;
}
--------8<--------

Tabulation was horrible then, I'll post that code again:
--------8<--------
#include <iostream>
#include <winsock2.h>

bool missing_result(bool [],int);

int main()
{
      WSADATA wsad;
      WSAStartup(MAKEWORD(2,0),&wsad);

      struct sockaddr_in addr;
      memset(&addr,0,sizeof(addr));
      addr.sin_family = AF_INET;
      addr.sin_addr.s_addr = inet_addr("192.168.51.87");

      const unsigned short first_port = 20;
      const int ports = 10;
      SOCKET sock[ports];
      bool result[ports];
      bool listening[ports];
      unsigned long now_nonblocking = 1;

      for (int i = 0;i < ports;i++) {
            sock[i] = socket(AF_INET,SOCK_STREAM,0);
            ioctlsocket(sock[i],FIONBIO,&now_nonblocking);
            addr.sin_port=htons(first_port+i);
            if (connect(sock[i],(sockaddr*)&addr,sizeof(addr)) != -1)
                  listening[i] = result[i] = true;
            else
                  result[i] = false;
      }

      while (missing_result(result,ports)) {
            fd_set wdesc,edesc;
            FD_ZERO(&wdesc);
            FD_ZERO(&edesc);
            for (int i = 0;i < ports;i++)
                  if (!result[i]) {
                        FD_SET(sock[i],&wdesc);
                        FD_SET(sock[i],&edesc);
                  }
            select(sock[ports-1]+1,(fd_set*)0,&wdesc,&edesc,0);
            for (int i = 0;i < ports;i++)
                  if (FD_ISSET(sock[i],&wdesc)) {
                        listening[i] = result[i] = true;
                        //std::cout << "Listening on port " << first_port+i << '\n';
                  }
                  else if (FD_ISSET(sock[i],&edesc)) {
                        listening[i] = false;
                        result[i] = true;
                        //std::cout << "Not listening on port " << first_port+i << '\n';
                  }
      }
      WSACleanup();

      for (int i = 0;i < ports;i++)
            if (listening[i])
                  std::cout << "Listening on port " << first_port+i << '\n';
}

bool missing_result(bool result[],int ports)
{
      for (int i = 0;i < ports;i++)
            if (result[i] == false)
                  return true;
      return false;
}
--------8<--------

Sorry I just realised that was C++... do you want a C version or is that OK?

works like a charm !!! :)

one thing .. i thought linux and windows both used berkley sockets .. then how come it works different on both ??

thanks  :)
muskad202

also .. is there any way to set a timeout for a connect ??

The Berkley sockets API was evolved for UNIX. I think Microsoft implemented the Berkley API for Windows on top of its own Winsock API, which is more tightly bound to the Winsock TCP/IP protocol stack. If you want to write relatively portable code, it is best to go with the Berkley API, but if you want to specialise for Windows, you'll probably get better performace if you get into the intestines of Winsock API programming.

If you look at the ConnectEx spiel at http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/winsock/connectex_2.asp?frame=true you'll see that you can use getsockopt with SO_CONNECT_TIME to see if a connection is established and you could abort the connection by doing DisconnectEx. I've not played around with this stuff, but I'm sure you'll find experts on EE who have.