# Simple bytearray comparing question.

byte[] a = new byte[2];
byte[] b = new byte[2];
a[0] = 1;
a[1] = 2;
b[0] = 1;
b[1] = 2;
Console.WriteLine( a == b );
a[0] = 1;
a[1] = 2;
b[0] = 2;
b[1] = 2;
Console.WriteLine( a == b);

How can i effeciently compare if the values in a is equal to b ( in my base, the size of array should be more then 1M) ? I want the result to be true false, instead of false false that i get now.
LVL 5
###### Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Commented:
If you use == on reference type, it will compare the pointer instead of the value inside. That's why you got false in both cases
Commented:
This means that to compare them, you have to compare it byte by byte....

public bool CompareArrays (byte[] first, byte[] second)
{
if (first.Length != second.Length)
return false;
for (int i=0; i < first.Length; i++)
if (first[i] != second[i])
return false;
return true;
}
Commented:
As you will compare huge arrays, consider the following optimization of the code. Note that you must enable unsafe blocks in the project properties.

unsafe public bool CompareArrays (byte[] first, byte[] second)
{
if (first.Length != second.Length)
return false;

fixed (byte* f = first)
fixed (byte *s = second)
{
long* p1 = (long*)f;
long* p2 = (long*)s;

// Compare as much as possible as longs
for (int i = 0; i < first.Length / sizeof (long); i++)
if (p1[i] != p2[i])
return false;

// Compare the rest as bytes
for (int i = 0; i < first.Length % sizeof (long); i++)
if (f[(first.Length / sizeof (long)) * sizeof (long) + i] !=
s[(first.Length / sizeof (long)) * sizeof (long) + i])
return false;

return true;
}
}

An example usage:
private void button1_Click(object sender, System.EventArgs e)
{
byte[] a = new byte[10000];
byte[] b = new byte[10000];

Random r = new Random();

for (int i = 0; i < a.Length; i++)
a[i] = b[i] = (byte)r.Next();

MessageBox.Show (CompareArrays(a, b).ToString());
}

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Author Commented:
Hi TheAvenger

In my understanding, you are trying to convert the byte array into a long array first, then compare each block of the long array 1 by 1. So.. the looping will be 4 times less? So.. it still need to loop..

Is there a method which is similar to the function memcmp in c++?
Commented:
Actually it's 8 times faster, because the long type in C# is 8 bytes, byte is 1 byte.

I don't know about such a method, but this does not mean it does not exist....
Commented:
By the way this loop compares 10 Mb arrays for ~0.5 sec so I think it has a good performance...
###### It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C#

From novice to tech pro — start learning today.