Solved

query and if statement won't work

Posted on 2003-12-05
5
225 Views
Last Modified: 2006-11-17
Ok. I am looping through the numbers 1 - 31. I have a url variable called month. I have a query and statement that should be like.....if date = '12/5' then link number otherwise, don't link number. For example there is a 12/5 in the database and the url month=12, but right now everything is linking. Here is the code, but something isn't right:

$count = 1;
while ($count <=31)
{
     $sql = "SELECT id from oldies_history where date = '$_REQUEST[month]/$count'";
     $ok = @mysql_query($sql);
          if (!@ok)
               {
                    echo("$count&nbsp;&nbsp;");
               }
          else
              {
                   echo( "<a href='edit_history_detail.php?month=$_REQUEST[month&day=$count'>$count</a></li>&nbsp;&nbsp;" );
              }                              
     $count++;
}
0
Comment
Question by:mappenzellar
  • 3
5 Comments
 
LVL 5

Expert Comment

by:arjanh
ID: 9884785
try changing
          if (!@ok)
into
          if (! $ok)
0
 

Author Comment

by:mappenzellar
ID: 9884808
nope caught that, but still no go
0
 
LVL 5

Expert Comment

by:arjanh
ID: 9884824
$ok = @mysql_query($sql);

the '@' is masking all errors I think, so try

$ok = mysql_query($sql);
0
 
LVL 5

Accepted Solution

by:
arjanh earned 50 total points
ID: 9884856
You need to look at the number of records found, not whether or not the query was successful:

$result = @mysql_query($sql);
$num = mysql_num_rows($result);
if ($num == 0)

0
 
LVL 6

Expert Comment

by:aolXFT
ID: 9885048
I believe that when you put arrays directly into strings you have to put braces around them. eg "{$_REQUEST['month']}"

On an aside, you should really put your input through mysql_escape_string(), before sending it to the database.

mysql_query will return a value even if no rows are returned.
If you want to see if a row was returned use mysql_num_rows($result) // where $result is what is returned from mysql_query().

you should be using the if($ok) for error checking, since if it returns false(or 0), you generally have a problem. You shouldn't be using it to check if a row exists, because quite simply that is not how it works.

You also didn't close the square bracket in your altenative option.

I think you are trying to find all the rows with that date, but I'm not quite sure.

I've made a few changes to your code.

$count = 1;
for($count = 1; $count <=31; ++$count) {
     $sql = "SELECT id from oldies_history where date = '{$_REQUEST['month']}/$count'";
     $ok = mysql_query($sql);
     if(!$ok){
        die(sprintf("Query Failed: %s\n", mysql_error());
     }

     $date_exists = mysql_num_rows($ok);
          if (!$date_exists)
               {
                    echo("$count&nbsp;&nbsp;");
               }
          else
              {
                   echo( "<a href='edit_history_detail.php?month={$_REQUEST['month']}&day=$count'>$count</a></li>&nbsp;&nbsp;" );
              }
}
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
php email 2 27
Whether to use true/false, yes/no or 0/1 11 51
MySQL Grouping 2 23
selecting both the price and sum(price ) with mysql statement 5 10
Build an array called $myWeek which will hold the array elements Today, Yesterday and then builds up the rest of the week by the name of the day going back 1 week.   (CODE) (CODE) Then you just need to pass your date to the function. If i…
Nothing in an HTTP request can be trusted, including HTTP headers and form data.  A form token is a tool that can be used to guard against request forgeries (CSRF).  This article shows an improved approach to form tokens, making it more difficult to…
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

896 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now