Solved

query and if statement won't work

Posted on 2003-12-05
5
229 Views
Last Modified: 2006-11-17
Ok. I am looping through the numbers 1 - 31. I have a url variable called month. I have a query and statement that should be like.....if date = '12/5' then link number otherwise, don't link number. For example there is a 12/5 in the database and the url month=12, but right now everything is linking. Here is the code, but something isn't right:

$count = 1;
while ($count <=31)
{
     $sql = "SELECT id from oldies_history where date = '$_REQUEST[month]/$count'";
     $ok = @mysql_query($sql);
          if (!@ok)
               {
                    echo("$count&nbsp;&nbsp;");
               }
          else
              {
                   echo( "<a href='edit_history_detail.php?month=$_REQUEST[month&day=$count'>$count</a></li>&nbsp;&nbsp;" );
              }                              
     $count++;
}
0
Comment
Question by:mappenzellar
  • 3
5 Comments
 
LVL 5

Expert Comment

by:arjanh
ID: 9884785
try changing
          if (!@ok)
into
          if (! $ok)
0
 

Author Comment

by:mappenzellar
ID: 9884808
nope caught that, but still no go
0
 
LVL 5

Expert Comment

by:arjanh
ID: 9884824
$ok = @mysql_query($sql);

the '@' is masking all errors I think, so try

$ok = mysql_query($sql);
0
 
LVL 5

Accepted Solution

by:
arjanh earned 50 total points
ID: 9884856
You need to look at the number of records found, not whether or not the query was successful:

$result = @mysql_query($sql);
$num = mysql_num_rows($result);
if ($num == 0)

0
 
LVL 6

Expert Comment

by:aolXFT
ID: 9885048
I believe that when you put arrays directly into strings you have to put braces around them. eg "{$_REQUEST['month']}"

On an aside, you should really put your input through mysql_escape_string(), before sending it to the database.

mysql_query will return a value even if no rows are returned.
If you want to see if a row was returned use mysql_num_rows($result) // where $result is what is returned from mysql_query().

you should be using the if($ok) for error checking, since if it returns false(or 0), you generally have a problem. You shouldn't be using it to check if a row exists, because quite simply that is not how it works.

You also didn't close the square bracket in your altenative option.

I think you are trying to find all the rows with that date, but I'm not quite sure.

I've made a few changes to your code.

$count = 1;
for($count = 1; $count <=31; ++$count) {
     $sql = "SELECT id from oldies_history where date = '{$_REQUEST['month']}/$count'";
     $ok = mysql_query($sql);
     if(!$ok){
        die(sprintf("Query Failed: %s\n", mysql_error());
     }

     $date_exists = mysql_num_rows($ok);
          if (!$date_exists)
               {
                    echo("$count&nbsp;&nbsp;");
               }
          else
              {
                   echo( "<a href='edit_history_detail.php?month={$_REQUEST['month']}&day=$count'>$count</a></li>&nbsp;&nbsp;" );
              }
}
0

Featured Post

Problems using Powershell and Active Directory?

Managing Active Directory does not always have to be complicated.  If you are spending more time trying instead of doing, then it's time to look at something else. For nearly 20 years, AD admins around the world have used one tool for day-to-day AD management: Hyena. Discover why

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Developers of all skill levels should learn to use current best practices when developing websites. However many developers, new and old, fall into the trap of using deprecated features because this is what so many tutorials and books tell them to u…
This article discusses four methods for overlaying images in a container on a web page
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
The viewer will learn how to dynamically set the form action using jQuery.

831 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question