Solved

operator overloading question

Posted on 2003-12-05
8
281 Views
Last Modified: 2010-04-01
ok, I will poost my code below. I get these two errors:
(54) : error C2601: '>>' : local function definitions are illegal
(54) : fatal error C1903: unable to recover from previous error(s); stopping compilation
Error executing cl.exe.
These errors begin at the open bracket after this line:
ifstream & operator>> (ifstream& stream, employee& p)
I'm not sure what to do. Here is my code:

#include<iostream>
#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};
employee::employee();
int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);

ifstream & operator>> (ifstream& stream, employee& p)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   p.setfname(tmp);

   stream.getline(tmp, 80, '|');
   p.setlname(tmp);

   stream.getline(tmp, 80, '|');
   p.setaddress(tmp);

   stream.getline(tmp, 80, '|');
   p.setcity(tmp);

   stream.getline(tmp, 80, '|');
   p.setstate(tmp);

   stream.getline(tmp, 80, '|');
   p.setzip(tmp);

   stream.getline(tmp, 80, '|');
   p.sethos(tmp);

   stream.getline(tmp, 80, '|');
   p.setpayrate(tmp);

   stream.getline(tmp, 80, '|');
   p.sethours(tmp);

   stream.getline(tmp, 80, '|');
   p.setdependents(tmp);

  return stream;
}
  employee compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}
0
Comment
Question by:dukemarlon
  • 6
  • 2
8 Comments
 
LVL 44

Expert Comment

by:Karl Heinz Kremer
ID: 9886174
Your operator is defined embedded in the main function. I have not comiled it, but this is definitely a problem. Also, the line employee::employee(); is wrong. The definition of your employee class is incomplete: All the methods that you reference in the operator are not defined. Try to correct these problems, and if it's still not working, post a comment.

Try this:

#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};



int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);
  employee compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}

ifstream & operator>> (ifstream& stream, employee& p)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   p.setfname(tmp);

   stream.getline(tmp, 80, '|');
   p.setlname(tmp);

   stream.getline(tmp, 80, '|');
   p.setaddress(tmp);

   stream.getline(tmp, 80, '|');
   p.setcity(tmp);

   stream.getline(tmp, 80, '|');
   p.setstate(tmp);

   stream.getline(tmp, 80, '|');
   p.setzip(tmp);

   stream.getline(tmp, 80, '|');
   p.sethos(tmp);

   stream.getline(tmp, 80, '|');
   p.setpayrate(tmp);

   stream.getline(tmp, 80, '|');
   p.sethours(tmp);

   stream.getline(tmp, 80, '|');
   p.setdependents(tmp);

  return stream;
}
0
 
LVL 44

Expert Comment

by:Karl Heinz Kremer
ID: 9886176
Your operator is defined embedded in the main function. I have not comiled it, but this is definitely a problem. Also, the line employee::employee(); is wrong. The definition of your employee class is incomplete: All the methods that you reference in the operator are not defined. Try to correct these problems, and if it's still not working, post a comment.

Try this:

#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};



int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);
  employee compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}

ifstream & operator>> (ifstream& stream, employee& p)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   p.setfname(tmp);

   stream.getline(tmp, 80, '|');
   p.setlname(tmp);

   stream.getline(tmp, 80, '|');
   p.setaddress(tmp);

   stream.getline(tmp, 80, '|');
   p.setcity(tmp);

   stream.getline(tmp, 80, '|');
   p.setstate(tmp);

   stream.getline(tmp, 80, '|');
   p.setzip(tmp);

   stream.getline(tmp, 80, '|');
   p.sethos(tmp);

   stream.getline(tmp, 80, '|');
   p.setpayrate(tmp);

   stream.getline(tmp, 80, '|');
   p.sethours(tmp);

   stream.getline(tmp, 80, '|');
   p.setdependents(tmp);

  return stream;
}
0
 
LVL 44

Expert Comment

by:Karl Heinz Kremer
ID: 9886177
Your operator is defined embedded in the main function. I have not comiled it, but this is definitely a problem. Also, the line employee::employee(); is wrong. The definition of your employee class is incomplete: All the methods that you reference in the operator are not defined. Try to correct these problems, and if it's still not working, post a comment.

Try this:

#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};



int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);
  employee compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}

ifstream & operator>> (ifstream& stream, employee& p)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   p.setfname(tmp);

   stream.getline(tmp, 80, '|');
   p.setlname(tmp);

   stream.getline(tmp, 80, '|');
   p.setaddress(tmp);

   stream.getline(tmp, 80, '|');
   p.setcity(tmp);

   stream.getline(tmp, 80, '|');
   p.setstate(tmp);

   stream.getline(tmp, 80, '|');
   p.setzip(tmp);

   stream.getline(tmp, 80, '|');
   p.sethos(tmp);

   stream.getline(tmp, 80, '|');
   p.setpayrate(tmp);

   stream.getline(tmp, 80, '|');
   p.sethours(tmp);

   stream.getline(tmp, 80, '|');
   p.setdependents(tmp);

  return stream;
}
0
Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
LVL 44

Expert Comment

by:Karl Heinz Kremer
ID: 9886179
Your operator is defined embedded in the main function. I have not comiled it, but this is definitely a problem. Also, the line employee::employee(); is wrong. The definition of your employee class is incomplete: All the methods that you reference in the operator are not defined. Try to correct these problems, and if it's still not working, post a comment.

Try this:

#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};



int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);
  employee compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}

ifstream & operator>> (ifstream& stream, employee& p)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   p.setfname(tmp);

   stream.getline(tmp, 80, '|');
   p.setlname(tmp);

   stream.getline(tmp, 80, '|');
   p.setaddress(tmp);

   stream.getline(tmp, 80, '|');
   p.setcity(tmp);

   stream.getline(tmp, 80, '|');
   p.setstate(tmp);

   stream.getline(tmp, 80, '|');
   p.setzip(tmp);

   stream.getline(tmp, 80, '|');
   p.sethos(tmp);

   stream.getline(tmp, 80, '|');
   p.setpayrate(tmp);

   stream.getline(tmp, 80, '|');
   p.sethours(tmp);

   stream.getline(tmp, 80, '|');
   p.setdependents(tmp);

  return stream;
}
0
 
LVL 44

Expert Comment

by:Karl Heinz Kremer
ID: 9886277
... so it did work :-) Sorry about that. My browser timed out three times, so I resubmitted the comment a number of times.
0
 

Author Comment

by:dukemarlon
ID: 9886284
it kinda fixed it, but now inside of the overloaded function, can't figure out how to set values to any of the objects, I was barraged with errors, and can't figure most of them out.
0
 

Author Comment

by:dukemarlon
ID: 9886317
here is what I have, but every object in the overloaded function says it is an illeagal reference




#include<iostream>
#include<fstream>
#include<string>
#include<cstdlib>
using namespace std;

class employee
{
public:
  friend ifstream &operator>>(ifstream& stream, employee& p);
  string lname;
  string fname;
  string address;
  string city;
  string state;
  string zip;
  char hos;
  int payrate;
  int hours;
  int dependents;
  int gpay;
  int fed;
  int state1;
  int social;
  int net;
  int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
};
employee employee();







int main()
{
  char in[20];
  char out[20];
  char str[1024], last;
  cout<<"Enter the name of the file you want to write to."<<endl;
  cin.get(out, 20);
  cin.ignore(80, '\n');
  cout<<"Enter the name of the file you want to read from."<<endl;
  cin.get(in, 20);
  cin.ignore(80, '\n');
  ifstream infile;
  infile.open(in);
  ofstream outfile;
  outfile.open(out);

   

  employee::compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos);
  infile.close();
  outfile.close();
  return 0;
}

int compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos)
{
  if(hos=='h'||'H')gpay=hours*payrate*100;
  if(hos=='s'||'S')gpay=payrate/26*100;
  fed=(gpay*26)-(2500*dependents)*(.28/.26)*100;
  state1=gpay*.048*100;
  social=gpay*.075*100;
  return (gpay, fed, state1, social);
}





ifstream & operator>> (ifstream& stream, employee&)
{
   char tmp[80];
 
   stream.getline(tmp, 80, '|');
   employee::fname=tmp;

   stream.getline(tmp, 80, '|');
   employee::lname=tmp;

   stream.getline(tmp, 80, '|');
   employee::address=tmp;

   stream.getline(tmp, 80, '|');
   employee::city=tmp;

   stream.getline(tmp, 80, '|');
   employee::state=tmp;

   stream.getline(tmp, 80, '|');
   employee::zip=tmp;

   stream.getline(tmp, 80, '|');
   employee::hos=tmp;

   stream.getline(tmp, 80, '|');
   employee::payrate=tmp;

   stream.getline(tmp, 80, '|');
   employee::hours=tmp;

   stream.getline(tmp, 80, '|');
   employee::dependents=tmp;

  return stream;
}
0
 
LVL 44

Accepted Solution

by:
Karl Heinz Kremer earned 200 total points
ID: 9886429
The function header of compute has to look like this:

int employee::compute(int payrate, int hours, int dependents, int gpay, int fed, int state1, int social, int net, char hos)
{
  if(hos=='h'||'H')gpay=hours*payrate*100;
  if(hos=='s'||'S')gpay=payrate/26*100;
  fed=(gpay*26)-(2500*dependents)*(.28/.26)*100;
  state1=gpay*.048*100;
  social=gpay*.075*100;
  return (gpay, fed, state1, social);
}

The header of the operator>> should look like this:

ifstream & operator>> (ifstream& stream, employee& e)

Then in the body of the method use e.variable_name instead of employee::variable_name. This syntax only works for static member variables.

Remove the line "employee employee();" right after the class declaration.

In main() define a variable of type employee:

employee myEmployee;

Then call the compute() method like this:
myEmployee.compute(...);

Also, you are not using your operator>>



0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Often, when implementing a feature, you won't know how certain events should be handled at the point where they occur and you'd rather defer to the user of your function or class. For example, a XML parser will extract a tag from the source code, wh…
Written by John Humphreys C++ Threading and the POSIX Library This article will cover the basic information that you need to know in order to make use of the POSIX threading library available for C and C++ on UNIX and most Linux systems.   [s…
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question