Solved

When to Dim variables - before or after 'On Error'

Posted on 2003-12-08
5
286 Views
Last Modified: 2010-05-01
Within a procedure/function or property:  Is it best to Dim variables before or after the 'On Error' statement?

For example:

Public Sub func()
   Dim sBuffer As String

   On Error Goto EH
   :
   :
   Exit Sub
EH:
   :

End Sub

or

Public Sub func()
   On Error Goto EH

   Dim sBuffer As String
   :
   :
   Exit Sub

EH:
   :
End Sub

Thanks.
0
Comment
Question by:halfondj
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
5 Comments
 
LVL 4

Assisted Solution

by:TomLaw1999
TomLaw1999 earned 62 total points
ID: 9898950
Convention seems to be to dim varibles first.
0
 
LVL 4

Assisted Solution

by:learning_t0_pr0gram
learning_t0_pr0gram earned 62 total points
ID: 9899778
I always dim the variables first...
0
 
LVL 86

Assisted Solution

by:Mike Tomlinson
Mike Tomlinson earned 62 total points
ID: 9901054
I always put my On Error at the top since it is only one line and it makes it very clear that Error trapping is occuring within the Function/Sub.
0
 

Accepted Solution

by:
DaPen earned 64 total points
ID: 9901888
There are times when having the "On Error" command running with in your code can prevent errors from being passed properly (ActiveX Controls).  Also, sometimes you have to specifically place an "On Error" to a specific handler around a piece of code while the rest of the sub routine uses a different (generic) handler.  An example of this might be when the generic handler runs it always calls the specific handler code but under particular situations you only need to run the specific handler code.  All this being said, the best place to put an "On Error" statement is before the code that is going to use it.  "DIM" statements are not normally considered executable code and therefore placing an "On Error" before them would be of no use.
0
 

Author Comment

by:halfondj
ID: 9903737
Thanks for all the answers.  Since there doesn't seem to be a wrong answer, I split the points.
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
Since upgrading to Office 2013 or higher installing the Smart Indenter addin will fail. This article will explain how to install it so it will work regardless of the Office version installed.
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question