Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 4215
  • Last Modified:

Loading file to StringBuffer

I am trying to load the entire file to a StringBuffer so that I can do some manipulation like delete. Below are the methods in my java class. I called the openInFiles in deleteProj method and try to loop through the file. I got a Java Null Pointer error. Is there any other way I can load this file into the StringBuffer. I don't know what I am doing wrong. I tried lot of printout and the problem is with the while loop. How do I indicate end of file with readline(). I urgently need help with this. Please help.

  public boolean openInFiles(String INFILE)  // return true if files open, else false
  {
    // open the source
    try
    {
      this.INFILE=INFILE;
      source = new BufferedReader(new FileReader( INFILE ));
     
        System.out.println("Inside openinfile " + source);
     
    }
    catch ( IOException iox )
    {
      System.out.println("Problem opening " + INFILE );
      return false;
    }

    return true;
  }


  public void deleteProj(String projectName){
                //file to open
      this.openInFiles(resource.CONFIGFILE);
      StringBuffer deleteBuffer = new StringBuffer();
      try
        {      
      line = source.readLine();
      System.out.println("Inside DeleteProj line value : " +line);

      while (line != null )
      {
//this is where I am trying to load the file to the StringBuffer
      deleteBuffer.append(source.readLine());
      }

//More codes
               .....
0
newtosvg
Asked:
newtosvg
  • 4
  • 2
  • 2
  • +3
1 Solution
 
shivsaCommented:
0
 
shivsaCommented:
newtosvg,
ignore my comment it was some other post.
0
 
CEHJCommented:
Try

String line = null;
 try
       {      

     System.out.println("Inside DeleteProj line value : " +line);
     while ((line = source.readLine()) != null )
     {
//this is where I am trying to load the file to the StringBuffer
     deleteBuffer.append(line);


etc.
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
CEHJCommented:
(Naturally, there should be a close brace after

deleteBuffer.append(line);

)
0
 
objectsCommented:
> line = source.readLine();

'line' is only assigned to the first line read

>  while (line != null )

You then use 'line' in your loop test

> deleteBuffer.append(source.readLine());

you then read the next line, and append it to the buffer. This will eventually cause your NPE when your get to the end of file and attempt to append null.
You're also skipping the 1st line of the file (assigned to 'line').
0
 
newtosvgAuthor Commented:
Thanks guys. I do know that I am reading the first line and the value is <config> when I displayed it, which I am thinking it wouldn't be null at
while(line != null) and should be able to continue with the append.
You are right objects, but how do I solve the problem of the Null Pointer when the end of file is reached?
I need to load the entire file to  deleteBuffer so that I can do the delete below. Here is the entire code for deleteProj.

  public void deleteProj(String projectName){
      this.openInFiles(resource.CONFIGFILE);

      StringBuffer deleteBuffer = new StringBuffer();
      try
        {      
      line = source.readLine();
//      while (null != (line = source.readLine()))
            while (line != null )
            {
            deleteBuffer.append(source.readLine());
            }

  int startInd= deleteBuffer.toString().indexOf("<query name="+   projectName +"DefectsSnapshot\">");
  int endInd= deleteBuffer.toString().indexOf("<query name="+ projectName +"DefectsEntry\">");

    deleteBuffer.delete(startInd,endInd);
        }
      catch ( IOException iox )
      {
      System.out.println("Problem reading or writing" );
      }
  this.closeInFiles();
            
  }
 
0
 
objectsCommented:
As CEHJ suggested, read the line, testing whether it is null. And then append it to your buffer:

while ((line = source.readLine()) != null )
{
     deleteBuffer.append(line);
     ..
0
 
dorothy2Commented:
As the other guys have mentioned, this is the usual format:

 while((line = source.readLine()) != null) { }

Write this down somewhere, you will use it a lot if you write programs regularly.

 While you're are in the early stages of development, why don't you print out lines?

Often developers have a boolean variable debug, which they set to true while they are coding and testing, and then they set the value to false before deploying.  You can add lnes of code like

if(debug)
     System.out.println(line);

Just don't delete debug when you don't need it any more, or your code won't compile.

Good luck,

Dorothy
0
 
sciuriwareCommented:
I did something like this before, but my append reads:

     buffer.append(line).append("\n");

to preserve the individual lines structure: all methods "readLine()" discard the line terminator!
You might want to save what you've got and what you are doing now is glueing everything into ONE line.

;JOOP!
0
 
newtosvgAuthor Commented:
CEHJ I tried   while ((line = source.readLine()) != null ) and it works with no Null Pointer. Now that I have the data in the buffer, I deleted some data of it and my question is How do I write the StringBuffer "deletebuffer" new value back to the original file. Thanks for all your help.
0
 
CEHJCommented:
You can use:

 public void writeToFile(StringBuffer sb, String targetFile) {
    PrintWriter out = null;
    try {
      out = new PrintWriter(new FileWriter(targetFile));
      out.print(sb.toString());
      out.close();
    }
    catch(IOException e) {
      e.printStackTrace();
    }
    finally {
      out.close();
    }
  }
0
 
CEHJCommented:
8-)
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 4
  • 2
  • 2
  • +3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now