Solved

PLEASE HELP: recursive factorial in assembly

Posted on 2003-12-11
5
3,887 Views
Last Modified: 2012-06-22
Hi, I am trying to convert the following into 8086 assembly.

#include <stdio.h>

int i;

int fact(n) /* ANSI C version: */
    int n;  /* int fact(int n) */
{
    if (n == 1)
        return 1;
    else
        return n * fact(n-1);
}

void main()
{
    printf("input a number 1-9 : ");
    scanf("%d",&i);

    printf("factorial %d = %d\n",i,fact(i));
}

I have already done the parts that read a number from the keyboard and the result, so please ignore those parts of the code that concern these operations.

I have spend a lot of time, but I cannot implement recursion in the above code.

can you please help me. thanx in advance

below is the code i've done, but it doesnt give me results


      .MODEL TINY     ; Data and code fit in one 64K segment
        .STACK          ; allocate a stack
        .CODE           ; start of code segment

result      equ    [bp+6]
param      equ    [bp+4]


      sub sp,2
      push w[times]
      call fact
      
        jmp l0
      


fact:      push bp
      mov bp,sp
      push ax
      push bx
      push dx
      mov dx,param      
      cmp dx,1
      je base
      
      mov ax,param
      mov cx,ax
      dec cx
      
      mov bx,result
      push cx
      mul bx
      mov result,ax
      call fact

      
base:      mov dx,1      
      mov result,dx
      jmp end


end:      pop cx      
      pop dx
      pop bx
      pop ax
      sub sp,bp
      pop bp
      ret 2
      
l0:          mov ax,4c00h
        int 21h            ; return control to DOS with errorlevel 0

        .data

n       db ?            ; uninitialised short n
k       db ?
times      dw 4
prompt  db 'type a number from 1 to 9: $'

        end

0
Comment
Question by:espadana
  • 2
5 Comments
 
LVL 11

Expert Comment

by:dimitry
ID: 9924540
Recursion suppose that you will use stack for your parameters.
They can not be global in the way you implemented them.
This should be correct code for your fact(n):
      assume      cs:_TEXT
_fact      proc      near
      push      bp
      mov      bp,sp
      push      si
      mov      si,word ptr [bp+4]
      cmp      si,1
      jne      short callFact
      mov      ax,1
      pop      si
      pop      bp
      ret      
callFact:
      mov      ax,si
      dec      ax
      push      ax
      call      near ptr _fact
      add      sp,2
      imul      si
      pop      si
      pop      bp
      ret      
_fact      endp
0
 
LVL 11

Expert Comment

by:dimitry
ID: 9924624
Sorry, I didn't pay attention that you have "define" of param as [bp+4].
I think that your code has 2 problems:
1) You are trying to keep result in stack too... And it should be in AX...
2) This code is wrong:
    mov result, ax
    call fact
base:    
    mov dx,1             <--- Always set result to 1
    mov result,dx
    jmp end



0
 
LVL 3

Accepted Solution

by:
terageek earned 250 total points
ID: 9925256
You can pass return values back on the stack.

; This block is wrong.  
; You need to reserve space on the stack for making a recursive call,
; make the recursive call passing in n-1,
; multiply n by the result from the recursive call,
; and return the result back on the stack
; This code doesn't do that.
     mov bx,result
     push cx
     mul bx
     mov result,ax
     call fact

...    

end:     pop cx   ; you never pushed cx  
     pop dx
     pop bx
     pop ax
     sub sp,bp ; I have no clue what this does except mess up your stack pointer
     pop bp
     ret 2        ; You reserved 4 bytes on the stack for the call, 2 for param and 2 for result
0
 

Author Comment

by:espadana
ID: 10140276
Thanx
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

In the hope of saving someone else's sanity... About a year ago we bought a Cisco 1921 router with two ADSL/VDSL EHWIC cards to load balance local network traffic over the two broadband lines we have, but we couldn't get the routing to work consi…
There is no doubt that cloud is gaining importance. Many of you must have read about this technology and its growing importance. More and more organisations are embracing this technology not forgetting start-ups. The process begins by dipping …
Migrating to Microsoft Office 365 is becoming increasingly popular for organizations both large and small. If you have made the leap to Microsoft’s cloud platform, you know that you will need to create a corporate email signature for your Office 365…
Both in life and business – not all partnerships are created equal. As the demand for cloud services increases, so do the number of self-proclaimed cloud partners. Asking the right questions up front in the partnership, will enable both parties …

864 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now