Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

MultiDimArrays - What's wrong with my code?

Posted on 2003-12-11
7
236 Views
Last Modified: 2010-04-01
Hi,

Is there anything wrong with this C++ code?  If not, does anyone have any idea why I'm getting the memory error message below?

**********************************

__declspec(dllexport) double __stdcall STCDO3(double ** sigma, int rowssigma)
{
   return sigma[0][0];
}

**********************************

I'm trying to call this C++ dll function from an excel VBA like this,

**********************************

Private Declare Function STCDO3 Lib "STCDO_C.DLL" _
(sigma As Double, ByVal rowssigma As Integer) As Double

Function STC() As Double
   
    Dim arrsigma(7, 1) As Double
    Dim k As Integer
    Dim l As Integer
    k = 10
    l = 20
   
    For i = 0 To 7
        arrsigma(i, 0) = k * i
        arrsigma(i, 1) = l * i
    Next
   
    STC = STCDO3(arrsigma(0, 0), 7)
   
End Function

**********************************

and when I do I get the error mesesage,

"The instruction at "0x03d915dd" referenced memory at "0x00000000". The memory could not be "read""

**********************************

0
Comment
Question by:malramsay
  • 3
  • 2
  • 2
7 Comments
 
LVL 10

Expert Comment

by:Sys_Prog
ID: 9926067
Hi

I think the call to the function is incorrect

STC = STCDO3(arrsigma(0, 0), 7)


Yoiu are passing the first element of the two dim array [i.e. a double value] while in C++, the function is expecting a pointre to a pointer to a double

Amit
0
 

Author Comment

by:malramsay
ID: 9926088
Hi Amit,

This microsoft page deal with this, but it's only concerning one dimensional arrays.  

http://support.microsoft.com/default.aspx?scid=http://support.microsoft.com:80/support/kb/articles/Q207/9/31.asp&NoWebContent=1&NoWebContent=1

//So, the C++ function starts like,

long __declspec (dllexport) __stdcall AddLongs_Pointer(long *plArrayOfLongs, long lElements)   {

//Whilst the VBA is

Private Declare Function AddLongs_Pointer Lib "MyStDll.dll" _
   (FirstElement As Long, ByVal lElements As Long) As Long

lSum = AddLongs_Pointer(ArrayOfLongs(0), UBound(ArrayOfLongs)+1)

//Is my C++ correct in how it is receiving the multidimarray (i.e. with **)?  If you were passing a multidimarray from another C++ function to that one, is that how you would receive and then use it?
0
 
LVL 10

Accepted Solution

by:
Sys_Prog earned 125 total points
ID: 9926109
No man

it should be something like this

#include <iostream>

using namespace std ;

int f ( int p[][5] ) {
   return p[0][0] ;
}
int main ( ) {
   int a[5][5] ;
   a[0][0] = 1 ;
   cout << f ( a ) ;
   system ( "PAUSE" ) ;
}


i.e. For one dim array, u can use a pointer notation
But for more than one dim, u should use the array notation and that u will have to provide all the dimensions except the first one

Amit
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 

Author Comment

by:malramsay
ID: 9926229

Oh dear.  I am going to also be sending to this C++ function multidimensional arrays that can be any number of rows by any number of columns.  I understood that when single arrays are passed between functions you have to send the size of the array as a separate variable, so the function knew the size of the array.  

I was hoping to thus send a multidimensional array with two variables - one for the rows and one for the columns.  I suppose this is not possible?  

I think I'm going to have to use SAFEARRAYS, which I really didn't want to do as they look rather complicated and I'm running out of time.  Are there any other alternatives you know about?
0
 
LVL 10

Expert Comment

by:Sys_Prog
ID: 9926450
I do agree with u

I think SAFEARRAY's should be a better option
0
 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 9929241
Look at this:

template <class T>
class Array2D
{
private:
    T*    data;
      int   dimy;
      int   dimx;

public:
    Array2D(T* d, int y, int x = -1)
         : data(d), dimy(y), dimx(x)      {}
    Array2D(T** d, int y, int x = -1)
         : data(d[0]), dimy(y), dimx(x)      {}
      T& operator() (int y, int x) {       int pos = (y * dimy + x); return data[pos]; }
      
};
                                     
void main()
{
      int   arr[3][4] = {  { 1, 2, 3, 4, }, { 1, 2, 3, 4, }, { 1, 2, 3, 4, }, };
      Array2D<int>  ia((int*)arr, 3);
      ia(3, 4) = ia(2, 5);
}

For your example it would be

__declspec(dllexport) double __stdcall STCDO3(double ** sigma, int rowssigma)
{
   Array2D<double> s(sigma, rowssigma);
   return s(0, 0);
}

Easier than SAFE_ARRAY ?

Regards, Alex



0
 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 9929272
Forget the line

        ia(3, 4) = ia(2, 5);       // kaboom!!

Better

         ia(0, 1) = ia(2, 2);

I reduced the dimensions for the example. :-)

Alex
0

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article will show you some of the more useful Standard Template Library (STL) algorithms through the use of working examples.  You will learn about how these algorithms fit into the STL architecture, how they work with STL containers, and why t…
Introduction This article is a continuation of the C/C++ Visual Studio Express debugger series. Part 1 provided a quick start guide in using the debugger. Part 2 focused on additional topics in breakpoints. As your assignments become a little more …
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.
The viewer will learn how to user default arguments when defining functions. This method of defining functions will be contrasted with the non-default-argument of defining functions.

839 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question