Solved

possible to have Cursor Inside Stored Procedure?

Posted on 2004-03-21
7
457 Views
Last Modified: 2008-03-03
Hi All
I am trying to create few cursors inside a stored procedure which will be used for reporting from crystal reports, adn receiving the following error

Server: Msg 156, Level 15, State 1, Procedure sp_RollingWeekly, Line 4
Incorrect syntax near the keyword 'DECLARE'.

Stored procedure is...

CREATE PROCEDURE sp_RollingWeekly
       @vStatus varchar(50)

      DECLARE cr_Status CURSOR FOR --ERROR IS HERE
      SELECT Distinct(Status) FROM iTouch WHERE Status is not null
      
      OPEN cr_Status
      FETCH NEXT FROM cr_Status INTO @vStatus
      WHILE @@FETCH_STATUS = 0
            BEGIN
                  FETCH NEXT FROM cr_Status INTO @vStatus
                  Print @vStatus
            END
      CLOSE DKWItems_Cursor
      DEALLOCATE DKWItems_Cursor

GO

can any one tell me that whether cursors can be used inside a stored procedure, if yes then what is the correct syantax?
Many thanks

0
Comment
Question by:jadoger
  • 4
  • 3
7 Comments
 
LVL 34

Accepted Solution

by:
arbert earned 50 total points
ID: 10645664
You're missing the keyword AS


CREATE PROCEDURE sp_RollingWeekly
      @vStatus varchar(50)

AS




What's the end result--cursors are usually pretty slow and should be avoided...
0
 

Author Comment

by:jadoger
ID: 10645691
oopps thanks
I have to create this stored procedure and make some calcualations which are not possible through crystal report
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645701
Right, but is it something you can accomplish with TSQL NOT using a cursor?
0
Get up to 2TB FREE CLOUD per backup license!

An exclusive Black Friday offer just for Expert Exchange audience! Buy any of our top-rated backup solutions & get up to 2TB free cloud per system! Perform local & cloud backup in the same step, and restore instantly—anytime, anywhere. Grab this deal now before it disappears!

 

Author Comment

by:jadoger
ID: 10645715
dont no, Actully I just want to loop through a look-up table nad then want to ahve certain calculations based on each row of that lookup table
Loopup table is...

Status
----------
Send
Failed
Not Send

now i want to loop through that table and calculate that how many values aggainst each of this status is present in some other table, is there any other way of doin this apart from cursor ? i would love no that
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645726
Ya, a simple join between the tables and do your calculation.....
0
 

Author Comment

by:jadoger
ID: 10645744
:) ya  i wish i could do that but my client is not giving me access to the database so all what I have is the dummy one table created in my database in which there is a field named STATUS so i am trying to first select all the possible distinct values from that table and then procced calculations, still dont no that whether i would have direct access to client database or not, so in any case i want to complete my assignment so i can give him report based on the data he gave me, yeah i can create a lookup table in my database and can use Join but not sure that whether the lookup table is in client database or not, the file which he has provided is an output of a stored procedure. thats the story mate :)
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645939
I guess I'm confused.  You don't have to have a lookup table--if you have a status field, you just perform calculation on the "status" field using a case statement--no lookup table needed (though it would be easier).  Still much less work than a cursor....
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Suggested Solutions

Performance is the key factor for any successful data integration project, knowing the type of transformation that you’re using is the first step on optimizing the SSIS flow performance, by utilizing the correct transformation or the design alternat…
Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties

757 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now