Solved

possible to have Cursor Inside Stored Procedure?

Posted on 2004-03-21
7
458 Views
Last Modified: 2008-03-03
Hi All
I am trying to create few cursors inside a stored procedure which will be used for reporting from crystal reports, adn receiving the following error

Server: Msg 156, Level 15, State 1, Procedure sp_RollingWeekly, Line 4
Incorrect syntax near the keyword 'DECLARE'.

Stored procedure is...

CREATE PROCEDURE sp_RollingWeekly
       @vStatus varchar(50)

      DECLARE cr_Status CURSOR FOR --ERROR IS HERE
      SELECT Distinct(Status) FROM iTouch WHERE Status is not null
      
      OPEN cr_Status
      FETCH NEXT FROM cr_Status INTO @vStatus
      WHILE @@FETCH_STATUS = 0
            BEGIN
                  FETCH NEXT FROM cr_Status INTO @vStatus
                  Print @vStatus
            END
      CLOSE DKWItems_Cursor
      DEALLOCATE DKWItems_Cursor

GO

can any one tell me that whether cursors can be used inside a stored procedure, if yes then what is the correct syantax?
Many thanks

0
Comment
Question by:jadoger
  • 4
  • 3
7 Comments
 
LVL 34

Accepted Solution

by:
arbert earned 50 total points
ID: 10645664
You're missing the keyword AS


CREATE PROCEDURE sp_RollingWeekly
      @vStatus varchar(50)

AS




What's the end result--cursors are usually pretty slow and should be avoided...
0
 

Author Comment

by:jadoger
ID: 10645691
oopps thanks
I have to create this stored procedure and make some calcualations which are not possible through crystal report
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645701
Right, but is it something you can accomplish with TSQL NOT using a cursor?
0
PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

 

Author Comment

by:jadoger
ID: 10645715
dont no, Actully I just want to loop through a look-up table nad then want to ahve certain calculations based on each row of that lookup table
Loopup table is...

Status
----------
Send
Failed
Not Send

now i want to loop through that table and calculate that how many values aggainst each of this status is present in some other table, is there any other way of doin this apart from cursor ? i would love no that
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645726
Ya, a simple join between the tables and do your calculation.....
0
 

Author Comment

by:jadoger
ID: 10645744
:) ya  i wish i could do that but my client is not giving me access to the database so all what I have is the dummy one table created in my database in which there is a field named STATUS so i am trying to first select all the possible distinct values from that table and then procced calculations, still dont no that whether i would have direct access to client database or not, so in any case i want to complete my assignment so i can give him report based on the data he gave me, yeah i can create a lookup table in my database and can use Join but not sure that whether the lookup table is in client database or not, the file which he has provided is an output of a stored procedure. thats the story mate :)
0
 
LVL 34

Expert Comment

by:arbert
ID: 10645939
I guess I'm confused.  You don't have to have a lookup table--if you have a status field, you just perform calculation on the "status" field using a case statement--no lookup table needed (though it would be easier).  Still much less work than a cursor....
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Let's review the features of new SQL Server 2012 (Denali CTP3). It listed as below: PERCENT_RANK(): PERCENT_RANK() function will returns the percentage value of rank of the values among its group. PERCENT_RANK() function value always in be…
This article explains how to reset the password of the sa account on a Microsoft SQL Server.  The steps in this article work in SQL 2005, 2008, 2008 R2, 2012, 2014 and 2016.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties
Via a live example, show how to backup a database, simulate a failure backup the tail of the database transaction log and perform the restore.

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now