Solved

Updating a dialog while reading a file

Posted on 2004-03-30
25
161 Views
Last Modified: 2010-03-31
I have a dialog that starts up a new file reader object (that runs in a separate thread). That file reader object needs to update a textfield message box on the dialog as it progresses through the file. I tried  starting the dialog in new thread but the message box still doesn't update until the file reader object is done reading the file. Here's a code summary of what I have done:

Thread a;
Runnable run2 = new Runnable(){
    public void run(){
        //start up dialog that starts the file reader object (in another thread)
    }
};

a = new Thread(run2);
a.start();

Any ideas how I correctly update the textfield in the dialog from the different file reader object? Right now I pass a reference to the textfield to the file reader object.
0
Comment
Question by:cmp2
  • 8
  • 8
  • 6
25 Comments
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
Try something like:


// inner class
class FieldUpdater implements Runnable {
      public static void run() {
            yourDialog.setText("New text");
      }
}


// in your file thread (i.e. in run2) - update dialog:
invokeAndWait(new FieldUpdater())

0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
Sorry

SwingUtilities.invokeAndWait(new FieldUpdater());
0
 
LVL 92

Accepted Solution

by:
objects earned 125 total points
Comment Utility
pass a reference to the text filed to your thread:

class MyThread implements Runnable
{
   JTextField TF = null;

   MyThread(JTextField tf)
   {
      TF = tf;
   }

   public void run()
   {
      ...
      // to update text field use:
      // TF.setText(s);
      ...
   }
}
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
>> Runnable run2 = new Runnable(){

Thread run2 = new Thread () {

could also work.
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
I don't think that my comment would make much of a difference because complete solutions had already been provided. It was just another alternative which didn't make much of a difference.

Split between objects and CEHJ only.
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
theres no need to use invokeAndWait() in this case.
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
True but it doesn't hurt and encourages good habits for when it is required
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
unnecessaary object creation is *not* a good habit to encourage.
In fact it is a *bad* habit.
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
All that will happen, most probably, if the questioner is not aware of the working of interaction with the EDT, is that he'll go away and take the easy way in another context and wonder why he's got problems. It's the correct way to do it anyway as it happens. It just transpires that you can get away without it in this case.
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
Sorry but thats does not make any sense whatsever, what you have posted is not relevant to this question. And even if they were then you should explain the reasoning (but I guess there is none so whats to explain).
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
I've done all the explaining that i'm going to do sorry. If you don't understand what i mean, maybe mayank will be kind enough to explain it to you
0
Top 6 Sources for Identifying Threat Actor TTPs

Understanding your enemy is essential. These six sources will help you identify the most popular threat actor tactics, techniques, and procedures (TTPs).

 
LVL 92

Expert Comment

by:objects
Comment Utility
Explaination of what??? The point is your comment is irrelevant to the question.
So no explanation necessary.
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
Ah, cool it guys. Venabili, for some reason, I feel your initial recommendation was fine and I hope the question is closed as per that ;-)
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
> for some reason, I feel your initial recommendation was fine

Can you help me understand then how calling setText() from the event dispatch thread will make any difference then?
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
>> I feel your initial recommendation was fine

Oh, I said that just hoping to close the arguments going on. I don't see a point arguing so much because the questioner is not listening.

>>  how calling setText() from the event dispatch thread will make any difference

So far, I had not been following the comments carefully on this page after the clean-up comment, but now that I do see them again, I think that the invokeAndWait () should not be used.
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
>  I don't see a point arguing so much because the questioner is not listening.

My concern in this case is more the PAQ, people reading the thread at a later date will be misled. (I don't see a point in arguing about it either)
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
>> people reading the thread at a later date

Your concern about that is correct.
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
A point to you mayankeagle - and the last word on the matter from me - i too am concerned, believe it or not, about people being misled. That's why i am pointing out that it's NOT ok to change components from a non-EDT thread in Swing in most cases.
0
 
LVL 92

Expert Comment

by:objects
Comment Utility
> That's why i am pointing out that it's NOT ok to change components from a non-EDT thread in Swing in most cases.

no one said it was but that has nothing to do with this question.
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
I know that you are concerned too, CEHJ ;-) I know that you always are.... both of you :-)

But as far as my knowledge goes, I don't see why invokeAndWait () would help much, and I also don't find what non-EDT thread in Swing has to do with this. Maybe that I know a little lesser or am unable to see something which is very apparent to both of you. Excuse my little knowledge compared to yours ;-)
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
Don't be cross at me for something ;-) I hope you didn't miscomprehend me to be partial or something like that.

>> believe it or not,

You don't need to say that. I always believe in what you say.

I respect both of you equally, and your knowledge. Maybe that I don't know enough to speak more on this.
0
 
LVL 30

Expert Comment

by:mayankeagle
Comment Utility
I would still say, split objects and CEHJ, like I said before. This is the last comment from me on this page.
0

Featured Post

Highfive + Dolby Voice = No More Audio Complaints!

Poor audio quality is one of the top reasons people don’t use video conferencing. Get the crispest, clearest audio powered by Dolby Voice in every meeting. Highfive and Dolby Voice deliver the best video conferencing and audio experience for every meeting and every room.

Join & Write a Comment

Suggested Solutions

Title # Comments Views Activity
sumHeights2  challenge 7 75
countAbc challenge 9 49
JAVA part two 5 39
Problem to start Neon 20 49
For customizing the look of your lightweight component and making it look lucid like it was made of glass. Or: how to make your component more Apple-ish ;) This tip assumes your component to be of rectangular shape and completely opaque. (COD…
An old method to applying the Singleton pattern in your Java code is to check if a static instance, defined in the same class that needs to be instantiated once and only once, is null and then create a new instance; otherwise, the pre-existing insta…
This tutorial covers a step-by-step guide to install VisualVM launcher in eclipse.
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now