Solved

Not all items in array are outputting to file.

Posted on 2004-03-31
10
211 Views
Last Modified: 2010-03-31
Hi i recently asked the question on how i could read files in from a directory which i specify. What has been done is...

The file names have been read from a directory and stored in an array of type string. I then iterate through the array using a for loop to print each file name in the array to an external "txt" file. But when i open the txt file only about 180 file names have been written to it when in fact the array holds around 390 file names. ( which i checked using the static variable length in array)

Why doesnt all the file names output to the external file?

Note: For outputting to an external file i am using a java.io.FilerWriter. Could it be this?

Initially i thought it could be because i am using an array, so instead i used another collection called the treeset, but this has the same effect to the program.

Anyone know why, and how i may resolve this?
0
Comment
Question by:Ravi Singh
  • 5
  • 3
  • 2
10 Comments
 
LVL 86

Accepted Solution

by:
CEHJ earned 25 total points
Comment Utility
Best to use a PrintWriter

File f = new File("javadir");
PrintWriter out = new PrintWriter(new FileWriter("file.txt"));
String[] fileNames = f.list();
for (int i = 0; i < fileNames.length; i++) {
      out.println(fileNames[i]);
}
out.close()
0
 
LVL 18

Author Comment

by:Ravi Singh
Comment Utility
i instantiated  it like this:

PrintWriter out = new PrintWriter(new BufferedWriter(new FileWriter(newFileName)));

could it be the bufferedwriter then?
0
 
LVL 37

Assisted Solution

by:zzynx
zzynx earned 25 total points
Comment Utility
>> could it be the bufferedwriter then?
Could be.
A buffered writer has a flush() call. Use it before closing
0
 
LVL 37

Expert Comment

by:zzynx
Comment Utility
btw: It was a good idea to use a buffered writer.
I quote from the java help of BufferedWriter:

In general, a Writer sends its output immediately to the underlying character or byte stream. Unless prompt output is required, ****it is advisable to wrap a BufferedWriter around any Writer whose write() operations may be costly, such as FileWriters and OutputStreamWriters****. For example,

 PrintWriter out
   = new PrintWriter(new BufferedWriter(new FileWriter("foo.out")));
 
will buffer the PrintWriter's output to the file. Without buffering, each invocation of a print() method would cause characters to be converted into bytes that would then be written immediately to the file, which can be very inefficient.
0
 
LVL 18

Author Comment

by:Ravi Singh
Comment Utility
Ah sorry ive done this so many times and still havnt learned, I didnt close the printwriter i just noticed it now from your code CEHJ. Sorry to bother you.
0
How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

 
LVL 37

Expert Comment

by:zzynx
Comment Utility
So in CEHJ's example it would be:

File f = new File("javadir");
BufferedWriter bw = new BufferedWriter(new FileWriter("file.txt"));
PrintWriter out = new PrintWriter(bw);
String[] fileNames = f.list();
for (int i = 0; i < fileNames.length; i++) {
      out.println(fileNames[i]);
}
bw.flush();
out.close()
0
 
LVL 18

Author Comment

by:Ravi Singh
Comment Utility
Thanks zzynx.
0
 
LVL 37

Expert Comment

by:zzynx
Comment Utility
You're welcome.
Thanks for accepting. That keeps us going.
:-)
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
8-)

Not much point in flushing btw at that point. The buffered will automatically be flushed on close
0
 
LVL 37

Expert Comment

by:zzynx
Comment Utility
>> The buffered will automatically be flushed on close
Good to know. Thanks.
0

Featured Post

What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

Join & Write a Comment

Suggested Solutions

For customizing the look of your lightweight component and making it look opaque like it was made of plastic.  This tip assumes your component to be of rectangular shape and completely opaque.   (CODE)
This was posted to the Netbeans forum a Feb, 2010 and I also sent it to Verisign. Who didn't help much in my struggles to get my application signed. ------------------------- Start The idea here is to target your cell phones with the correct…
Viewers learn about the “for” loop and how it works in Java. By comparing it to the while loop learned before, viewers can make the transition easily. You will learn about the formatting of the for loop as we write a program that prints even numbers…
Viewers will learn about the different types of variables in Java and how to declare them. Decide the type of variable desired: Put the keyword corresponding to the type of variable in front of the variable name: Use the equal sign to assign a v…

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now