Solved

Multithreaded server socket authentication

Posted on 2004-04-09
4
1,857 Views
Last Modified: 2008-03-17
Go morning/afternoon/evening/good night

I am trying to find a way to make sure that every NEW connection needs to go through an authentication process before the server can accept connections from the client. However this should authentication procedure should not affect the clients who are already connected (the server should still continue receiving data from the already authenticated clients). The code I've got is:

import java.net.*;
import java.io.*;
import java.util.*;

/*
 * Class is used to authenticate the user
 */

public class PSWD implements Cloneable, Runnable
{
      Thread runner = null;
      ServerSocket pswd = null;
      Socket client = null;
      BufferedReader br = null;
      PrintWriter pw = null;
      boolean stop = false;
      static boolean authenticated = false;
      
      public synchronized void startPSWD(int port) throws IOException
      {
            if (runner == null)
            {
                  pswd = new ServerSocket(port);
                  runner = new Thread(this);
                  runner.start();
            }
      }

      public synchronized void stopPSWD()
      {
            if (pswd != null)
            {
                  stop = true;
                  runner.interrupt();
                  runner = null;
                  try
                  {
                        pswd.close();
                  }
                  catch (IOException ioe)
                  {
                        System.out.println("PSWD: Error");
                  }
                  pswd = null;
            }
      }

      public void run()
      {
            if (pswd != null)
            {
                  while (!stop)
                  {
                        try
                        {
                              Socket clientSocket = pswd.accept();
                              PSWD newPSWD = (PSWD) clone();

                              newPSWD.pswd = null;
                              newPSWD.client = clientSocket;
                              newPSWD.runner = new Thread(newPSWD);
                              newPSWD.runner.start();
                        }
                        catch (Exception e)
                        {
                        }
                  }
            }
            else
            {
                  run(client);
            }
      }

      public void run(Socket client)
      {
            try
          {
                br = new BufferedReader(new InputStreamReader(client.getInputStream()));
                pw = new PrintWriter(client.getOutputStream(), true);
          }
          catch (IOException ioe)
          {
                  System.out.println("PSWD: Streams failed");
                  System.exit(-1);
          }
}

I'm not too worried about the authentication class at this stage, my primary concern is that if I set an arbitrary boolean value to false I wouldn't affect the clients already connected.

Pseudo code / stubs would be good but example code would be even better.
0
Comment
Question by:brimful
  • 3
4 Comments
 
LVL 86

Expert Comment

by:CEHJ
ID: 10793509
Because your application is multi-threaded, new connections won't affect already exsting ones. You should allow the Runnable used by the Thread to do the authentication. If it doesn't authenticate, it doesn't run any further. btw, there's no need to clone your whole class as you seem to be doing - all you need is your new Thread and Runnable
0
 
LVL 92

Expert Comment

by:objects
ID: 10794814
> I am trying to find a way to make sure that every NEW connection needs to go through an authentication process

then authenticated should not be static.

you should also have a seperate class for handling client connection.
0
 
LVL 92

Accepted Solution

by:
objects earned 125 total points
ID: 10794823
So it would look something like:


public class PSWD implements Cloneable, Runnable
{
     Thread runner = null;
     ServerSocket pswd = null;
     boolean stop = false;
     
     public synchronized void startPSWD(int port) throws IOException
     {
          if (runner == null)
          {
               pswd = new ServerSocket(port);
               runner = new Thread(this);
               runner.start();
          }
     }

     public synchronized void stopPSWD()
     {
          if (pswd != null)
          {
               stop = true;
               runner.interrupt();
               runner = null;
               try
               {
                    pswd.close();
               }
               catch (IOException ioe)
               {
                    System.out.println("PSWD: Error");
               }
               pswd = null;
          }
     }

     public void run()
     {
          if (pswd != null)
          {
               while (!stop)
               {
                    try
                    {
                         Socket clientSocket = pswd.accept();
                         PSWDClient newPSWD = new PSWDClient(clientSocket);
                    }
                    catch (Exception e)
                    {
                    }
               }
          }
     }
}

public class PSWDClient implements Runnable
{
     Thread runner = null;
     Socket client = null;
     BufferedReader br = null;
     PrintWriter pw = null;
     boolean stop = false;
     boolean authenticated = false;

     public PSWDClient(Socket client)
     {
          try
         {
              br = new BufferedReader(new InputStreamReader(client.getInputStream()));
              pw = new PrintWriter(client.getOutputStream(), true);
              runner = new Thread(newPSWD);
              runner.start();
         }
         catch (IOException ioe)
         {
               System.out.println("PSWD: Streams failed");
               System.exit(-1);
         }

         public void run()
         {
             // handle client comms
         }

}
0
 
LVL 92

Expert Comment

by:objects
ID: 10799122
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Protect jar file - windows app 2 50
groupSumClump challenge 9 115
Groovy problem when using SOAPUI : DispatchException occurred 7 43
null output 3 24
After being asked a question last year, I went into one of my moods where I did some research and code just for the fun and learning of it all.  Subsequently, from this journey, I put together this article on "Range Searching Using Visual Basic.NET …
Introduction This article is the last of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers our test design approach and then goes through a simple test case example, how …
Viewers learn about the third conditional statement “else if” and use it in an example program. Then additional information about conditional statements is provided, covering the topic thoroughly. Viewers learn about the third conditional statement …
Viewers will learn about if statements in Java and their use The if statement: The condition required to create an if statement: Variations of if statements: An example using if statements:

815 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

8 Experts available now in Live!

Get 1:1 Help Now