Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Multithreaded server socket authentication

Posted on 2004-04-09
4
1,897 Views
Last Modified: 2008-03-17
Go morning/afternoon/evening/good night

I am trying to find a way to make sure that every NEW connection needs to go through an authentication process before the server can accept connections from the client. However this should authentication procedure should not affect the clients who are already connected (the server should still continue receiving data from the already authenticated clients). The code I've got is:

import java.net.*;
import java.io.*;
import java.util.*;

/*
 * Class is used to authenticate the user
 */

public class PSWD implements Cloneable, Runnable
{
      Thread runner = null;
      ServerSocket pswd = null;
      Socket client = null;
      BufferedReader br = null;
      PrintWriter pw = null;
      boolean stop = false;
      static boolean authenticated = false;
      
      public synchronized void startPSWD(int port) throws IOException
      {
            if (runner == null)
            {
                  pswd = new ServerSocket(port);
                  runner = new Thread(this);
                  runner.start();
            }
      }

      public synchronized void stopPSWD()
      {
            if (pswd != null)
            {
                  stop = true;
                  runner.interrupt();
                  runner = null;
                  try
                  {
                        pswd.close();
                  }
                  catch (IOException ioe)
                  {
                        System.out.println("PSWD: Error");
                  }
                  pswd = null;
            }
      }

      public void run()
      {
            if (pswd != null)
            {
                  while (!stop)
                  {
                        try
                        {
                              Socket clientSocket = pswd.accept();
                              PSWD newPSWD = (PSWD) clone();

                              newPSWD.pswd = null;
                              newPSWD.client = clientSocket;
                              newPSWD.runner = new Thread(newPSWD);
                              newPSWD.runner.start();
                        }
                        catch (Exception e)
                        {
                        }
                  }
            }
            else
            {
                  run(client);
            }
      }

      public void run(Socket client)
      {
            try
          {
                br = new BufferedReader(new InputStreamReader(client.getInputStream()));
                pw = new PrintWriter(client.getOutputStream(), true);
          }
          catch (IOException ioe)
          {
                  System.out.println("PSWD: Streams failed");
                  System.exit(-1);
          }
}

I'm not too worried about the authentication class at this stage, my primary concern is that if I set an arbitrary boolean value to false I wouldn't affect the clients already connected.

Pseudo code / stubs would be good but example code would be even better.
0
Comment
Question by:brimful
  • 3
4 Comments
 
LVL 86

Expert Comment

by:CEHJ
ID: 10793509
Because your application is multi-threaded, new connections won't affect already exsting ones. You should allow the Runnable used by the Thread to do the authentication. If it doesn't authenticate, it doesn't run any further. btw, there's no need to clone your whole class as you seem to be doing - all you need is your new Thread and Runnable
0
 
LVL 92

Expert Comment

by:objects
ID: 10794814
> I am trying to find a way to make sure that every NEW connection needs to go through an authentication process

then authenticated should not be static.

you should also have a seperate class for handling client connection.
0
 
LVL 92

Accepted Solution

by:
objects earned 125 total points
ID: 10794823
So it would look something like:


public class PSWD implements Cloneable, Runnable
{
     Thread runner = null;
     ServerSocket pswd = null;
     boolean stop = false;
     
     public synchronized void startPSWD(int port) throws IOException
     {
          if (runner == null)
          {
               pswd = new ServerSocket(port);
               runner = new Thread(this);
               runner.start();
          }
     }

     public synchronized void stopPSWD()
     {
          if (pswd != null)
          {
               stop = true;
               runner.interrupt();
               runner = null;
               try
               {
                    pswd.close();
               }
               catch (IOException ioe)
               {
                    System.out.println("PSWD: Error");
               }
               pswd = null;
          }
     }

     public void run()
     {
          if (pswd != null)
          {
               while (!stop)
               {
                    try
                    {
                         Socket clientSocket = pswd.accept();
                         PSWDClient newPSWD = new PSWDClient(clientSocket);
                    }
                    catch (Exception e)
                    {
                    }
               }
          }
     }
}

public class PSWDClient implements Runnable
{
     Thread runner = null;
     Socket client = null;
     BufferedReader br = null;
     PrintWriter pw = null;
     boolean stop = false;
     boolean authenticated = false;

     public PSWDClient(Socket client)
     {
          try
         {
              br = new BufferedReader(new InputStreamReader(client.getInputStream()));
              pw = new PrintWriter(client.getOutputStream(), true);
              runner = new Thread(newPSWD);
              runner.start();
         }
         catch (IOException ioe)
         {
               System.out.println("PSWD: Streams failed");
               System.exit(-1);
         }

         public void run()
         {
             // handle client comms
         }

}
0
 
LVL 92

Expert Comment

by:objects
ID: 10799122
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Protect jar file - windows app 2 65
Custom Java Application connects to database: Which one of the 20? 4 35
check java version using powershell 13 171
Java string replace 11 54
Java contains several comparison operators (e.g., <, <=, >, >=, ==, !=) that allow you to compare primitive values. However, these operators cannot be used to compare the contents of objects. Interface Comparable is used to allow objects of a cl…
In this post we will learn how to connect and configure Android Device (Smartphone etc.) with Android Studio. After that we will run a simple Hello World Program.
Viewers learn how to read error messages and identify possible mistakes that could cause hours of frustration. Coding is as much about debugging your code as it is about writing it. Define Error Message: Line Numbers: Type of Error: Break Down…
This tutorial covers a step-by-step guide to install VisualVM launcher in eclipse.

856 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question