Solved

multimap

Posted on 2004-04-17
6
376 Views
Last Modified: 2010-04-01
I have 2 input files xx.txt & yy.txt

contents of xx.txt are as follows
Aardenburg,,34394,512775,4527
Aardenburg,,30000,500000,4527
fields are city,cu,x,y,poco

contents of yy.txt are as follows

4527 AA,AARDENBURG
4527 AB,AARDENBURG
4553 AA,PHILIPPINE
4553 AB,PHILIPPINE
4555 xx,girija

fields are poco & city.

I want to match 4 digit poco & city of yy.txt  with poco & city of xx.txt.if they are matched 7digit poco of yy.txt should be appennded.output should be as follows.

Aardenburg,,34394,512775,4527,@4527 AA@4527 AB
Aardenburg,,30000,500000,4527,@4527 AA@4527 AB

the coding is as follows

#include <map>
#include <iostream>
#include <sstream>
#include <fstream>
#include <vector>
#include <algorithm>
#include <cstdlib>
#include <conio.h>
#include <list>
using namespace std;
typedef multimap<string,string> yy;
void process_yy(yy &);
void process_xx(yy &);

string toUpper(string strText)
{
      transform(strText.begin(), strText.end(), strText.begin(), toupper);
      return strText;
}

int main( )
{  
      
      yy YY;

      process_yy(YY);
      process_xx(YY);
}

void process_xx(yy &YY)
{
      list<string> list1;
      ifstream f_road("xx.txt");
      string line_str,str_element,ct,p;
      string city,poco,cu,x,y,add;
      string xx_cu_key,xx_key;
      int i,j;
      typedef pair <string, string> Int_Pair;
      multimap<string,string>::iterator it;
      multimap<string,string>::iterator it1;
      multimap<string,string>::iterator last_el;
      multimap<string,string>::iterator last_el1;

ofstream f_match("match.txt");
            ofstream f_nomatch("nomatch.txt");
      
      while(getline(f_road,line_str))
      {
            std::istringstream istr(line_str);
            getline(istr,city,',');
            getline(istr,cu,',');
            getline(istr,x,',');
            getline(istr,y,',');
            getline(istr,poco,',');
            string city_org,cu_org;
            cu_org=cu;city_org=city;
            

            city = toUpper(city_org);
            cu=toUpper(cu_org);

                  
            xx_key.clear();
            xx_cu_key.clear();
            city.append(poco);
            cu.append(poco);
            
            

            it=YY.find(city);
            if(it!=YY.end())      
            {
                  

                  last_el=YY.upper_bound(city);
                  last_el1=YY.upper_bound(city);
                  for(;it!=last_el;it++)
                  {
                        add = it->second;
                        std::istringstream istr1(add);
                        getline(istr1,ct,',');
                        getline(istr1,p,',');
                        list1.push_back('@'+p);
                        //ParmsList.push_back('@'+p);
                  }
                        
                        f_match<<city_org<<','<<cu_org<<','<<x<<','<<y<<','<<poco<<',';
                        cout<<city<<','<<cu<<','<<x<<','<<y<<','<<poco<<','<<it->second<<',' ;
                        copy (list1.begin(),list1.end(),std::ostream_iterator<std::string>(f_match));
                        f_match<<"\n";
                        
                        list1.clear();
            }
                                    
                  else
                  {
                        f_nomatch<<city_org<<','<<cu_org<<','<<x<<','<<y<<','<<poco<<"\n";
                  }
            }
      }

}
      


void process_yy(yy  & YY)
{
      ifstream f_road("yy.txt");
      string line_str,str_element;
      string city,poco_n,poco,yy_key;
      typedef pair <string, string> Int_Pair;


      
      while(getline(f_road,line_str))
      {
            std::istringstream istr(line_str);
            getline(istr,poco_n,',');
            getline(istr,city,',');
            poco= poco_n.substr(0,4);
            yy_key=city+poco;
            city = city + ',' + poco_n;
            YY.insert(Int_Pair(yy_key,city));
                  
      }
      multimap<string,string>::iterator it;
      /*it=m_roadmap.find("Abc");
      if(it!=m_roadmap.end())
      {
            cout<<"found";
      }*/
      for(it=YY.begin();it!=YY.end();it++)
      {
            cout<<it->first<<"\n";
            cout<<it->second<<"\n";

      }
      
}



but it prints the o/p as follows.

Aardenburg,,34394,512775,4527,@4527 AA@4527 AB

can anyone giude me?



0
Comment
Question by:girija_cv
  • 2
  • 2
6 Comments
 
LVL 6

Expert Comment

by:Mafalda
ID: 10848705
20 points is not going to get you far ...
I understand that your problem is that the multimap is not containing all records, so check the place where you insert these records and print a trace just before the insert and afterwards check if it was inserted.

I suggest that first you use C++ as you should and encapsulate reading from each file.
Then apply the processes to the adecuate object.
It will be much easier to debug and maintain.
0
 
LVL 39

Accepted Solution

by:
itsmeandnobodyelse earned 20 total points
ID: 10848758
I wonder that  you got any output with that code. First it doesn't compile because there was a bracket error, and second it doesn't match any key.
The reason for this is easy:

In your first file poco is only a number, e.g. 4527, in your second file it is a string, say "4527 AA". When setting the key to the map as number and searching using the string it couldn't work. To solve this, simply strip the AA, AB extension before appending poco to the city string:

         string poco_n = poco.substr(0, 4);
         city.append(poco_n);

         it = YY.find(city);


Regards, Alex

 
0
 
LVL 39

Expert Comment

by:itsmeandnobodyelse
ID: 10848813
>> 20 points is not going to get you far ...

I learned from one of your previous questions that could not give more points as you have no more left. I suppose, you know that you could get more points if you spend some money to EE.. Also, you already spend a lot of points not getting a final solution to your task. The reason for this is your input files that always are changing from question to question and most of your problems you only got because your code doesn't reflect these changes. If you had given us a good spec, two input file definitions that would hold longer than a day and say 300 points some weeks before, you would have now a better solution and still points left.

Regards, Alex

BTW, if you would post here a final spec, i would show you a much better coding than that you have til now. And i don't need more points... ;-)

 
0
 
LVL 6

Expert Comment

by:Mafalda
ID: 11078596
Give the points to  itsmeandnobodyelse
0

Featured Post

Ransomware: The New Cyber Threat & How to Stop It

This infographic explains ransomware, type of malware that blocks access to your files or your systems and holds them hostage until a ransom is paid. It also examines the different types of ransomware and explains what you can do to thwart this sinister online threat.  

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Errors will happen. It is a fact of life for the programmer. How and when errors are detected have a great impact on quality and cost of a product. It is better to detect errors at compile time, when possible and practical. Errors that make their wa…
Many modern programming languages support the concept of a property -- a class member that combines characteristics of both a data member and a method.  These are sometimes called "smart fields" because you can add logic that is applied automaticall…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question