asked on

Need Help with Nested loops in T-SQL

I am trying to create an sp that uses nested loops to kill all user connections to a DB and then run DBCC Checkdb. I have tried to use the Maintenance plans in SQL server to do this but it keeps erroring out because it cannot put the db in single user mode. So I am trying to script out what it can't do. I do not want to use cursors for this issue as I know they are performance killers, but I am thinking I might not have another option as I cannot get the loop to go to the next record in my list on either loop. What I want to do is start the outer loop for the actual DB's themselves, then run the inner loop that kills the users connection.Once the connections are all done, put the db in single user mode, run checkDB, take out of single user mode and move to the next db to start the whole process over until all db's are done. I plan on running this script once a week on the weekend at 3 a.m.to make sure everything is in order with my systems. Below is my code...

--Declare All Your Variables
Declare @Loop int
Declare @Loop2 int
Declare @LoopCount int
Declare @LoopCount2 int
Declare @KillSpid varchar(500)
Declare @Spid int
Declare @DbName varchar(100)
Declare @IndexLine varchar(500)
Declare @IndexLine2 varchar(500)
Declare @IndexLine3 varchar(500)

--Set Variables if need to
Set @Loop = 0
Set @Loop2 = 0

--Create table for all DBNames
Create Table #DBNames
      (DBName varchar(50))
Insert into #DBNames
      SELECT CATALOG_NAME FROM INFORMATION_SCHEMA.SCHEMATA
      where CATALOG_NAME != 'master'
      and CATALOG_NAME != 'msdb'
      and CATALOG_NAME != 'tempdb'
      and CATALOG_NAME != 'model'

--Create table for SPID's
create table #KillUsers
(      spid int,
      status varchar( 20),
      login varchar( 40),
      hostname varchar( 40),
      blkby char( 5),
      dbname varchar( 40),
      command varchar( 500),
      cputime int,
      diskio int,
      lastbatch varchar( 20),
      programname varchar( 80),
      spid2 int
)

--Populate Variables
Select @LoopCount = count(DBName) from #DBNames
Print @LoopCount

--Begin Your Loops
While (@Loop < @LoopCount)
--While exists(select DBName from #DBNames)
      Begin
      --Insert into the #KillUsers temp
      Insert #KillUsers
            Exec sp_who2

      --Delete Admins from the temp table so their connections are not dropped
      Delete from #KillUsers
      --select spid, login, dbName from #KillUsers
      where login ='sa'

      Select @LoopCount2 = count(spid) from #KillUsers
      --Print @LoopCount2
      Select @DBName = DBName from #DBNames

      Print 'Inner Loop Start'
      While (@Loop2<@LoopCount2)
      --While exists(select spid from #KillUsers)
            Begin
              Select @spid = spid from #KillUsers
              --Print @spid

              Select @killSpid = 'kill ' + cast( @spid as varchar(10))
              Exec(@killSpid)
              Print 'SPID=' + @killSpid

              set @Loop2=@Loop2 + 1
              Print @Loop2
            End
      Print 'Inner Loop End'
      --Clear out #KillUsers temp table
      Truncate table #KillUsers

      --Start Outer Loop Processing - set to single user mode
      Print '---------------------------' + @DbName + ' DBCC Job Beginnning--------------------------------'
      Set @IndexLine = 'sp_dboption [' + @DbName + '], ''single user'', True'
      Exec (@IndexLine)
      Print @IndexLine

      Set @IndexLine2 = 'DBCC CheckDB (''' + @DbName + ''', REPAIR_REBUILD)'
      Exec (@IndexLine2)
      Print @IndexLine2

      Set @IndexLine3 = 'sp_dboption [' + @DbName + '], ''single user'', False'
      Exec (@IndexLine3)
      Print @IndexLine3
      Print '---------------------------' + @DbName + ' DBCC Job Ending--------------------------------'
      Print char(10)

      set @Loop=@Loop + 1
      End

--Drop Temp Tables
drop table #KillUsers
drop table #DBNames

arbert

Why make it so complicated--this will kill all connections and set the DB to single_user

use master
go
Alter database yourdbname set single_user with rollback immediate

arbert

To change it back

Use Master
go
alter database yourdbname set multi_user with rollback immediate

frankBlank

ASKER

But don't you have to set to single user to run DBCC CheckDB?

arbert

That's what the above does..Here's the entire script:

use master
go
ALTER DATABASE yourdatabasename set SINGLE_USER with rollback immediate --note the single_user option
go
use yourdatabasename
go
DBCC checkdb (yourdatabasename)

frankBlank

ASKER

Then I can run just the one loop with the above code as it will accomplish what I have been trying to do...correct?

arbert

You don't need to loop through anything--what you were doing above is looping through and killing all connections--that ALTER DATABASE statement rollsback all connections and puts the database in single user mode. The above post of mine replaces all your loops....

frankBlank

ASKER

Okay...then how would I go about running this for all my databases, or is something like that not recommended? I understand I have the potential to kill the connections, which is not necessarily a good thing, but I want to make sure I am doing the right things so my systems are as optimized as they can be.

ASKER CERTIFIED SOLUTION

arbert

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

frankBlank

ASKER

Okay..that makes alot more sense. So much easier also...I appreciate your help on this issue. I am the only DBA at my company so it is nice to be able to learn from an expert. Thank you again.