Solved

Logic Error

Posted on 2004-04-24
5
202 Views
Last Modified: 2010-03-31
I think I have a logic error in here but I can't figure out what it is, anyone have a clue?

The method is to sort an array of double values.
  /** The method for sorting the numbers */
  static void selectionSort(double[] list) {
    for (int i = list.length - 2; i >= 1; i--) {
      // Find the maximum in the list[0..i]
      double currentMax = list[0];
      int currentMaxIndex = 0;

      for (int j = 1; j <= i; j++) {
        if (currentMax < list[j]) {
          currentMax = list[j];
          currentMaxIndex = j;
        }
      }

      // Swap list[i] with list[currentMaxIndex] if necessary;
      if (currentMaxIndex != i) {
        list[currentMaxIndex] = list[i];
        list[i] = currentMax;
      }
    }
  }
}
0
Comment
Question by:Job4Suprmn
5 Comments
 
LVL 92

Accepted Solution

by:
objects earned 0 total points
ID: 10909801
>  list.length - 2

at 1st glance it would appear that should be  list.length - 1
0
 
LVL 30

Assisted Solution

by:GrandSchtroumpf
GrandSchtroumpf earned 25 total points
ID: 10909830
And your swap needs to be inside the for loop:

  static void selectionSort(double[] list) {
    for (int i = list.length - 1; i >= 1; i--) {
      // Find the maximum in the list[0..i]
      double currentMax = list[0];
      int currentMaxIndex = 0;

      for (int j = 1; j <= i; j++) {
        if (currentMax < list[j]) {
          currentMax = list[j];
          currentMaxIndex = j;
        }

        // Swap list[i] with list[currentMaxIndex] if necessary;
        if (currentMaxIndex != i) {
          list[currentMaxIndex] = list[i];
          list[i] = currentMax;
        }
      }
    }
  }
0
 
LVL 23

Expert Comment

by:rama_krishna580
ID: 10911076
try this program logic...seudo code..

void sortArray()
    {
        for(i=0; i<MAX; i++)
        {
            for(j=i+1;j<MAX;j++)
            {
                sort(number[i],number[j]);

                number[i]=a;
                number[j]=b;
            }
        }
    }

void shuffle()
    {
        for(i=0; i<MAX; i++)
        {
            j=(int)(Math.random()*MAX);

            if(i!=j)
            {
                int temp=number[i];
                number[i]=number[j];
                number[j]=temp;
            }
        }
    }


R.K

0
 
LVL 30

Assisted Solution

by:Mayank S
Mayank S earned 25 total points
ID: 10911219
>>  sort(number[i],number[j]);

BTW, where is this method in your code?

>> for(i=0; i<MAX; i++)

could be:

for ( i = 0 ; i < MAX - 1 ; i ++ )

Also, Job4Suprmn, your method is called selectionSort () but it doesn't actually implement selection-sort. The correct algo would be:

for ( int i = 0 ; i < array.length - 1 ; i ++ )
  for ( int j = i + 1 ; j < array.length ; j ++ )
    if ( array[i] > array[j] )
      // swap them
0
 
LVL 30

Expert Comment

by:GrandSchtroumpf
ID: 10913833
:°)
0

Featured Post

Courses: Start Training Online With Pros, Today

Brush up on the basics or master the advanced techniques required to earn essential industry certifications, with Courses. Enroll in a course and start learning today. Training topics range from Android App Dev to the Xen Virtualization Platform.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Java had always been an easily readable and understandable language.  Some relatively recent changes in the language seem to be changing this pretty fast, and anyone that had not seen any Java code for the last 5 years will possibly have issues unde…
Java functions are among the best things for programmers to work with as Java sites can be very easy to read and prepare. Java especially simplifies many processes in the coding industry as it helps integrate many forms of technology and different d…
Viewers will learn about if statements in Java and their use The if statement: The condition required to create an if statement: Variations of if statements: An example using if statements:
This video teaches viewers about errors in exception handling.

813 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now