[2 days left] What’s wrong with your cloud strategy? Learn why multicloud solutions matter with Nimble Storage.Register Now

x
?
Solved

Logic Error

Posted on 2004-04-24
5
Medium Priority
?
209 Views
Last Modified: 2010-03-31
I think I have a logic error in here but I can't figure out what it is, anyone have a clue?

The method is to sort an array of double values.
  /** The method for sorting the numbers */
  static void selectionSort(double[] list) {
    for (int i = list.length - 2; i >= 1; i--) {
      // Find the maximum in the list[0..i]
      double currentMax = list[0];
      int currentMaxIndex = 0;

      for (int j = 1; j <= i; j++) {
        if (currentMax < list[j]) {
          currentMax = list[j];
          currentMaxIndex = j;
        }
      }

      // Swap list[i] with list[currentMaxIndex] if necessary;
      if (currentMaxIndex != i) {
        list[currentMaxIndex] = list[i];
        list[i] = currentMax;
      }
    }
  }
}
0
Comment
Question by:Job4Suprmn
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
5 Comments
 
LVL 92

Accepted Solution

by:
objects earned 0 total points
ID: 10909801
>  list.length - 2

at 1st glance it would appear that should be  list.length - 1
0
 
LVL 30

Assisted Solution

by:GrandSchtroumpf
GrandSchtroumpf earned 75 total points
ID: 10909830
And your swap needs to be inside the for loop:

  static void selectionSort(double[] list) {
    for (int i = list.length - 1; i >= 1; i--) {
      // Find the maximum in the list[0..i]
      double currentMax = list[0];
      int currentMaxIndex = 0;

      for (int j = 1; j <= i; j++) {
        if (currentMax < list[j]) {
          currentMax = list[j];
          currentMaxIndex = j;
        }

        // Swap list[i] with list[currentMaxIndex] if necessary;
        if (currentMaxIndex != i) {
          list[currentMaxIndex] = list[i];
          list[i] = currentMax;
        }
      }
    }
  }
0
 
LVL 23

Expert Comment

by:rama_krishna580
ID: 10911076
try this program logic...seudo code..

void sortArray()
    {
        for(i=0; i<MAX; i++)
        {
            for(j=i+1;j<MAX;j++)
            {
                sort(number[i],number[j]);

                number[i]=a;
                number[j]=b;
            }
        }
    }

void shuffle()
    {
        for(i=0; i<MAX; i++)
        {
            j=(int)(Math.random()*MAX);

            if(i!=j)
            {
                int temp=number[i];
                number[i]=number[j];
                number[j]=temp;
            }
        }
    }


R.K

0
 
LVL 30

Assisted Solution

by:Mayank S
Mayank S earned 75 total points
ID: 10911219
>>  sort(number[i],number[j]);

BTW, where is this method in your code?

>> for(i=0; i<MAX; i++)

could be:

for ( i = 0 ; i < MAX - 1 ; i ++ )

Also, Job4Suprmn, your method is called selectionSort () but it doesn't actually implement selection-sort. The correct algo would be:

for ( int i = 0 ; i < array.length - 1 ; i ++ )
  for ( int j = i + 1 ; j < array.length ; j ++ )
    if ( array[i] > array[j] )
      // swap them
0
 
LVL 30

Expert Comment

by:GrandSchtroumpf
ID: 10913833
:°)
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

An old method to applying the Singleton pattern in your Java code is to check if a static instance, defined in the same class that needs to be instantiated once and only once, is null and then create a new instance; otherwise, the pre-existing insta…
Introduction This article is the last of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers our test design approach and then goes through a simple test case example, how …
The viewer will learn how to implement Singleton Design Pattern in Java.
This tutorial explains how to use the VisualVM tool for the Java platform application. This video goes into detail on the Threads, Sampler, and Profiler tabs.
Suggested Courses

656 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question