[Last Call] Learn about multicloud storage options and how to improve your company's cloud strategy. Register Now

x
Solved

Posted on 2004-04-25
Medium Priority
336 Views
Sorry for posting in this in the wrong forum before...

Hi,

I've succesfully created a Queue with a singly linked list and have no problem with writing a function to print out the result in order, but I need to print out the list in reverse order, preferably recursively.  Here is my code.  Thanks in advance.

struct Node{
int key;
Node *next;
};

void printInReverse(Node * Head);   //function prototype to print in reverse

int main(){
int x;  //variable displaying dequeue value

for (int i =1; i < 10 ; i ++){   //loop to populate enqueue

Node * newPtr = new Node;
newPtr->key = i;
newPtr->next = NULL;

{
((header == 0) && (back == 0))
newPtr = 0;
}

{
back->next = newPtr;
back = newPtr;
newPtr = 0;
}
}
// ******END list population*********

// ******BEGIN dequeue *********

Node *tmpPtr = new Node;

header = back = 0;  //Queue is empty

x = tmpPtr->key;
tmpPtr = 0;

// ******END dequeue function psuedocode *********

//more testing ..................................
cout << x << "= int x" << endl << endl;
//END testing ...................................

*/

printInReverse(header);   // call function to print list in reverse

system("pause");
return 0;
}

// ******BEGIN function to print in reverse*********
{
cout << "List is empty." << endl;
}
//int count = 0;
Node *printPtr = new Node;

while(printPtr != 0)
{

cout << printPtr->key << endl;
printPtr = printPtr->next; //advance pointer to next location in list...
}
}

// ******END function to print in reverse*********
0
Question by:r3r
[X]
###### Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

• Help others & share knowledge
• Earn cash & points
• 3
• 2

LVL 5

Accepted Solution

dennis_george earned 2000 total points
ID: 10915620
Hi,

You are simply printing the data.... you should recursion

I think the following will do it for you..

{
if ( Head == NULL )
{
return ;
} else {
}

}

Dennis
0

Author Comment

ID: 10915704
Thanks man, that's awesome.  Works great.  One more question...
Can you explain the last line..

specifically the " %d " part.  The Head->key argument is obvious.  I'm really new to this stuff (like you didn't know that already!!)

Thanks again.. you get 500 big ones!
0

LVL 5

Expert Comment

ID: 10915716
I think there is many programatic and logical flaw in your code.... I corrected those ... please read the comments I have written in between the code.....

Note :: Never never jump into coding before you design what you want to do.... First take a pen and paper draw diagrams and/or rough algo so that you are clear what and how will you acheive your goal.....

e.g.

Now you want to print it reverse way.....
So check how will you do.... to print it reverse First you have to go at the end then go back....
So devise a method that how will you go at the end and also how will you come back......

Making a software or a program is not how you code but rather how you design and how you provide the solution.

struct Node{
int key;
Node *next;
};

void printInReverse(Node * Head);   //function prototype to print in reverse

int main()
{
//  Node *header = new Node; // It should not be assigned memory at this stage
Node *back = NULL ;

//  int x;  //variable displaying dequeue value

for (int i = 1; i < 10 ; i ++){   //loop to populate enqueue

Node * newPtr = new Node;
newPtr->key = i;
newPtr->next = NULL;

} else {
back->next = newPtr;
back = newPtr;
newPtr = NULL;
}
}

// ******END list population*********

// ******BEGIN dequeue *********

//  Node *tmpPtr = new Node;  // Never Do this :: Here you are allocating memory for tmpPtr
// And Hence earlier memory allocated for tmpPtr is lost...
// i.e you cannot free that memory (Memory Leak)

//   Node *tmpPtr = header ;

//       header = back = 0;  //Queue is empty

//     x = tmpPtr->key;
//     tmpPtr = 0;

// ******END dequeue function psuedocode *********

//more testing ..................................
//     cout << x << "= int x" << endl << endl;
//END testing ...................................

printInReverse(header);   // call function to print list in reverse
printf("\n") ;

system("pause") ;

return 0;
}

// ******BEGIN function to print in reverse*********

{
if ( Head == NULL )
{
return ;
} else {
}

}

Dennis
0

LVL 5

Expert Comment

ID: 10915731
Hi,

is similar to

printf is a function defined in stdio.h // used in C
and cout is used in c++ // defined in iostream.h

Dennis
0

Author Comment

ID: 10915775
Thanks again...some of the code was preformated and I couldn't change it, but I don't doubt there is a lot of sloppy logic going on...  I'll study your notes and corrections.  And yes, I have been having problems with memory leaks as well.
0

LVL 12

Expert Comment

ID: 10916296
Hi r3r,
> print out the list in reverse order, preferably recursively
Smells like what one would do in functional programming :-)

Be aware that the length of a list you can print this way is very limited, since your recursive function needs stack for each recursion.
recursion.

Cheers,
Stefan
0

## Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction This article is a continuation of the C/C++ Visual Studio Express debugger series. Part 1 provided a quick start guide in using the debugger. Part 2 focused on additional topics in breakpoints. As your assignments become a little more â€¦
Many modern programming languages support the concept of a property -- a class member that combines characteristics of both a data member and a method.  These are sometimes called "smart fields" because you can add logic that is applied automaticallâ€¦
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.
###### Suggested Courses
Course of the Month13 days, 6 hours left to enroll