• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 279
  • Last Modified:

Another VBScript/ASP problem

Hi, I can't figure this out for the life of me, and I was wondering of anyone can help. I've got 2 functions; 1 to get a list of all orders for a certain part number, and the second to add the sum of the quantities of all orders on a certain day. Here is the code:

function GetShipmentsIn()
      dim shipIn
      redim shipIn(-1,1)
      set hubRS = createobject("adodb.recordset")
      hubRS.Open "SELECT dueDate, qty FROM ShipmentsIn WHERE partid="&partid&" AND BookedIn='NO'", hubcon
      do while not hubRS.EOF
            size = ubound(shipIn)
            if size = -1 then
                  redim shipIn(size+1, 1)
            else
                  redim preserve shipIn(size+1, 1)
            end if
            shipIn(ubound(shipIn), 0) = hubRS(0)
            shipIn(ubound(shipIn), 1) = hubRS(1)
            'Response.Write(shipIn(ubound(shipIn), 0))
            hubRS.MoveNext
      loop
      set hubRS = nothing
      GetShipmentsIn = shipIn
end function

function GetTodaysShipmentsIn(theDate)
      theDate = ReverseDate(theDate)
      count = 0
      for i=0 to ubound(shipments_in)
            if shipments_in(ubound(shipments_in), 0) = theDate then
                  Response.Write("adding: "&shipments_in(ubound(shipments_in), 1)&"<br />")
                  count = count + shipments_in(ubound(shipments_in), 1)
            end if
      next
      GetTodaysShipmentsIn = count
end function

Now, this works fine (i think) when the methods are ran just the once i.e., 'arr = GetShipmentsIn()' followed by 'tot = GetTodaysShipmentsIn(now)', but what I ideally want is to put the call to the second function in a for loop, which will calculate the sum of all the orders for each day of the week. When I put this call in a for loop, the browser times out. I could understand it if it was working with masses of data, but there are only 2 records in the database so it can't be pure worload that's timing-out the brower, can it?
Any suggestions welcome,
Cheers!
Darren.
0
led_zephrylin
Asked:
led_zephrylin
  • 3
  • 3
  • 2
2 Solutions
 
dwaldnerCommented:
I noticed that you didn't close HubRS...whenever I forget to close my recordset, it ALWAYS takes forever to execute....

Before your line:

set hubRS = nothing


Type this in

hubRS.Close

Cheers,

D
0
 
GaryCommented:
Your first function could just become this

function GetShipmentsIn()
     set hubRS = createobject("adodb.recordset")
     hubRS.Open "SELECT dueDate, qty FROM ShipmentsIn ....
     GetShipmentsIn=hubRS.GetRows
     hubRS.Close
     set hubRS = nothing
end function

Then your shipin array contains all the data, much faster and cleaner.
0
 
joeposter649Commented:
Shouldn't you be passing the array to GetTodaysShipmentsIn()?
0
The new generation of project management tools

With monday.com’s project management tool, you can see what everyone on your team is working in a single glance. Its intuitive dashboards are customizable, so you can create systems that work for you.

 
dwaldnerCommented:
Also, if I might make a recommendation...instead of rediming to get the size of the array, just use the hubRS.RecordCount to get the size of the recordset, then declare your array based on that size....just an idea to speed up that code...
0
 
GaryCommented:
... that should be...
GetShipmentsIn array contains all the records
0
 
GaryCommented:
Also rather than running thru the recordset you could just do
select sum(fieldname) from tablename ...
0
 
joeposter649Commented:
@dwaldner
I was thinking that too but RecordCount isn't available some (forward only) cursors.
0
 
dwaldnerCommented:
Then do this:

hubRS.Open "SELECT dueDate, qty FROM ShipmentsIn WHERE partid="&partid&" AND BookedIn='NO'", hubcon, 3, 3

That will change your pointer to the appropriate type to accomplish this...
0

Featured Post

Never miss a deadline with monday.com

The revolutionary project management tool is here!   Plan visually with a single glance and make sure your projects get done.

  • 3
  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now