Solved

Getting a random sign

Posted on 2004-08-03
10
485 Views
Last Modified: 2006-11-17
Hi all,

I want to get a randomly generated binary choice:  either -1 or 1.  This function does it, but is there is a 'nicer' way?

  private int getRandomSign() {
    if (Math.random() <= 0.5) return -1;
      else return 1;
    }
  }
0
Comment
Question by:Dawkins
  • 3
  • 2
  • 2
  • +2
10 Comments
 
LVL 14

Assisted Solution

by:sudhakar_koundinya
sudhakar_koundinya earned 25 total points
ID: 11706737
That is the nicer way :)
0
 
LVL 35

Expert Comment

by:girionis
ID: 11707086
Can you define "nicer"? Your code looks fine.
0
 
LVL 35

Accepted Solution

by:
girionis earned 25 total points
ID: 11707122
Maybe you could do

 private int getRandomSign() {
    if (Math.random() < 0.5) return -1;
      else return 1;
    }
  }

since it can return a value equal to zero but never one.
0
Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

 
LVL 14

Expert Comment

by:sudhakar_koundinya
ID: 11707291
I haven't understand the difference between if (Math.random() < 0.5) return -1; and if (Math.random() <= 0.5) return -1;

both results gives the value less than one only.

Regards
Sudhakar
0
 

Author Comment

by:Dawkins
ID: 11707310
>>>  Maybe you could do...

Good point, it should be < rather than <=. I'll change that

>>> Can you define "nicer"? Your code looks fine.

well basically I am teaching myself how to program in Java and know no Java programers in real life so have no one to ask "is this completely ridiculous", so I come here instead :)  By nicer I mean "more elegant, simpler, less code, there's already a java library function that does that" etc

Seems like I've already found the best way so I'll give it another 30 minutes to make sure and then give you two the points.
0
 
LVL 6

Expert Comment

by:rpnman
ID: 11707336

Here's another approach that may be closer to what you want:

private int getRandomSigh() {
    return (int) (Math.signum(0.5-Math.random())) ;
}

An additional note:  using "<= 0.5" favors -1  VERY slightly  since Math.random() returns values between 0 and .999...
0
 
LVL 6

Expert Comment

by:rpnman
ID: 11707408
There's a problem with my posted solution: there's a very slight chance it will return 0. If you can't live with that, here's an amendment:


private int getRandomSign() {
    int sign = (int) (Math.signum(0.5-Math.random())) ;
    return sign = 0 ? 1 : sign ;
}
0
 
LVL 15

Expert Comment

by:JakobA
ID: 11707712
nice & short:

private int getRandomSign() {
    return (Math.random()<0.5) ? 1 : -1;                           // ?: operator same as in C
}

regards JakobA
0
 

Author Comment

by:Dawkins
ID: 11708880
Thanks everyone, I'll keep it as I originally had it but put < 0.5 instead to ensure the split is exactly 50/50
0
 
LVL 35

Expert Comment

by:girionis
ID: 11712677
:)
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction This article is the second of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers the basic installation and configuration of the test automation tools used by…
Introduction This article is the last of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article covers our test design approach and then goes through a simple test case example, how …
Viewers will learn about arithmetic and Boolean expressions in Java and the logical operators used to create Boolean expressions. We will cover the symbols used for arithmetic expressions and define each logical operator and how to use them in Boole…
Viewers will learn how to properly install Eclipse with the necessary JDK, and will take a look at an introductory Java program. Download Eclipse installation zip file: Extract files from zip file: Download and install JDK 8: Open Eclipse and …

820 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question