Solved

Problem with MOD and Integer.

Posted on 2004-08-05
3
199 Views
Last Modified: 2010-08-05
Anyone have a solution to this problem..


Function Tform1.BuildTime(TimeVal: Longint): string;
Var
 BuildStr: String;
 RunTime: Longint;
 RSec,Rhours,Rmins,Rdays: Integer;
Begin
     BuildStr:='';
     RunTime:=TimeVal;
     RDays:=Trunc(RunTime/60/60/24) mod 24 ;
     If (Rdays>1) or (Rdays=0) Then
        BuildStr:=BuildStr+' '+IntToStr(Rdays)+' days, '
         else
        BuildStr:=BuildStr+' '+IntToStr(Rdays)+' day, ';
     RHours:=Trunc(RunTime/60/60) mod 24;
      If (RHours>1) or (RHours=0) Then
        BuildStr:=BuildStr+IntToStr(Rhours)+' Hours, '
         else
        BuildStr:=BuildStr+IntToStr(Rhours)+' Hour, ';
     RMins:=Trunc(RunTime/60) mod 60;
       If (RMins>1) or (RMins=0) Then
       BuildStr:=BuildStr+IntToStr(RMins)+' Minutes, '
        else
       BuildStr:=BuildStr+IntToStr(RMins)+' Minute, ';
    RSec:=Trunc(RunTime) Mod 60;
    If (RSec>1) or (RSec=0) Then
     BuildStr:=BuildStr+IntToStr(RSec)+' Seconds.'
       else
     BuildStr:=BuildStr+IntToStr(RSec)+' Second.';
 Result:=BuildStr;
End;

//some button
Begin
//this gets how long your machine has been running for from
//get tick count
  BuildStr:=BuildTime(Trunc(GetTickCount/1000));
  ShowMessage(BuildStr);
End;

Problem is, after 22 days or so, MOD fails and goes back to 0

try  60 * 60 * 24 * 30  //60 seconds * 60 minutes * 24 hours * 30 days

And the result should be 30 day, the routine screws up giving something like 4 days, anyone know how solve this?
0
Comment
Question by:tobjectpascal
3 Comments
 
LVL 12

Expert Comment

by:Ivanov_G
ID: 11725837
0
 
LVL 26

Assisted Solution

by:Russell Libby
Russell Libby earned 100 total points
ID: 11725864

Seems like RDays should be the following

RDays:=Trunc(RunTime / 60 / 60 / 24) ;

Where instead, you are dividing by 24 and then mod'ing by 24 (dividing will get the number of days, mod'ing will return the hours)

Regards,
Russell
0
 
LVL 12

Accepted Solution

by:
esoftbg earned 25 total points
ID: 11726264
as rllibby wrote above:

function  Tform1.BuildTime(TimeVal: Int64): string;
var
  BuildStr:      string;
  RunTime:       Int64;
  RSec,Rhours,
  Rmins,Rdays:   Int64;
begin
  BuildStr := '';
  RunTime := TimeVal;
  RDays := Trunc(RunTime/60/60/24);
  if (Rdays=1) then
    BuildStr := BuildStr+' '+IntToStr(Rdays)+' day, '
  else
    BuildStr := BuildStr+' '+IntToStr(Rdays)+' days, ';
  RHours := Trunc(RunTime/60/60) mod 24;
  if (RHours=1) then
    BuildStr := BuildStr+IntToStr(Rhours)+' Hour, '
  else
    BuildStr := BuildStr+IntToStr(Rhours)+' Hours, ';
  RMins := Trunc(RunTime/60) mod 60;
  if (RMins=1) then
    BuildStr := BuildStr+IntToStr(RMins)+' Minute, '
  else
    BuildStr := BuildStr+IntToStr(RMins)+' Minutes, ';
  RSec := Trunc(RunTime/1) mod 60;
  if (RSec=1) then
    BuildStr := BuildStr+IntToStr(RSec)+' Second.'
  else
    BuildStr := BuildStr+IntToStr(RSec)+' Seconds.';
  Result := BuildStr;
end;

The poits are for rllibby, I just wrote it as code
0

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
code issue 8 153
Downloading email attachments 2 79
Tembedded WB animatid gifs not animated on some pcs 2 83
Drag & Drop... Data from one grid to another 2 40
The uses clause is one of those things that just tends to grow and grow. Most of the time this is in the main form, as it's from this form that all others are called. If you have a big application (including many forms), the uses clause in the in…
Introduction I have seen many questions in this Delphi topic area where queries in threads are needed or suggested. I know bumped into a similar need. This article will address some of the concepts when dealing with a multithreaded delphi database…
I've attached the XLSM Excel spreadsheet I used in the video and also text files containing the macros used below. https://filedb.experts-exchange.com/incoming/2017/03_w12/1151775/Permutations.txt https://filedb.experts-exchange.com/incoming/201…

809 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question