Solved

class rational

Posted on 2004-08-07
4
558 Views
Last Modified: 2012-05-05
Can you comment on the effectiveness of this code?  I tried to create a class for rational numbers with overloaded operators which apply to my rational type class?  This is a homework assignment, but I wanted to make sure it looked ok.

class Rational {
public:
     Rational(int t = 0, int n = 1);

     friend Rational operator+ (const Rational& lVal, const Rational& rVal);
     friend Rational operator- (const Rational& lVal, const Rational& rVal);
     friend Rational operator* (const Rational& lVal, const Rational& rVal);
     friend Rational operator/ (const Rational& lVal, const Rational& rVal);

     Rational& operator+= (const Rational& rVal);
     Rational& operator-= (const Rational& rVal);
     Rational& operator*= (const Rational& rVal);
     Rational& operator/= (const Rational& rVal);

     
     friend int operator<  (const Rational& lVal, const Rational& rVal);
     friend int operator<= (const Rational& lVal, const Rational& rVal);
     friend int operator== (const Rational& lVal, const Rational& rVal);
     friend int operator!= (const Rational& lVal, const Rational& rVal);
     friend int operator>= (const Rational& lVal, const Rational& rVal);
     friend int operator>  (const Rational& lVal, const Rational& rVal);

     friend ostream& operator<< (ostream& os, const Rational& rat);
     friend istream& operator>> (istream& is, Rational& rat);


private:
     int teller, number;

     void reduce();
     int  number(int, int);  
};


//Constructors

Rational::Rational(int t, int n): teller(t), number(n) {
     reduce();
}

Rational Rational::operator -() const {
     return Rational(-teller, number);
}


// operator overloading

Rational operator+ (const Rational& lVal, const Rational& rVal) {
     Rational result;

     result.teller = lVal.teller * rVal.number + lVal.number * rVal.teller;
     result.number = lVal.number * rVal.number;

     result.reduce();
     return result;
}

Rational operator- (const Rational& lVal, const Rational& rVal) {
     Rational result;
     result = lVal + -rVal;

     result.reduce();
     return result;
}

Rational operator* (const Rational& lVal, const Rational& rVal) {
     Rational result;
     result.teller = lVal.teller * rVal.teller;
     result.number = lVal.number * rVal.number;

     result.reduce();
     return result;
}

Rational operator/ (const Rational& lVal, const Rational& rVal) {
     Rational result;
     result.teller = lVal.teller * rVal.number;
     result.number = lVal.number * rVal.teller;
     result.reduce();
     return result;
}


Rational& Rational::operator+= (const Rational& rVal) {
     teller = teller * rVal.number + number * rVal.teller;
     number = number * rVal.number;

     reduce();
     return *this;
}

Rational& Rational::operator-= (const Rational& rVal) {
     this->operator+=(-rVal);
     reduce();
     return *this;
}

Rational& Rational::operator*= (const Rational& rVal) {
     teller = teller * rVal.teller;
     number = number * rVal.number;

     reduce();
     return *this;
}


Rational& Rational::operator/= (const Rational& rVal) {
     teller = teller * rVal.number;
     number = number * rVal.teller;

     reduce();
     return *this;
}



int operator<  (const Rational& lVal, const Rational& rVal) {
     return(lVal.toDouble() < rVal.toDouble());
}

int operator<= (const Rational& lVal, const Rational& rVal) {
     return(lVal < rVal || lVal == rVal);
}

int operator== (const Rational& lVal, const Rational& rVal) {
     return lVal.teller * rVal.number == lVal.number * rVal.teller;
}

int operator!= (const Rational& lVal, const Rational& rVal) {
     return !(lVal == rVal);
}

int operator>= (const Rational& lVal, const Rational& rVal) {
     return(lVal > rVal || lVal == rVal);
}

int operator>  (const Rational& lVal, const Rational& rVal) {
     return(lVal.toDouble() > rVal.toDouble());
}



istream& operator>> (istream& is, Rational& rat) {
     int t, n;
     char deel;
     is >> t >> deel >> n;
     rat = Rational(t,n);
     return is;
}


int main() {
     clrscr();
     Rational b1;
     Rational b2;

     cout << "Input the number in the form (a/b): ";
     cin >> b1 >> b2;

 // Test for +, -, *, /
     cout << b1 << " + " << b2 << " = " << b1 + b2 << endl;
     cout << b1 << " - " << b2 << " = " << b1 - b2 << endl;
     cout << b1 << " * " << b2 << " = " << b1 * b2 << endl;
     cout << b1 << " / " << b2 << " = " << b1 / b2 << endl;


// test program for overloaded operators
     cout << b1 << " <  " << b2;
     (b1 <  b2) ? cout << " [X]" << endl : cout << " [ ]" << endl;

     cout << b1 << " <= " << b2;
     (b1 <= b2) ? cout << " [X]" << endl << endl : cout << " [ ]" << endl << endl;

     cout << b1 << " == " << b2;
     (b1 == b2) ? cout << " [X]" << endl : cout << " [ ]" << endl;

     cout << b1 << " != " << b2;
     (b1 != b2) ? cout << " [X]" << endl << endl : cout << " [ ]" << endl << endl;

     cout << b1 << " >= " << b2;
     (b1 >= b2) ? cout << " [X]" << endl : cout << " [ ]" << endl;

     cout << b1 << " >  " << b2;
     (b1 >  b2) ? cout << " [X]" << endl : cout << " [ ]" << endl << endl;

     getch();
     return 0;
}
0
Comment
Question by:rumi54
  • 2
  • 2
4 Comments
 
LVL 55

Expert Comment

by:Jaime Olivares
ID: 11743145
Everything seems to be ok, although I don't find Rational::reduce() implementation.
0
 

Author Comment

by:rumi54
ID: 11743155
The GCF function...
0
 
LVL 55

Accepted Solution

by:
Jaime Olivares earned 500 total points
ID: 11743264
LOL. Yes I know what means but maybe you can optimize something there.
Your comparison (<, >, ==, etc.) operators could be "inline" to enhance performance.
Your division operators have not "divide by zero" exception management.
0
 

Author Comment

by:rumi54
ID: 11743283
I figured you know what it means.  :)  I thought I left it out completely.  Thanks.  
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Templates For Beginners Or How To Encourage The Compiler To Work For You Introduction This tutorial is targeted at the reader who is, perhaps, familiar with the basics of C++ but would prefer a little slower introduction to the more ad…
This article shows you how to optimize memory allocations in C++ using placement new. Applicable especially to usecases dealing with creation of large number of objects. A brief on problem: Lets take example problem for simplicity: - I have a G…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

18 Experts available now in Live!

Get 1:1 Help Now