Input/Output / Array

what is not working?  There's a lot of code there =p
What is the format of the currency file?  The way you have it, it would need to be a whitespace delimited file containing just a bunch of floating point numbers like
1.2
1.3
0.5

or
1.2 1.3 0.5


does the program compile?  does it give wrong results?

one change I would make, the function that does the conversion both prints the conversion and returns it.  It might be more propper to just return the value.  This makes the function real simple:
 return CURRENCIES[selectionNumbers]*ammount;

then have main() print out the value.


You could also make a const char* array containing the names of the currencies.
const char*  currencyNames[] = {"Arginitinian Pesos", "Canadian Dollars" /* continue the list */ };

this makes your "build menu" section into an easy loop:
for (i = 0; i < 5; i++)
  printf ("Press [%i] for %s.\n", i, currencyNames[i]);

much shorter, and you can easily add more countries.

You can also use the same array to print out the country name when showing the converted value.  This removes the need for the ugly switch statement.

Also,this code will read the last conversion value from the file twice.
>>
while(!feof(fmr))
       {
            fscanf(fmr, "%f", &CURRENCIES[i]); i++;
    }
<<

Change it to:

while(!fscanf(fmr, "%f", &CURRENCIES[i]))
       {
         i++;
       }

Ankuratvb & CmdrRickHunter, thank you very much for your assistance.

I made all the changes and the program does work with few errors --  my menu now displays with [0] for Argentina Pesos. When entering [0] for that selection, nothing happens. It will work if I enter 1 thru 4 but not when I enter [0].  Why is that? Do I have to change the initialization of int i? Another question, if I press q prior to running one conversion, the program starts an endless loop. I have to run one conversion before 'q' will work.  One last question, there is nothing being written to my output file? I am willing to award additional points for these questions...just tell me what I have to do.  Thanks again for your help. CmdrRickHunter, I used your idea of char *currencyNames to build the dynamic menu. I'm a little unsure of how to use it for the switch statements. I'm going to keep trying.

Thanks again

/contesa

If you're using an array for currencynames as well,it'll eliminate the need for the switch-case;

You can simply do something like:

      float fnCalculateConversion(float CURRENCIES[], char *currencynames[],float AMOUNT, int selectionNumbers)

    {
              /* declare variables */
              float conversion;
              conversion = CURRENCIES[selectionNumbers-1] * AMOUNT;
              printf("\nYour U.S. Dollars equal $%.2f %s\n\n",conversion,currencynames[selectionNumbers-1]);

    }

Since corresponding indices of the arrays currencies and their names would be for the same currency,you can directly index into the array to do the calc. and the printing without using switch-case or if-else.

Hi again...thank you again for all of your help...

I made the above changes. The program is running but there are some issues which I can't figure out. If I press a selection other than the ones listed, I get a repeated call for a selection number. When I tried using fprintf to output to my text file, the statement doesn't appear on the screen nor does it appear on my output file. I need suggestions on how to make it appear on my screen as well as my output file. By the way, although I wanted to change my switch statement--I can't--have to show all the concepts learned so far. So I have to leave it in...


#include <stdio.h>
#include <stdlib.h>

/*function prototyping*/
float fnCalculateConversion(float[],float, int);

/*main program starts here*/
int main(void)
{
     /*define variables*/
     char c;
     char *currencyNames[]={"Argentina_Pesos", "Canada_Dollars", "United_Kingdom_Pounds", "Hong_Kong_Dollars", "Japan_Yen"};
     FILE *fmr, *frt;
     int selectionNumbers;
     float CURRENCIES[5];
     float AMOUNT = 0.0;
     int i=0;
     
     /*open file for currency rates*/
     fmr = fopen("myrates.dat", "r");
     if (fmr == NULL)
     
     {
           printf("Can't open file for input\n");
           exit(1); /*exit program*/
     }
     
     /*open file for output*/
        frt = fopen("results.txt", "w");
      if (frt==NULL)
          {
               printf("Can't open file for output\n");
               exit(1); /*exit program*/
          }

     
           while(fscanf(fmr, "%f", &CURRENCIES[i])==1)
       {
         i++;
      }


     
     /*conversions equal to $1 US dollar respectively for argentina, canada,
     united kingdon, hong kong, japan*/
         
     /*program title*/
     printf("Welcome to the Currency Conversion Program\n");
     
     /*build menu*/
          printf("----------------------------------------\n\n");
     
          for (i = 0; i < 5; i++)
          printf ("Press [%i] for %s\n\n", i + 1, currencyNames[i]);


          Printf("Press [q] to Quit Program\n\n");
         
     do {
         /*ask for user input - currency to convert*/
         printf("Please enter selection number of currency to convert: ");
         scanf("%c", &selectionNumbers);
         if(selectionNumbers=='q') exit(0);
              else selectionNumbers-='0';
       
         } while (selectionNumbers >5 || selectionNumbers <1);

     {
          /*ask for user input - dollar amount*/
          printf("Enter dollar amount to convert:  ");
          scanf("%f", &AMOUNT);
     }          
 
          
          /*call function to calculate conversion*/    
          fnCalculateConversion(CURRENCIES, AMOUNT, selectionNumbers);
         
         

         
          printf("\nThank you for using the Currency Conversion Program\n");
          /*stop program */
         
         
         
          fclose(fmr);
          fclose(frt);
          getchar();
          return 0;
         
         
         

}
         
     /* function to calculate conversion depending on selection by user */
       float fnCalculateConversion(float CURRENCIES[], float AMOUNT, int selectionNumbers)
   {
               /* declare variables */
               float conversion;
               switch(selectionNumbers)
         
               {
                    /* switch-case statements */
                    case 1:
                         conversion = CURRENCIES[0] * AMOUNT;
                         printf("\nYour U.S. Dollars equal $%.2f Argentina Pesos\n\n",conversion);
                         break;
                   
                    case 2:
                         conversion = CURRENCIES[1] * AMOUNT;
                         printf("\nYour U.S. Dollars equal $%.2f Canada Dollars\n\n",conversion);
                         break;
                         
                    case 3:
                         conversion = CURRENCIES[2] * AMOUNT;
                         printf("\nYour U.S. Dollars equal $%.2f United Kingdom Pounds\n\n",conversion);
                         break;
                         
                    case 4:
                         conversion = CURRENCIES[3] * AMOUNT;
                         printf("\nYour U.S. Dollars equal $%.2f Hong Kong Dollars\n\n",conversion);
                         break;
                         
                    case 5:
                         conversion = CURRENCIES[4] * AMOUNT;
                         printf("\nYour U.S. Dollars equal $%.2f Japan Yen\n\n",conversion);
                         break;
                         

               }
               
               /* returns calculation to user */
               return conversion;
               
     
     
     }    


-------------------

Again, thank you for the help and explanations they have helped.

/contesa
       

Hi CmdrRickHunter,

Thank you again...I will give it another go.  And, by the way, I agree with you...if there's an easier way then why make it so hard for us--and I'm neither an expert or a professional!  LOL!!!

Thanks again...

One last question,

...........

fprintf(fresults, "\nThank you for using the Currency Conversion Program\n");
          printf("\nThank you for using the Currency Conversion Program\n");
         
.........

The above fprintf statement does work. However, what I need sent to the myresults file is the conversion statement. When I include the fprintf statement in the switch statements like so:

fprintf(fresults,"\nYour U.S. Dollars equal $%.2f Argentina Pesos\n\n",conversion);

it does not work because it doesn't recognize fresults as a variable. Why do I have to redeclare that variable? Thought I already declared it at the beginning of the program inside the main function. Does this mean that even though it's inside the main function, it is only local to that function? Or is it because I can't use fprintf inside switch statements. I have been researching switch statements and haven't come across an example using fprintf.

Since fresults is defined in main(),it is accessible in main() only.
If you want to write to the file in the function fncalculateconversion(),pass the FILE *object variable to the function.

e.g.
float fnCalculateConversion(float CURRENCIES[], float AMOUNT, int selectionNumbers,FILE *fresults)

and do :
fprintf(fresults,"\nYour U.S. Dollars equal $%.2f Argentina Pesos\n\n",conversion);

in this function.

You'd call this function as:

FILE *frt;
frt = fopen("results.txt", "w");
if (frt==NULL)
       {
            printf("Can't open file for output\n");
            exit(1); /*exit program*/
       }
.
.
.
fnCalculateConversion(CURRENCIES, AMOUNT, selectionNumbers,frt);
.
.
.
fclose(frt);

Another,not so good way to do this is to define the FILE *frt variable globally i.e.before main().Then,it'd be accessible to all functions.

I'm getting the following error:  line 98: bad type in function fnCalculateConversion
'float fnCalculateConversion(float CURRENCIES[], float AMOUNT, int selectionNumbers, FILE *fresults) { float conversion'
aborting compile

I've tried everything I know possible...which unfortunately is not much...I'm throwing up my hands.  I also noticed that if I enter an invalid number as my first input, it recognizes that its wrong and then repeats enter currency selection three times. Then I can't get it out of the loop--no matter what number I put in....but that's another matter....more importantly, I need to get the output to work.  

Once again, thank you for your instructions and suggestions.


......................
/*function prototyping*/
float fnCalculateConversion(float[],float, int, FILE);

 /*open file for output*/
        fresults = fopen("results.txt", "w");
     if (fresults==NULL)
         {
              printf("Can't open file for output\n");
              exit(1); /*exit program*/
         }


 /*call function to calculate conversion*/    
          fnCalculateConversion(CURRENCIES, AMOUNT, selectionNumbers, fresults);

/* function to calculate conversion depending on selection by user */
       float fnCalculateConversion(float CURRENCIES[], float AMOUNT, int selectionNumbers, FILE *fresults)
   {
               /* declare variables */
               float conversion;
               switch(selectionNumbers)
         
               {
..............