Solved

Adding a variable into a <a href> tag

Posted on 2004-08-18
9
7,883 Views
Last Modified: 2012-06-27
I am trying to modify a template. I want to add a link to an image that is generated by PHP. Currently the code is:  

<dl class="gallery"><dd><a href="http://www.sky2five.com/jpegged/index.php<?=$post_ID?>">

But it defaults to index.php...

Is the syntax the problem?

Thanks,
HT
0
Comment
Question by:htillberg
9 Comments
 
LVL 27

Accepted Solution

by:
Diablo84 earned 250 total points
Comment Utility
i would avoid using short tags personally in case you are ever in an environment where they are disabled, so try:

<dl class="gallery"><dd><a href="http://www.sky2five.com/jpegged/index.php<?php echo $post_ID; ?>">

and failing that do some checking to make sure the variable is set and its not empty, somewhere in your script:

<?php
if (!isset($post_ID)) {
 echo "post_ID variable is not set";
}
elseif (empty($post_ID)) {
 echo "post_ID variable is set but is an empty";
}
0
 
LVL 5

Expert Comment

by:darksinclair
Comment Utility
What are you trying to have it default too?

try this:

<a href="http://www.sky2five.com/jpegged/index.php?PostID=<?=$post_ID?>">

that will add a QueryString Variable "PostID" with the value of post_ID.

Not sure if that's what you want.. maybe some more clarification will help,

CHeers.
0
 
LVL 2

Expert Comment

by:nowaydown1
Comment Utility
Good day:

The problem is indeed in your syntax.  First, the script doesnt know that you are passing any data to it because you haven't defined a variable in the URL.  Without any html code, your url should look something like this:

http://www.sky2five.com/jpegged/index.php?post_id=5

You'll notice there that I added the question mark (which means that a single variable is getting ready to follow), then I added post_id=5.  post_id is just a variable name that I made up.  You can name it anything you like.  Then you see = and then the number 5.  The number 5 in this case, obviously represents your variable $post_ID in your script.  I just gave it a value in this case so you can see how it all fits together.

So in order to fix your script, you have to add a variable name to the url, and then pass the value.  I chose to use a full <?php ?> block here, for clarity, but it should work the same either way.

<?php

echo "<dl class=\"gallery\"><dd><a href=\"http://www.sky2five.com/jpegged/index.php?post_id=\"".$post_ID."\">Click here</a>";

?>

Now in your script (index.php) you will need to retrieve this value like this--

<?php

// index.php--
// Your code should already be here someplace--

$postID=$_GET['post_id'];
if(!isset($postID) || empty($postID)) {
      // Handle the error here--
} else {
     // Script continues--
}

?>

Please let me know if there is any other way that I could clarify this for you.   Hope it helps!  Have a wonderful day!

0
What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

 
LVL 1

Expert Comment

by:PatrickLucas
Comment Utility
Inorrect: <dl class="gallery"><dd><a href="http://www.sky2five.com/jpegged/index.php<?=$post_ID?>">

Correct: <dl class="gallery"><dd><a href="http://www.sky2five.com/jpegged/index.php?post_id=<? echo $post_ID; ?>">
0
 
LVL 1

Expert Comment

by:njava
Comment Utility
If your $post_ID = 1, then the URL looks like the one below that I posted. I actually went to your site, you pass a parameter to index.php and assign a number to it. So far, I noticed two parameters - cat and p. Try to modify the URL as I suggested. It worked on my server.

<?php
//just an example

      $post_ID=1;
?>


<dl class="gallery">
  <dd>
      <a href="http://www.sky2five.com/jpegged/index.php?cat=<?php print $post_ID?>">Click here</a>
0
 
LVL 9

Expert Comment

by:gruntar
Comment Utility
Here is "proper" way to do this. First we check whether variable is set or not, then if true we echo out ?post_ID=value, otherwise we don't do anything.

<dl class="gallery"><dd><a href="http://www.sky2five.com/jpegged/index.php<?php echo (isset($post_ID) ? '?post_ID=' . $post_ID : ''); ?>">

You must be careful with variable names because $post_ID is not the same as $post_id!!
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now