Javascript is not giving the correct output - problem with dates array

Posted on 2004-08-18
Last Modified: 2010-04-06

Probably need a second set of eyes to go over my code.

I am designing a vacation request form for my users. I have some javascript that accounts for holidays as well as weekends while calculating the number of days between two days.
I got most of this code functioning - however for some reason, my code is not reading the last array VacDays (list of holidays during the year) and taking them into account while doing the calculations for myTotal or RealTotal at the end.

Thus if I put start date = 02/13/2004 and end date = 02/17/2004 - it should be giving me two days between these two days instead of 3 as 02/16/2004 is listed as a holiday in the array VacDays. However its currently giving me 3 days - not sure where I am going wrong.

Please help!!


function CalcVacDays(FirstDay, LastDay){
var FirstDay;
var LastDay;

FirstDay = new Date(document.myForm._1_1_7_1.value);
LastDay = new Date(document.myForm._1_1_8_1.value);

var d1v = FirstDay.valueOf();
var d2v = LastDay.valueOf();
d1v= Math.ceil((((d1v/1000)/60)/60)/24);
d2v= Math.ceil((((d2v/1000)/60)/60)/24);
if (d2v>=d1v)
     var TotalDays = d2v-d2v+1;
     myTotal.value = TotalDays;
     var RealTotal = TotalDays;

// Starting loop to figure time

var startCount
var sdate = 0
var sDate = FirstDate.getDay()

for(startCount=0, startCount<days,startCount++)
          if ((sdate=5)||(sdate=6)) RealTotal--
          if (sdate=7) sdate=0

     var VacDays = new Array()
     VacDays[0]=new Date("01/01/2005")
     VacDays[1]=new Date("01/02/2005")
     VacDays[2]=new Date("02/16/2004")
     VacDays[3]=new Date("05/31/2004")
     VacDays[4]=new Date("07/05/2004")
     VacDays[5]=new Date("09/06/2004")
     VacDays[6]=new Date("11/25/2004")
     VacDays[7]=new Date("11/26/2004")
     VacDays[8]=new Date("12/24/2004")
     VacDays[9]=new Date("12/27/2004")
     VacDays[10]=new Date("12/28/2004")
     VacDays[11]=new Date("12/29/2004")
     VacDays[12]=new Date("12/31/2004")

     var hvalue
     for (startCount=0,startCount<=12,startCount++)
          if ((hvalue>=d2v) && (hvalue<=d1v))
          myTotal.value = RealTotal
document.write (RealTotal)


Question by:arunatata
  • 2
LVL 19

Accepted Solution

dakyd earned 200 total points
ID: 11844699
This section looks problematic:
for(startCount=0, startCount<days,startCount++)
          if ((sdate=5)||(sdate=6)) RealTotal--
          if (sdate=7) sdate=0

You need to change the commas to semi-colons in the for loop.  The second thing that's weird is that you don't define days anywhere.  Odds are, your script is treating days as 0.  I think you meant this:
for(startCount=0; startCount<TotalDays; startCount++)
          if ((sdate=5)||(sdate=6))
          if (sdate=7) sdate=0;

The second for loop also looks like it has a couple errors.  I think you want this:
     var hvalue;
     for (startCount=0;startCount<=12; startCount++)
          if ((hvalue>=d1v) && (hvalue<=d2v))
d2v is greater/after d1v, so you want a value that is between d1v and d2v.  The way you had it before was decrementing RealTotal only if hValue was less than d1v and greater than d2v, which shouldn't ever happen.

Regardless, hope that helps.

Author Comment

ID: 11845014
Thanks, that helped!!

LVL 19

Expert Comment

ID: 11845149
Sure thing, glad you got what you wanted.

Featured Post

Networking for the Cloud Era

Join Microsoft and Riverbed for a discussion and demonstration of enhancements to SteelConnect:
-One-click orchestration and cloud connectivity in Azure environments
-Tight integration of SD-WAN and WAN optimization capabilities
-Scalability and resiliency equal to a data center

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

It's sometimes a bit tricky to use date functions in Oracle BPEL. I'll explain quickly how you can add N days to the current date. In a BPEL process this can be useful, and you can adapt it to fit your needs. First of all, let's see how to add 1 …
Have you tried to learn about Unicode, UTF-8, and multibyte text encoding and all the articles are just too "academic" or too technical? This article aims to make the whole topic easy for just about anyone to understand.
Viewers will learn about basic arrays, how to declare them, and how to use them. Introduction and definition: Declare an array and cover the syntax of declaring them: Initialize every index in the created array: Example/Features of a basic arr…
The viewer will learn how to dynamically set the form action using jQuery.

821 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question