Your question, your audience. Choose who sees your identity—and your question—with question security.
Small app with GDI+ using massive memory resources
hi,
I have a form with not much on it.
the below code is simply drawing 5 lines on a pic box.
*** begin ***
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
Dim myPen As Pen = New Pen(staffColor, 1)
'staffline1
g.DrawLine(myPen, staffStartPosX, staffStartPosY + staffHeight * 2, Pic.Width - 10, staffStartPosY + staffHeight * 2)
'staffline2
g.DrawLine(myPen, staffStartPosX, staffStartPosY + staffHeight, Pic.Width - 10, staffStartPosY + staffHeight)
'staffline3
g.DrawLine(myPen, staffStartPosX, staffStartPosY, Pic.Width - 10, staffStartPosY)
'staffline4
g.DrawLine(myPen, staffStartPosX, staffStartPosY - staffHeight, Pic.Width - 10, staffStartPosY - staffHeight)
'staffline5
g.DrawLine(myPen, staffStartPosX, staffStartPosY - staffHeight * 2, Pic.Width - 10, staffStartPosY - staffHeight * 2)
Pic.Image = bit
g.Dispose()
*** end ***
Elsewhere on the form, I have a NumericUpDown control which automatically adusts the Staffheight variable from above which would increase the spacing in between the lines....
basically going from this:
________________________
________________________
to:
________________________
________________________
.....
If I adjust the spacing width, the memory for my program increases dramatically. I have had the very small app go from 50Mb of memory up to 500!!! mb of memory just by moving my mousewheel up and down while in the numericUpDown control. The memory will eventually readjust itself down to below 100, but that can take up to 30 seconds or so. Am I doing something wrong with my code? am I not cleaning up properly?
I know there is some kind of garbage collector that automatically cleans up destroyed objects, but it seems to only happen every few seconds, or not enough. I'm assuming the culprits that are filling up the memory are the bitmaps that are being created in the above routine simply because they aren't being destroyed fast enough by the automatic .net garbage collector.
thx.
I have a form with not much on it.
the below code is simply drawing 5 lines on a pic box.
*** begin ***
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
Dim myPen As Pen = New Pen(staffColor, 1)
'staffline1
g.DrawLine(myPen, staffStartPosX, staffStartPosY + staffHeight * 2, Pic.Width - 10, staffStartPosY + staffHeight * 2)
'staffline2
g.DrawLine(myPen, staffStartPosX, staffStartPosY + staffHeight, Pic.Width - 10, staffStartPosY + staffHeight)
'staffline3
g.DrawLine(myPen, staffStartPosX, staffStartPosY, Pic.Width - 10, staffStartPosY)
'staffline4
g.DrawLine(myPen, staffStartPosX, staffStartPosY - staffHeight, Pic.Width - 10, staffStartPosY - staffHeight)
'staffline5
g.DrawLine(myPen, staffStartPosX, staffStartPosY - staffHeight * 2, Pic.Width - 10, staffStartPosY - staffHeight * 2)
Pic.Image = bit
g.Dispose()
*** end ***
Elsewhere on the form, I have a NumericUpDown control which automatically adusts the Staffheight variable from above which would increase the spacing in between the lines....
basically going from this:
________________________
________________________
to:
________________________
________________________
.....
If I adjust the spacing width, the memory for my program increases dramatically. I have had the very small app go from 50Mb of memory up to 500!!! mb of memory just by moving my mousewheel up and down while in the numericUpDown control. The memory will eventually readjust itself down to below 100, but that can take up to 30 seconds or so. Am I doing something wrong with my code? am I not cleaning up properly?
I know there is some kind of garbage collector that automatically cleans up destroyed objects, but it seems to only happen every few seconds, or not enough. I'm assuming the culprits that are filling up the memory are the bitmaps that are being created in the above routine simply because they aren't being destroyed fast enough by the automatic .net garbage collector.
thx.
Asked:
4-
3
2
2 Solutions
>> am I not cleaning up properly?
Anytime YOU create an Image, Bitmap, Graphic, Pen or Brush, you should call the dispose method and set the variable to Nothing to release the memory and speed up garbage collection when you are through with it.
bit.Dispose()
bit = Nothing
myPen.Dispose()
myPen = Nothing
g.Dispose()
g = Nothing
Regards,
Idle_Mind
Anytime YOU create an Image, Bitmap, Graphic, Pen or Brush, you should call the dispose method and set the variable to Nothing to release the memory and speed up garbage collection when you are through with it.
bit.Dispose()
bit = Nothing
myPen.Dispose()
myPen = Nothing
g.Dispose()
g = Nothing
Regards,
Idle_Mind
bit.dispose causes errors in my program. as soon as it's called the area where the bitmap is suppose to appear is blank, and the program halts with a generic error:
An unhandled exception of type 'System.ArgumentException'
Additional information: Invalid parameter used.
upon commenting out bit.dispose and bit = nothing, the program functions as normally. myPen.dispose and g.dispose work fine.
An unhandled exception of type 'System.ArgumentException'
Additional information: Invalid parameter used.
upon commenting out bit.dispose and bit = nothing, the program functions as normally. myPen.dispose and g.dispose work fine.
Can you show us the complete code where you draw and how you cause the lines to be updated?
Idle_Mind
Idle_Mind
Private Sub pic_Resize(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Pic.Resize
If Pic.Width >= 1 And Pic.Height >= 1 Then
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
g.Clear(Pic.BackColor)
bit.Dispose()
bit = Nothing
g.Dispose()
g = Nothing
pnlNotationDrawGrid()
End If
End Sub
Private Sub pnlNotationDrawGrid()
'Draw line on picturebox
'Put a picturebox on the form named pic
Dim i As Short = PrivateVarIntStaffHeight
i = i + 7
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
Dim myPen As Pen = New Pen(PrivateVarColStaffColo
'staffline1
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline2
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline3
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline4
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline5
g.DrawLine(myPen, PrivateVarIntStaffStartPos
Pic.Image = bit
'bit.Dispose()
'bit = Nothing
myPen.Dispose()
myPen = Nothing
g.Dispose()
g = Nothing
End Sub
If Pic.Width >= 1 And Pic.Height >= 1 Then
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
g.Clear(Pic.BackColor)
bit.Dispose()
bit = Nothing
g.Dispose()
g = Nothing
pnlNotationDrawGrid()
End If
End Sub
Private Sub pnlNotationDrawGrid()
'Draw line on picturebox
'Put a picturebox on the form named pic
Dim i As Short = PrivateVarIntStaffHeight
i = i + 7
Dim bit As Bitmap = New Bitmap(Pic.Width, Pic.Height)
Dim g As Graphics = Graphics.FromImage(bit)
Dim myPen As Pen = New Pen(PrivateVarColStaffColo
'staffline1
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline2
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline3
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline4
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline5
g.DrawLine(myPen, PrivateVarIntStaffStartPos
Pic.Image = bit
'bit.Dispose()
'bit = Nothing
myPen.Dispose()
myPen = Nothing
g.Dispose()
g = Nothing
End Sub
It should be more like this:
Private Sub pic_Resize(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Pic.Resize
Pic.Refresh()
End Sub
Private Sub Pic_Paint(ByVal sender As Object, ByVal e As System.Windows.Forms.Paint
If Pic.Width >= 1 And Pic.Height >= 1 Then
Dim g As Graphics = e.Graphics
Dim myPen As Pen = New Pen(PrivateVarColStaffColo
g.Clear(Pic.BackColor)
'staffline1
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline2
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline3
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline4
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline5
g.DrawLine(myPen, PrivateVarIntStaffStartPos
myPen.Dispose()
myPen = Nothing
End If
End Sub
Regards,
Idle_Mind
Private Sub pic_Resize(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Pic.Resize
Pic.Refresh()
End Sub
Private Sub Pic_Paint(ByVal sender As Object, ByVal e As System.Windows.Forms.Paint
If Pic.Width >= 1 And Pic.Height >= 1 Then
Dim g As Graphics = e.Graphics
Dim myPen As Pen = New Pen(PrivateVarColStaffColo
g.Clear(Pic.BackColor)
'staffline1
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline2
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline3
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline4
g.DrawLine(myPen, PrivateVarIntStaffStartPos
'staffline5
g.DrawLine(myPen, PrivateVarIntStaffStartPos
myPen.Dispose()
myPen = Nothing
End If
End Sub
Regards,
Idle_Mind
Ok, I tried the suggestions earlier, however I wasn't aware of the refresh method which is why I used the bitmaps. I've taken out the pic box and replaced with a panel control, along with the suggested draw methods using only the pen. Since I tried this before with out the .refresh methods, I was having trouble with the graphics updating. With this new info, the program is staying at 20mb or so while performing the same operation that was causing the program to run up to the 500mb mark.
thx so much!
I'll give every point i have, try to split it between you two accordingly.
thx so much!
I'll give every point i have, try to split it between you two accordingly.
Question has a verified solution.
Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.
Have a better answer? Share it in a comment.
Join & Write a Comment Already a member? Login.
Featured Post
Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.
One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.
Tackle projects and never again get stuck behind a technical roadblock.
Join Now
I would recommend replacing the PictureBox control with a Panel control and drawing your graphics in the Panel control. You are not limited to only pixel graphics either. You can load a bitmap from a file and use GDI+ to draw the image to the panel using the DrawImage method of the graphics class.
Do your painting in the Panel's Paint event handler to get your graphcis to remain persistent when the window is moved or covered by another window.
Jeff