Solved

File Locking/Acccess help when copying and deleteing

Posted on 2004-09-08
8
1,962 Views
Last Modified: 2012-06-27

When using the FileInfo object I am trying to copy files from one folder to another. After the copy process is complete, I delete the file in the original folder.  After viewing the logs I see this error every once in awhile.

  The process cannot access the file [filename] because it is being used by another process

I have tried numerous pieces of code (GC.collect, fi.refresh, checking for the file being locked, etc ...) and I still get this error and even more frequently.  Here is some of the code.  The project is a windows service.

private void fsw_Watcher_Changed(object sender, System.IO.FileSystemEventArgs e)
            {
                  
                  FileInfo fi = new FileInfo(e.FullPath);      
                  fi.Refresh();
                  if(!fi.Exists) return;      

                  try
                  {
                        string trans_id = this.MakeTransactionID();                                                
                        this.LogReceiptOfFile(fi.Name,trans_id);                  
                        
                        if(fi.Name!="heartbeat.csv")
                        {
                              fi.Refresh();
                              this.CopyToArchive(fi,trans_id);
                        }                        
                        fi.Refresh();
                        this.CopyToOut(fi,trans_id);      
                        fi.Refresh();
                        this.DeleteFromIn(fi,trans_id);
                  }
                  catch(Exception ex)
                  {
                        this.LogError("fsw_Watcher_Changed",ex);
                  }
                  finally
                  {
                        fi = null;
                        GC.Collect();
                  }
            }

            private void LogReceiptOfFile(string fileName,string trans_id)
            {
                  Log myLog = new Log(LOGPATH);
                  myLog.WriteToProcessLog(trans_id,1,"Received","MCGWare",fileName);
                  myLog = null;
            }

            private void LogError(string func,Exception ex)
            {
                  Log myLog = new Log(LOGPATH);
                  myLog.WriteLogMessage(func,ex.Message + "\n" + ex.StackTrace,1);
                  myLog = null;

                  EventLog elog = new EventLog();
                  elog.Source = "Application";
                  elog.Log = "Application";
                  elog.WriteEntry("Error reported in fsw_Watcher_Changed function. Read SDX log files for details.",
                        System.Diagnostics.EventLogEntryType.Error);      
                  elog = null;
            }

            private void CopyToArchive(FileInfo fi,string trans_id)
            {
                  Log myLog = new Log(this.processPath);
                  string fileName =
                        this.archivePath + "\\" +
                        this.MakeFileName(fi.Name.Replace(".csv",""));                  
                  try
                  {
                        fi.CopyTo(fileName,true);
                        myLog.WriteToProcessLog(trans_id,1,"Copy",fi.FullName,fileName);
                  }
                  catch(Exception ex)
                  {
                        this.LogError("CopyToArchive",ex);
                        myLog.WriteToProcessLog(trans_id,0,"Copy",fi.FullName,fileName);
                  }
                  finally
                  {
                        myLog = null;
                  }
            }

            private void CopyToOut(FileInfo fi,string trans_id)
            {
                  Log myLog = new Log(this.processPath);
                  string fileName = this.outPath + "\\" + fi.Name;
                  try
                  {
                        fi.CopyTo(fileName,true);
                        myLog.WriteToProcessLog(trans_id,1,"Copy",fi.FullName,fileName);
                  }
                  catch(Exception ex)
                  {
                        this.LogError("CopyToOut",ex);
                        myLog.WriteToProcessLog(trans_id,0,"Copy",fi.FullName,fileName);
                  }
                  finally
                  {
                        myLog = null;
                  }
            }

            private void DeleteFromIn(FileInfo fi,string trans_id)
            {
                  Log myLog = new Log(this.processPath);
                  try
                  {
                        fi.Delete();
                        myLog.WriteToProcessLog(trans_id,1,"Delete",fi.FullName,"");
                  }
                  catch(Exception ex)
                  {
                        this.LogError("DeleteFromIn",ex);
                        myLog.WriteToProcessLog(trans_id,0,"Delete",fi.FullName,"");
                  }
                  finally
                  {
                        myLog = null;
                  }
            }
0
Comment
Question by:pjbaratelli
  • 4
  • 4
8 Comments
 
LVL 37

Expert Comment

by:gregoryyoung
ID: 12010124
it can be another process aside from your own who is locking the file (i.e. has it open).
0
 
LVL 1

Author Comment

by:pjbaratelli
ID: 12010322
Yeah, but how can you check to see if the file is locked? I have used this code to test.

            private bool IsLocked(FileInfo fi)
            {
                  bool locked = false;
                  try
                  {
                        fi.Open(FileMode.Open,FileAccess.Read,FileShare.None);
                  }
                  catch
                  {
                        locked = true;
                  }
                  return locked;
            }

Is there another way? This one didn't seem to work.
0
 
LVL 37

Expert Comment

by:gregoryyoung
ID: 12010429
no and that way doesnt really work because I could say ...

if(!IsLocked(@"C:\foo.bar")) {
    //another process opens file here ...
    File.Open ....
}
0
 
LVL 1

Author Comment

by:pjbaratelli
ID: 12010452
How could you do it then? That was an example I got off a web site in desperation.  Is there an attribute that I should be looking at?
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 
LVL 37

Accepted Solution

by:
gregoryyoung earned 250 total points
ID: 12010493
no .. you need to handle the case that it may fail ... remember its another process that may be opening your file there is no way of reliably handling it.
0
 
LVL 1

Author Comment

by:pjbaratelli
ID: 12011707
What would be a good process flow to follow? Three tries and then send an alert to someone of failure?  Should I wait so many seconds before each try? The object is to get it so that these files get to where there going 100% if the time.  Where programatically or manually.
0
 
LVL 37

Expert Comment

by:gregoryyoung
ID: 12011720
I would put a 2-3 second Thread.Sleep in between ...

0
 
LVL 1

Author Comment

by:pjbaratelli
ID: 12020359
Okay, this worked great.   My boss is a happy.  Thanks Greg.
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Introduction                                                 Was the var keyword really only brought out to shorten your syntax? Or have the VB language guys got their way in C#? What type of variable is it? All will be revealed.   Also called…
Introduction This article series is supposed to shed some light on the use of IDisposable and objects that inherit from it. In essence, a more apt title for this article would be: using (IDisposable) {}. I’m just not sure how many people would ge…
Get a first impression of how PRTG looks and learn how it works.   This video is a short introduction to PRTG, as an initial overview or as a quick start for new PRTG users.
You have products, that come in variants and want to set different prices for them? Watch this micro tutorial that describes how to configure prices for Magento super attributes. Assigning simple products to configurable: We assigned simple products…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now