• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 181
  • Last Modified:

Threads trying to access same files

Hello,
I am using Threadpool to create mutliple threads each dealing with audio files. In some cases, there are 2 or 3 threads trying to access the same input file and then the same output files. Only the first one gets it and the others fail and throw exceptions. How can I make the 2nd or 3rd thread wait for the file till it's released by the first, so they can process the file too?
0
gvmdevelopment
Asked:
gvmdevelopment
1 Solution
 
BlackTigerXCommented:
just check when you try to open the file (from the thread), if you can't then sleep for a while, then try again... instead of letting the exception kill the thread, you need to handle it and retry later
try
{
 //open file here
}
catch //if there's an exception, catch it here, then sleep for a while, and retry, put this in a while loop or something
0
 
Razzie_Commented:
Lock the file, using the C# lock(expression) statement.

I'm sure you have a method that opens the file. I dunno what kind of file it is, but let's say it is an XML document. Without lock, it would look something like this:

XmlDocument xmlDoc = new XmlDocument();
xmlDoc.Load(filename);

xmlDoc.SelectSingleNode("//node").InnerText = "test";
xmlDoc.Save();

---------------

if you would call this 3 or 4 times and add it to the ThreadPool, erroneous results could occur if the last instance would overwrite the first. So, to avoid this, you can use the lock statement:

XmlDocument xmlDoc = new XmlDocument();
xmlDoc.Load(filename);

lock(xmlDoc)
{
   xmlDoc.SelectSingleNode("//node").InnerText = "test";
   xmlDoc.Save();
}

-------------------

This will lock the object and every other thread will wait till the object is ready to be used again. When the lock statement goes out of scope, it will be automatically available again.

This should work.

Razzie
0
 
Razzie_Commented:
Ok it was an audio file, I should read better ;)
0
 
tzxie2000Commented:
Please use Mute to access it

suggest in method createthread you generate the thread and method readaudio is the method you read file.
then

code below:

class play audio
{
  private static Mutex mut = new Mutex();
    private const int numIterations = 1;
    private const int numThreads = 3;//number of threads you create

   private void createthread()
    {
        for(int i = 0; i < numThreads; i++)
        {
            Thread myThread = new Thread(new ThreadStart(ReadAudio));
            ReadAudio.Name = String.Format("ReadAudio", i + 1);
            ReadAudio.Start();
        }

        // The main thread exits, but the application continues to
        // run until all foreground threads have exited.
    }

    private static void ReadAudio()
    {
        mut.WaitOne();
        //read the file and doing what you want

        mut.ReleaseMutex();
    }
}
0
 
a_goatCommented:
There's a neat trick for this:

string filename = @"c:\foo.wav";
lock(filename.ToLower())
{
    // Open file and do stuff here
}

Because of string-interning, two strings with the same value will always be the same object.  So you make the filename lower case (in case the cases are different), and lock the variable.  No thread can get past the lock until no other thread is in it.

It still won't cover the case where the file is in use by another process.  In that case you need to keep checking and trying
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Get expert help—faster!

Need expert help—fast? Use the Help Bell for personalized assistance getting answers to your important questions.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now