Accessing data from two threads

Hello,

I am writing an application which uses two threads.
I have a list<int> variable in my Document class.
THREAD 1
In this thread, I am filling a list from back i.e pDoc->list.insert(list.begin(),data);
THREAD 2
In this thread, I am extracting each element from top of the list, and displaying it on the UserInterface i.e
data = pDoc->list.pop_front();
Display(data);

THREAD1 cotinously reads and adds data at the bottom of the list while THREAD 2 gets  data from the top of the list and displays it.

Can I directly access the list memeber available in my document class as above in the two threads.
When I tried the above, it worked fine when the list had limited number say 10 to 30 records, but as the size of list was growing to say 10,000 records the program was crashing.

Can anyone please help me to solve this ?

Thanks
Madhavi
j_madhaviAsked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
lakshman_ceConnect With a Mentor Commented:
list::push_back
Adds an element to the end of a list.

list::pop_front
Deletes the element at the beginning of a list.

Plz refer to
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vcstdlib/html/vclrflist_members.asp

As you are using threads, it is advisable you synchronize between these 2 threads. If the first thread is adding element #10 in the list and the same is being accessed by the second thread, this may lead to crash.You can refer to
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vccore98/HTML/_core_multithreading.3a_.how_to_use_the_synchronization_classes.asp
0
 
IlangoCommented:
Fine.. To be specific have a critical section included in your document object and lock it before you make a insertion and release once you are done. The same should be done for reading also. From your explanation, I can say you need a single Critical session and not seperate read and write locks.

If needed use the thread safe InterlockIncrement/InterlockedDecrement for any index based operation.

Thread synchronization is closely associated with the implementation requirement and you have to decide on how better your data will be manipulated.

Cheers !
0
 
l3st4rdCommented:
to give an example:
first declare a critical section object in your header file:

CRITICAL_SECTION csListAccess;

now initialize the critical section BEFORE you start the threads:

    ::InitializeCriticalSection(&csListAccess);

the new thread code will look like this:
THREAD1:
    ::EnterCriticalSection(&csListAccess);
    pDoc->list.insert(list.begin(),data);
    ::LeaveCriticalSection(&csListAccess);

THREAD2:
    ::EnterCriticalSection(&csListAccess);
    data = pDoc->list.pop_front();
    ::LeaveCriticalSection(&csListAccess);

and don't forget to delete the critical section again (maybe in the destructor):
    ::DeleteCriticalSection(&csListAccess);

of course u need to place i.e. a pointer to the critical section into the thread parameter so that u'll get access to the critical section from within the thread functions.
0
 
cureroCommented:
A simpler (but not the finest) MFC solution:

    CMutex mtxList;

 (you can make it global for easy access)

 for each access to the list:
   mtxList.Lock();
   //access the list
   mtxList.Unlock

 When the application is closed, the kernel will clean it (no need to destroy it). You can add a time-out (just to be sure) in the 'lock' call.
 
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.