Solved

Decimals and rounding off

Posted on 2004-09-20
5
371 Views
Last Modified: 2010-08-05
I am trying to calculate the number of pages in a repeater based on the records returned and page size, but am having issue with decimals and rounding off. e.g.

iRecordCount = 18;
iPageSize = 10;

// Get total pages
decimal dPageRecords = Convert.ToDecimal(iRecordCount / iPageSize);
iTotalPages = Convert.ToInt32(System.Math.Round(dPageRecords));

Trace.Warn("dPageRecords=" + dPageRecords.ToString());
Trace.Warn("iTotalPages=" + iTotalPages);

Output I'm looking for is:
dPageRecords=1.8
iTotalPages=2

Whereas I keep fricking getting:
dPageRecords=1
iTotalPages=1

Any ideas thanks?
0
Comment
Question by:jonnyboy69
  • 3
5 Comments
 
LVL 10

Accepted Solution

by:
eternal_21 earned 125 total points
ID: 12104622
 int iRecordCount = 18;
  int iPageSize = 10;

  double dPageRecords = (double)iRecordCount/(double)iPageSize;
  int iTotalPages = (int)Math.Ceiling(dPageRecords);

  Trace.Warn("dPageRecords=" + dPageRecords.ToString());
  Trace.Warn("iTotalPages=" + iTotalPages.ToString());

Will yeild the output you desire:

  dPageRecords=1.8
  iTotalPages=2
0
 
LVL 10

Expert Comment

by:eternal_21
ID: 12104677
Another note: If you want one and only one decimal in your dPageRecords output, use this:

  Trace.Warn("dPageRecords=" + String.Format("{0:0.0}", dPageRecords));

Examples of output are:

  Value of dPageRecords -> Value of String.Format("{0:0.0}", dPageRecords)
  1.8 -> 1.8
  1.85447 -> 1.9
  1 -> 1.0

  So you will always have 1 decimal displayed.
0
 
LVL 5

Expert Comment

by:tzxie2000
ID: 12105029
you can use
iTotalPages=(iRecordCount-(iRecordCount%iPageSize))/iPageSize+1
to get the pages
if you'd like to define pages as the page with full pagesize you can ommit +1 as
iTotalPages=(iRecordCount-(iRecordCount%iPageSize))/iPageSize
0
 
LVL 10

Expert Comment

by:eternal_21
ID: 12107478
jonnyboy69, I would suggest you use tzxie2000's solution for iTotalPages - it avoids any possibility of a rounding error.

  iTotalPages = iRecordCount/iPageSize + (iRecordCount%iPageSize==0 ? 0 : 1);
0
 
LVL 1

Expert Comment

by:blueforce
ID: 12108218
The problem you've got is an order of operations problem.


This code is all well and good since an int can be implicitly cast "up" to a decimal:

decimal dPageRecords = Convert.ToDecimal(iRecordCount / iPageSize);
iTotalPages = Convert.ToInt32(System.Math.Round(dPageRecords));


However, look at the order of operations
Step 1.  iRecordCount / iPageSize  (both are ints so the answer will be an int - a rounded off int).
Step 2.  Convert the integer answer from Step 1 to a decimal
Step 3.  Assign the new decimal answer to dPageRecords.

It doesn't matter how big or small iRecordCount or iPageSize become - if you want to eventually hold a decimal, you'll have to explicitly cast to some floating type or use decimals to begin with.


The following will work since the casts happen before the division which results in the same datatype as the dividend and divisor:
decimal dPageRecords = Convert.ToDecimal( (decimal)iRecordCount / (decimal)iPageSize);  

Or you could just use decimals to begin with - the trade-off of a decimal datatype vs. the speed of explicitly casting an Int32 is about the same.

0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Bit flags and bit flag manipulation is perhaps one of the most underrated strategies in programming, likely because most programmers developing in high-level languages rely too much on the high-level features, and forget about the low-level ones. Th…
Article by: Najam
Having new technologies does not mean they will completely replace old components.  Recently I had to create WCF that will be called by VB6 component.  Here I will describe what steps one should follow while doing so, please feel free to post any qu…
Excel styles will make formatting consistent and let you apply and change formatting faster. In this tutorial, you'll learn how to use Excel's built-in styles, how to modify styles, and how to create your own. You'll also learn how to use your custo…
This video shows how to remove a single email address from the Outlook 2010 Auto Suggestion memory. NOTE: For Outlook 2016 and 2013 perform the exact same steps. Open a new email: Click the New email button in Outlook. Start typing the address: …

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now