Lunarpages' assortment of hosting products and solutions ensure a perfect fit for anyone looking to get their vision or products to market. Our award winning customer support and 30-day money back guarantee show the pride we take in being the industry's premier MSP.
Solved
Setting initial form values w/ CF and JavaScript
Posted on 2004-09-26
Ok, this should be easy, but I have a way of making the easiest things the hardest. Now to the situation at hand. I am creating a coldfusion site to sell a product. For each product, the site admin needs to be able to edit item info. Right now I have the site set up to use the same page to both add and edit items. The form shows blank to add an item (this obviously works correctly), but should contain existing data for an item to be edited. This is where I am having problems. I am trying to set the value element of the input field on the forms. Here is my code;
<cfif #url.a# eq "e">
<cfquery name="getItemInfo" datasource="ninaDB">
Select *
From table
Where item_id = <cfqueryparam cfsqltype="cf_sql_integer"
</cfquery>
<script language="JavaScript" type="text/JavaScript">
document.theForm.item_id.V
document.theForm.Rname.Val
document.theForm.Rcat_id.v
document.theForm.Rprice.va
document.theForm.shipping.
document.theForm.Rdesc_shr
document.theForm.Rdesc_lon
document.theForm.Rpicture_
document.theForm.Rpicture_
document.theForm.isSold.va
document.theForm.isListed.
document.theForm.isFeature
</script>
</cfif>
url.a is the action variable that determines if the page is for adding or editing an item. In the source code for the page, the cfoutputs work correcting (displaying the contents of the variable), but I keep getting an error about a missing semi-colon, which I don't understand.
I know this is an idiots question,
BUT PLEASE HELP!!!
Thanks,
Josh
<cfif #url.a# eq "e">
<cfquery name="getItemInfo" datasource="ninaDB">
Select *
From table
Where item_id = <cfqueryparam cfsqltype="cf_sql_integer"
</cfquery>
<script language="JavaScript" type="text/JavaScript">
document.theForm.item_id.V
document.theForm.Rname.Val
document.theForm.Rcat_id.v
document.theForm.Rprice.va
document.theForm.shipping.
document.theForm.Rdesc_shr
document.theForm.Rdesc_lon
document.theForm.Rpicture_
document.theForm.Rpicture_
document.theForm.isSold.va
document.theForm.isListed.
document.theForm.isFeature
</script>
</cfif>
url.a is the action variable that determines if the page is for adding or editing an item. In the source code for the page, the cfoutputs work correcting (displaying the contents of the variable), but I keep getting an error about a missing semi-colon, which I don't understand.
I know this is an idiots question,
BUT PLEASE HELP!!!
Thanks,
Josh
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
-
3
-
2
8 Comments
wow wow, you are mixing JS with CF, not a good idea in this case.
Try
<cfparam name="form.firstName" default="" type="string" />
<cfoutput>
<form method="post" action="">
<input type="text" name="firstName" value="#form.firstName#" />
</form>
</cfoutput>
enter some data
now submit the form
you'll notice that the form is populated with the entry you put in there...
this is good if there was an error and you wanted to display the data to the user again so he/she can correct it.
Now for the edit
same page
<cfquery name="qData" datasource="yourdatasource
SELECT firstname
FROM yourtable
WHERE (x = y)
</cfquery>
<cfset form.firstname = qData.firstName />
<cfparam name="form.firstName" default="" type="string" />
<cfoutput>
<form method="post" action="">
<input type="text" name="firstName" value="#form.firstName#" />
</form>
</cfoutput>
There is an easier way to populate the form scope again, but we'll get to that when you understand the above concept...
Try
<cfparam name="form.firstName" default="" type="string" />
<cfoutput>
<form method="post" action="">
<input type="text" name="firstName" value="#form.firstName#" />
</form>
</cfoutput>
enter some data
now submit the form
you'll notice that the form is populated with the entry you put in there...
this is good if there was an error and you wanted to display the data to the user again so he/she can correct it.
Now for the edit
same page
<cfquery name="qData" datasource="yourdatasource
SELECT firstname
FROM yourtable
WHERE (x = y)
</cfquery>
<cfset form.firstname = qData.firstName />
<cfparam name="form.firstName" default="" type="string" />
<cfoutput>
<form method="post" action="">
<input type="text" name="firstName" value="#form.firstName#" />
</form>
</cfoutput>
There is an easier way to populate the form scope again, but we'll get to that when you understand the above concept...
just incase you do not care about the above solution:
<cfoutput>
<script language="JavaScript" type="text/JavaScript">
document.theForm.item_id.V
document.theForm.Rname.Val
document.theForm.Rcat_id.v
document.theForm.Rprice.va
document.theForm.shipping.
document.theForm.Rdesc_shr
document.theForm.Rdesc_lon
document.theForm.Rpicture_
document.theForm.Rpicture_
document.theForm.isSold.va
document.theForm.isListed.
document.theForm.isFeature
</script>
</cfoutput>
make sure you have a ; at the end of each statement, and use ' around string values
<cfoutput>
<script language="JavaScript" type="text/JavaScript">
document.theForm.item_id.V
document.theForm.Rname.Val
document.theForm.Rcat_id.v
document.theForm.Rprice.va
document.theForm.shipping.
document.theForm.Rdesc_shr
document.theForm.Rdesc_lon
document.theForm.Rpicture_
document.theForm.Rpicture_
document.theForm.isSold.va
document.theForm.isListed.
document.theForm.isFeature
</script>
</cfoutput>
make sure you have a ; at the end of each statement, and use ' around string values
I tried the second solution, but I still get an error: Expected: ';' Line: 22 Column: 45. (that is right after the '=' on the first document.form...
I am still a little confused on solution one offered above, what is the concept? I understand using the cf variable and bypassing the js. Should I just use a cfswitch statement to set the cf variables to "" for a new item or the existing data for editings?
Value probably needs to be lowercase
the concept of the solution is, that you post a form to itself, if there are any errors the form is populated again and the user can correct, the same form can also be reused for editing records...
the concept of the solution is, that you post a form to itself, if there are any errors the form is populated again and the user can correct, the same form can also be reused for editing records...
Why not just put the logic in your form fields value attribute? Ex.
<cfif #url.a# eq "e">
<cfquery name="getItemInfo" datasource="ninaDB">
Select *
From table
Where item_id = <cfqueryparam cfsqltype="cf_sql_integer"
</cfquery>
</cfif>
<cfoutput>
<input type="text" size="20" name="item_id" value="<cfif IsDefined('getItemInfo.Ite
...
</cfoutput>
That way they are blanks if not defined, and filled if they are... if you want to provide default values just make the <cfif></cfif> a <cfif><cfelse></cfif> and put the default value in the second slot.
Not sure this is the best solution, but it's definitely an easy one and will eliminate the Javascript entirely. This will slightly slow the server compile of the page (but caching will solve that on 2nd load), but it will actually make it slightly faster on the client side since the javascript doesn't have to fire... also this will work on browsers that have javascript turned off as well.
Just a thought.
<cfif #url.a# eq "e">
<cfquery name="getItemInfo" datasource="ninaDB">
Select *
From table
Where item_id = <cfqueryparam cfsqltype="cf_sql_integer"
</cfquery>
</cfif>
<cfoutput>
<input type="text" size="20" name="item_id" value="<cfif IsDefined('getItemInfo.Ite
...
</cfoutput>
That way they are blanks if not defined, and filled if they are... if you want to provide default values just make the <cfif></cfif> a <cfif><cfelse></cfif> and put the default value in the second slot.
Not sure this is the best solution, but it's definitely an easy one and will eliminate the Javascript entirely. This will slightly slow the server compile of the page (but caching will solve that on 2nd load), but it will actually make it slightly faster on the client side since the javascript doesn't have to fire... also this will work on browsers that have javascript turned off as well.
Just a thought.
Featured Post
With the increasing importance of apps & networks in both business & personal interconnections, perfor. has become one of the key metrics of successful communication. This ebook is a hands-on business-case-driven guide to understanding MySQL query parameter tuning & database perf
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
This is a guide to setting up a new WHM/cPanel Server to be used for web hosting accounts. It is intended for web hosting company administrators and dedicated server owners. For under $99 per month (considering normal rate of Big Data Cetnters like …
What You Need to Know when Searching for a Webhost Provider
Do you want to know how to make a graph with Microsoft Access? First, create a query with the data for the chart. Then make a blank form and add a chart control. This video also shows how to change what data is displayed on the graph as well as form…
We’ve all felt that sense of false security before—locking down external access to a database or component and feeling like we’ve done all we need to do to secure company data.
But that feeling is fleeting. Attacks these days can happen in many w…
Suggested Courses
Course of the Month14 days, 19 hours left to enroll
649 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.