• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 346
  • Last Modified:

Why can't I draw an outline around my TLabel?

Hi,
Take a look at the code below.

The code in the Shape1DragDrop event handler FAILS to create a dotted outline around the TLabel which is  created firstly in this procedure.

BUT....the same two lines of code dropped into the Button1Click event handler below DOES create the outline around the same label!

Any ideas why this is??
I don't want the user to have to click a button to draw the outline around this label :)

Thanks

procedure TForm1.Shape1DragDrop(Sender, Source: TObject; X, Y: Integer);
begin
if Source is TListBox then
begin
  l := TLabel.Create(Self);
  l.Left := X;
  l.Top := Y;
  l.Parent := Panel1;
  l.Caption := ListBox1.Items[ListBox1.ItemIndex];
  l.Canvas.Pen.Style := psDot;
  l.Canvas.Rectangle(0,0,l.Width,l.Height);
  MyArray[1] := l;
end;
end;

procedure TForm1.Button1Click(Sender: TObject);
begin
  l.Canvas.Pen.Style := psDot;
  l.Canvas.Rectangle(0,0,l.Width,l.Height);
end
0
nathc
Asked:
nathc
  • 3
  • 2
1 Solution
 
mottorCommented:
Because changing caption requires repaint:
...
.......
    l.Caption := ListBox1.Items[ListBox1.ItemIndex];
    l.Canvas.Pen.Style := psDot;
    Panel1.Repaint;                                     //  Look here
    l.Canvas.Rectangle(0,0,l.Width,l.Height);
....
0
 
nathcAuthor Commented:
Thanks mottor, that worked but raised a new issue.
The first label dropped onto Shape1 works fine but when I drop the second one on the dashed border around the first label disappears.
Is this something to do with the repaint??
0
 
JaymolCommented:
The repaint will only do what it thinks it should do, and that is to redraw every object as it should be.  If you have made any manual changes (eg. drawing directly onto the canvas) then these changes will be lost as they are not actually part of the object.

You will need to redraw any manual canvas changes after every repaint.
0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
mottorCommented:
Add this to your code and use TMyLabel instead of TLabel :

type TMyLabel = class(TLabel)
     protected
       procedure Paint; override;
     end;
procedure TMyLabel.Paint;
begin
  inherited;
  Canvas.Pen.Style := psDot;
  Canvas.Rectangle(0,0,Width,Height);
end;

0
 
nathcAuthor Commented:
Hey Mottor,

I get this error
[Error] LabelCreate.pas(42): Identifier redeclared: 'TMyLabel.Paint'
[Error] LabelCreate.pas(43): This form of method call only allowed in methods of derived types

When I try the code below.

type TMyLabel = class(TLabel)
     protected
       procedure Paint; override;
     end;
-->procedure TMyLabel.Paint; <--- This line!!
begin
  inherited;
  Canvas.Pen.Style := psDot;
  Canvas.Rectangle(0,0,Width,Height);
end;

Any ideas??
0
 
nathcAuthor Commented:
Sorry mottor, got it working. Just shifted the procedure bit elsewhere thanks very much :)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

  • 3
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now