• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 253
  • Last Modified:

What's the difference between these two ??

Hi, what is the difference between these two codefragments ??
I don't see any difference...
**** THIS WORKS ****
int16* dst=p1->buffer;  //buffer consists allso out of int16's
for (int i = 0; i < strlen(aa); i++)
      {
      val = *aa;
      SSVAL(dst, 0, val);
      dst++;
      aa++;
      if (val == 0)
            break;
      }
**** END ****

**** THIS DOESN'T WORKS ****

for (int i = 0; i < strlen(aa); i++)
      {
      val = *aa;
      SSVAL(p1->buffer, 0, val);
      p1->(buffer++);
      aa++;
      if (val == 0)
            break;
      }
****END****

0
pimpernel
Asked:
pimpernel
2 Solutions
 
Kent OlsenData Warehouse Architect / DBACommented:

From your comment and the code fragments, it appears that p1 is defined as:

typedef struct
{
...
  int16 buffer[SomeLength];
...
} p1_type;

p1_type *p1;

In your first example you assign the address of p1->buffer to dst and then increment dst each time through your loop.

In your second example you increment p1->buffer[0] each time through the loop.


Kent
0
 
pimpernelAuthor Commented:
Thanks. But how should I increment it then correct (like in the first example...) ??

0
 
Kent OlsenData Warehouse Architect / DBACommented:

You need a temporary variable that you can increment, like in your first example.

The second fragment is actually an error because you're incrementing your data instead of a pointer.  Even if p1->buffer is defined as an 'int16 *' you don't want to do what the second fragment does because you're now incrementing the pointer to your buffer.  In all likelihood this is the base pointer so this coding style causes you to lose the base pointer to your buffer.

Stick with something close to example 1.  It works because it's correct.


Good Luck,
Kent
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
guntherothkCommented:
I'm not sure this loop does what you think it does. As you increment i in the loop, you are also incrementing aa, so strlen(aa) is decreasing each time through the loop. C++ evaluates the expression fully each time through. I'm betting you only read half the things you want to read. Unless this is the behavior you want, you need to assign strlen(aa) to a variable outside the loop

    int slen = strlen(aa);
    for (int i = 0; i < slen; i++) ...

or you can be fancy and put both into the for loop initializer

    for (int slen = strlen(aa), i = 0; i < slen; i++) ...
0
 
pimpernelAuthor Commented:
OK, Kdo, I'll keep the first sollution...
Thanks guntherothk for the tip. I'll put the strlen out of the "for".

0
 
itsmeandnobodyelseCommented:
Yesterday i answered to that question

     http:Q_21154939.html

It was using a ToUnic function that had identical code fragments than your code, but hadn't the bugs kdo and gunther already pointed out. Obviously you are trying to change working code, what isn't recommended even if you would exactly know what you are doing.

As you made no response to the comments of kdo and gunther, i'll explain again the errors you made:

With p1->(buffer++) you are changing the pointer value of the data member 'buffer' in the struct _UNICODE_STRING. The instance 'p1' of  that struct has an invalid buffer member then (it points to the terminating zero and *not* to the begin of the previously allocated storage).

The main difference to the old working code is, that it uses a local pointer variable, thus leaving the value of p1->buffer intact.

The second error was similar: Instead of using a local variable 'len' as upper bound of the for loop, you are using strlen function. However, the argument of strlen is the char pointer 'aa' that get changed in the loop when that statement executes: aa++; . So, strlen(aa) decrements and i++ increments, e. g. with a string length of 10 only 5 bytes were copied to the UNICODE string.

Regards, Alex








0
 
pimpernelAuthor Commented:
Hello,
sorry for my very late response, but I don't check my mail very often...
Thanks for your extra explanation.
I allreasy understood the remark of Kdo, but indeed didn't entirely understood guntherothk's remark (since the first code with the strlen also worked).

Now it's entirely clear (I think), and since my strings allways have a fixed length I just replaced the strlen part with th length.

Greetz, pimpernel
0

Featured Post

Concerto Cloud for Software Providers & ISVs

Can Concerto Cloud Services help you focus on evolving your application offerings, while delivering the best cloud experience to your customers? From DevOps to revenue models and customer support, the answer is yes!

Learn how Concerto can help you.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now