Strip surrounding double quotes from array of strings from split using regular expression


I am using the following function to parse a CSV file into an array of strings.  The function works fine, but all of the values in the resulting array of strings are surrounded by double quotes.  I wanted to find an efficient way to strip the surrounding quotes from string values in the resultant array.  Im pretty sure I can do this by modifying the regular expression, but not positive.

    Private Shared Function ParseLine(ByVal oneLine As String) As String()
        Dim r As System.Text.RegularExpressions.Regex = New System.Text.RegularExpressions.Regex(",(?=(?:[^""]*""[^""]*"")*(?![^""]*""))")
        Return r.Split(oneLine)
    End Function

Right now, I am using the following code on the resultant array, which takes a long time and is obviously very inefficient:

                Dim i As Integer
                For i = 0 To parsedString.Length - 1
                    dataStore(recordCount - 1, i) = parsedString(i).Substring(1, parsedString(i).Length - 2)

Thanks in advance.  Cheers to whoever can do this :-)

Who is Participating?

[Webinar] Streamline your web hosting managementRegister Today

farsightConnect With a Mentor Commented:
  Your code assumes that each and every string has enclosing double-quotes.  Is that safe?
  If you're not concerned with your strings _containing_ double-quotes, or if you _know_ that _every_ string has enclosing double-quotes, you can certainly make the regex simpler.  It depends on if you want a solution to a specific simple case, or if you want a solution that will handle (almost) every commonly found CSV file.

VB string is ",(?=(?:[^""]*""[^""]*"")*(?![^""]*""))"
Regular expression is:
This part: [^"]*"[^"]*" means:
  [^"]*   any number of characters that are not a double-quote (typically nothing, or whitespace)
  "          the initial double-quote
  [^"]*   any number of characters that are not a double-quote (the content)
  "          the terminating double-quote

Regular Expression Reference

Grouping Constructs (Especially useful for this complicated regular expression)

I recommend Expresso ( ) or Regulator ( ) or a similar tool to work with and help understand regular expressions.

Also, check the regular expression library:

  That would replace ALL double-quotes, including any that are inside the string, not just the ones that "enclose" the string.

Of course, if it turns out that that's OK, and if one can be sure that no commas are inside the string either, then we could just split on the comma, and ignore all the complexity.
why don't you use the Replace method, to replace all occurrences of " with a zero-length string?

dsulli2000Author Commented:
Technically, the string between the outer double quotes could contain double quotes itself..
  Ah! I just saw your response.  I think the regex is intended to recognize VB-style strings in the CSV.

All these would contain three items:
  a, b, c
  "a,a", "b,b", "c,c"
  "I said, ""Hello""!", this, that
The first item in the last one would be:
  "I said, ""Hello""!"
You'd need to intelligently parse this, changing enclosed doubled-double-quotes to single-double-quotes.  Note that this applies only to strings that are enclosed by double-quotes.  Strings that are NOT enclosed by double-quotes are "raw", and need no additional processing.

So I have a correct solution (though even slower).

[VB.NET with .NET 1.1, compiled, partially tested]

                For i As Integer = 0 To parsedString.Length - 1
                    dataStore(recordCount - 1, i) = ParseItem(parsedString(i))

    Function ParseItem(ByVal text As String) As String
        Dim oneDoubleQuote As String = """"        ' for readability of code below.
        Dim twoDoubleQuotes As String = oneDoubleQuote & oneDoubleQuote
        If text.Length > 1 _
        AndAlso text.StartsWith(oneDoubleQuote) _
        AndAlso text.EndsWith(oneDoubleQuote) Then
            Return text.Substring(1, text.Length - 2).Replace(twoDoubleQuotes, oneDoubleQuote)
            Return text        ' unchanged
        End If
    End Function
All Courses

From novice to tech pro — start learning today.