Solved

ADO addnew slow

Posted on 2004-10-19
7
1,632 Views
Last Modified: 2013-11-23
Hi,
I have a problem here. I'm using ADO in my VB programming. I created a function to add new record into a table("result"). It able to add 500 records into the table but takes 40 seconds to run the process. If compare with DAO method, it can run very fast(5 second). My PC is Pentium III 800Mhz. why ADO run so slow compare to DAO? Please help me? here is my code.
Thank you.

Function Connection()
Connection = "Provider=Microsoft.jet.OLEDB.4.0;Data source=" & App.Path & "\books.mdb;persist security info=false"
End Function

Function RunSearch()
Dim rst As ADODB.Recordset
Dim query As String

query = "select * from IdentMaster Where IdentNo=15000 ORDER BY IdentMaster.IdentNo"
Set rst = New ADODB.Recordset

rst.CursorType = adOpenStatic
rst.Open query, connect_string, , , adCmdText

Dim rst1 As New ADODB.Recordset

With rst1
    .CursorLocation = adUseServer
    .CursorType = adOpenStatic
    .Open "Result", connect_string, adOpenStatic, adLockOptimistic, adCmdTableDirect
    .Index = "PrimaryKey"
End With
If rst.RecordCount = 0 Then
    MsgBox "Record not found!", vbInformation
    Me.sfToolList.Refresh
Else

'delete all records in Result table.
Dim oRs As New ADODB.Recordset
Dim adoConn As ADODB.Connection
Set adoConn = New ADODB.Connection
adoConn.ConnectionString = Connection()
adoConn.Open
oRs.CursorLocation = adUseClient
oRs.Open "Delete * from Result", adoConn, adOpenKeyset, adLockOptimistic

rst1.Requery
    i = 0
        rst.MoveLast
        intCount = rst.RecordCount
        rst.MoveFirst
        For i = 1 To intCount
            If rst1.EOF Then
                With rst1
                .AddNew
                !IdentNo = rst!IdentNo
                !MachineManufacturerID = rst!MachineManufacturerID
                !MachineTypeID = rst!MachineTypeID
                !groupid = rst!groupid
                .Update
                End With
            End If
            rst1.Requery
        rst.MoveNext
        Next i
End If

Rst.close
Set rst=nothing

End Function
0
Comment
Question by:william43
  • 3
7 Comments
 
LVL 49

Expert Comment

by:Ryan Chong
ID: 12345872
Try use the Execute method in Connection Object to insert your data, instead of using addNew method, this will make your process faster.

Example:

SQLstr = "Insert into mytable (fld1, fldN) values ('value1', 'valueN') "
conn.execute SQLstr

try do necessary change for your above scripting.

Hope this helps
0
 
LVL 49

Expert Comment

by:Ryan Chong
ID: 12345877
Find more on Jet SQL command syntax if necessary at:
http://www.devguru.com/Technologies/jetsql/quickref/statements.html
0
 
LVL 4

Expert Comment

by:ChenChen
ID: 12345907

agree with ryancys, really should use "insert" statement
0
 
LVL 14

Expert Comment

by:aelatik
ID: 12347782
Had the same issue last time and in my case the addnew command turned out a lot faster then the insert statement because the recordset remains open.
What you should do is to put the .UPDATE command after the loop instead of updating it after each record.
0
 
LVL 49

Accepted Solution

by:
Ryan Chong earned 500 total points
ID: 12349315
The script is slow because you executing your addNew method in a loop, if the loop is big, then more you're suffering to wait the code to execute finished.

As review your code, seems that you want to select the records from a statement (select IdentMaster) and dump it to another table (Result), so why don't you try using Select Into statement? More easier and i think even faster way to code can be executed!

so, try like:

Function RunSearch()

Dim query As String

Dim conn As ADODB.Connection
Set conn = New ADODN.Connection

query = "select IdentNo, MachineManufacturerID, MachineTypeID, groupid into Result from IdentMaster Where IdentNo=15000 ORDER BY IdentMaster.IdentNo"

conn.ConnectionString = Connection
conn.Open

If rs.state = adStateOpen Then
   conn.execute query
   conn.close
end if

Set conn = nothing

End Function


Is this what you want??
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Introduction While answering a recent question about filtering a custom class collection, I realized that this could be accomplished with very little code by using the ScriptControl (SC) library.  This article will introduce you to the SC library a…
When trying to find the cause of a problem in VBA or VB6 it's often valuable to know what procedures were executed prior to the error. You can use the Call Stack for that but it is often inadequate because it may show procedures you aren't intereste…
Show developers how to use a criteria form to limit the data that appears on an Access report. It is a common requirement that users can specify the criteria for a report at runtime. The easiest way to accomplish this is using a criteria form that a…
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

895 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now