Solved

problems trying to cycle through files and modify them

Posted on 2004-10-26
185 Views
Last Modified: 2010-03-05
Hi

I'm writing a script to cycle through the files in a directory and modify if an update file contains certain information. The problems im having (well, the problem im up to) is that i cant seem to extract the first line of the files to update in order to extract a number i need to use to match with the update file. My print debug line is doing nothing. I seem to be able to cycle and open the files fine - its just that i cant seem to be able to do anything with them. Heres the code:

#!/usr/bin/perl
use strict;
my $direc = "/home/jgs/blastportal/";
my $prefix = "taxGI_";

print("Update?: ");
my $in = <STDIN>;
chomp($in);

if($in eq "y"){
    my $update = $direc. "gi_taxid_nucl_diff.dmp";
    open(UPDLIST, $update) || die("Canont open update list.");

    opendir(DIR, $direc);
    my @files = grep(/($prefix)/,readdir(DIR));
    closedir(DIR);
   
foreach my $file(@files){
    my $path = $direc.$file;
    print $path;
    open(TAXFILE, "+>> $path") || die("Cannot open a tax file");
    my $firstline = <TAXFILE>;
    print $firstline;
    my $id = ($firstline =~ /\s+\d$/);
 
    while(<UPDLIST>){
      print TAXFILE if(/\s+($id)/);
    }
    close(TAXFILE);
}
close(UPDLIST);

}

I'm new to perl so any advice would be very useful.

thanks
0
Question by:grubmaker
    10 Comments
     

    Author Comment

    by:grubmaker
    ah, sorry, its something to do with how im opening the TAXFILE. if i open it with < i can read it fine. but i cant write to it. i thought +> and +>> had both read and write access?
    0
     
    LVL 84

    Expert Comment

    by:ozo
       print $path;
    is this your print debug line?
    If it is not printing, it means that your  grep(/($prefix)/,readdir(DIR)) did not find any matching files.  Or perhaps that $in ne "y".

         my $id = ($firstline =~ /\s+\d$/);
    I'm not sure what you think this is doing, but it sets $id to 1 if $firstline ends with whitespace followed by a single digit.
    Based on your later use if $id, I might venture a guess that you might have meant something like:
         my($id) = $firstline =~ /\s+(\d+)$/;
    0
     

    Author Comment

    by:grubmaker
    print $firstline;

    was my debug line of choice at the moment. im finding the files, it was the getting first line from each that is an issue. thanks for the regex advice, im going to give it a go now.
    0
     

    Author Comment

    by:grubmaker
    hmm.. ive tried your corrections and its still only grabbing the 1. the file is simply two columns of numbers, im trying to tell it to grab the first number after the first white spaces...
    0
     
    LVL 84

    Expert Comment

    by:ozo
    if the number is not the last thing on the line, then try.
    my ($id) = $firstline =~ /\s(\d+)/;
    Otherwise, show me $firstline, $id, and your code.
    0
     
    LVL 84

    Accepted Solution

    by:
    you may also want
       print TAXFILE if(/\s+($id)\b/);
    so that "  3456"  does not match $id="34"
    0
     
    LVL 5

    Expert Comment

    by:ITcrow
    You mentioned that line consists of two number columns ...

    my($first_line) = <TAXFILE>;
    my($col2)       = (split /\s+/, $first_line)[1];

    Like wise if you needed column 1:
    my($col1)       = (split /\s+/, $first_line)[0];

    Looking for both columns to make any evaluations
    my($col1, $col2) = (split /\s+/, $first_line);

    0
     

    Author Comment

    by:grubmaker
    thanks...

    yes i was omitting the brackets around $id, my ($id)..... what does this do?

    thanks for the assistance
    0
     
    LVL 84

    Expert Comment

    by:ozo
    the parenthesis in
     ($id) =
    puts the assignmet in list context.
    In list context, m// returns a list consisting of the subexpressions matched by the parentheses in the pattern, i.e., ($1, $2, $3...)
    In scalar context, it returns true if it succeeds, false if it fails.
    0
     

    Author Comment

    by:grubmaker
    ahah - great thanks alot
    0

    Write Comment

    Please enter a first name

    Please enter a last name

    We will never share this with anyone.

    Featured Post

    How your wiki can always stay up-to-date

    Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
    - Increase transparency
    - Onboard new hires faster
    - Access from mobile/offline

    I've just discovered very important differences between Windows an Unix formats in Perl,at least 5.xx.. MOST IMPORTANT: Use Unix file format while saving Your script. otherwise it will have ^M s or smth likely weird in the EOL, Then DO NOT use m…
    On Microsoft Windows, if  when you click or type the name of a .pl file, you get an error "is not recognized as an internal or external command, operable program or batch file", then this means you do not have the .pl file extension associated with …
    Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…
    In this sixth video of the Xpdf series, we discuss and demonstrate the PDFtoPNG utility, which converts a multi-page PDF file to separate color, grayscale, or monochrome PNG files, creating one PNG file for each page in the PDF. It does this via a c…

    846 members asked questions and received personalized solutions in the past 7 days.

    Join the community of 500,000 technology professionals and ask your questions.

    Join & Ask a Question

    Need Help in Real-Time?

    Connect with top rated Experts

    3 Experts available now in Live!

    Get 1:1 Help Now