problems trying to cycle through files and modify them

Hi

I'm writing a script to cycle through the files in a directory and modify if an update file contains certain information. The problems im having (well, the problem im up to) is that i cant seem to extract the first line of the files to update in order to extract a number i need to use to match with the update file. My print debug line is doing nothing. I seem to be able to cycle and open the files fine - its just that i cant seem to be able to do anything with them. Heres the code:

#!/usr/bin/perl
use strict;
my $direc = "/home/jgs/blastportal/";
my $prefix = "taxGI_";

print("Update?: ");
my $in = <STDIN>;
chomp($in);

if($in eq "y"){
    my $update = $direc. "gi_taxid_nucl_diff.dmp";
    open(UPDLIST, $update) || die("Canont open update list.");

    opendir(DIR, $direc);
    my @files = grep(/($prefix)/,readdir(DIR));
    closedir(DIR);
   
foreach my $file(@files){
    my $path = $direc.$file;
    print $path;
    open(TAXFILE, "+>> $path") || die("Cannot open a tax file");
    my $firstline = <TAXFILE>;
    print $firstline;
    my $id = ($firstline =~ /\s+\d$/);
 
    while(<UPDLIST>){
      print TAXFILE if(/\s+($id)/);
    }
    close(TAXFILE);
}
close(UPDLIST);

}

I'm new to perl so any advice would be very useful.

thanks
grubmakerAsked:
Who is Participating?
 
ozoConnect With a Mentor Commented:
you may also want
   print TAXFILE if(/\s+($id)\b/);
so that "  3456"  does not match $id="34"
0
 
grubmakerAuthor Commented:
ah, sorry, its something to do with how im opening the TAXFILE. if i open it with < i can read it fine. but i cant write to it. i thought +> and +>> had both read and write access?
0
 
ozoCommented:
   print $path;
is this your print debug line?
If it is not printing, it means that your  grep(/($prefix)/,readdir(DIR)) did not find any matching files.  Or perhaps that $in ne "y".

     my $id = ($firstline =~ /\s+\d$/);
I'm not sure what you think this is doing, but it sets $id to 1 if $firstline ends with whitespace followed by a single digit.
Based on your later use if $id, I might venture a guess that you might have meant something like:
     my($id) = $firstline =~ /\s+(\d+)$/;
0
2018 Annual Membership Survey

Here at Experts Exchange, we strive to give members the best experience. Help us improve the site by taking this survey today! (Bonus: Be entered to win a great tech prize for participating!)

 
grubmakerAuthor Commented:
print $firstline;

was my debug line of choice at the moment. im finding the files, it was the getting first line from each that is an issue. thanks for the regex advice, im going to give it a go now.
0
 
grubmakerAuthor Commented:
hmm.. ive tried your corrections and its still only grabbing the 1. the file is simply two columns of numbers, im trying to tell it to grab the first number after the first white spaces...
0
 
ozoCommented:
if the number is not the last thing on the line, then try.
my ($id) = $firstline =~ /\s(\d+)/;
Otherwise, show me $firstline, $id, and your code.
0
 
ITcrowCommented:
You mentioned that line consists of two number columns ...

my($first_line) = <TAXFILE>;
my($col2)       = (split /\s+/, $first_line)[1];

Like wise if you needed column 1:
my($col1)       = (split /\s+/, $first_line)[0];

Looking for both columns to make any evaluations
my($col1, $col2) = (split /\s+/, $first_line);

0
 
grubmakerAuthor Commented:
thanks...

yes i was omitting the brackets around $id, my ($id)..... what does this do?

thanks for the assistance
0
 
ozoCommented:
the parenthesis in
 ($id) =
puts the assignmet in list context.
In list context, m// returns a list consisting of the subexpressions matched by the parentheses in the pattern, i.e., ($1, $2, $3...)
In scalar context, it returns true if it succeeds, false if it fails.
0
 
grubmakerAuthor Commented:
ahah - great thanks alot
0
All Courses

From novice to tech pro — start learning today.