Solved

Output script results to text file

Posted on 2004-10-27
2,203 Views
Last Modified: 2009-10-08
I'm not a big vbscript guy, so I'm not sure what I'm doing here.  I have a vb script (a .vbs file on my pc) running this script to get the serial # of the pc:

On Error Resume Next
StrComputer = "."
Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
Set colItems = objWMIService.ExecQuery("Select * from Win32_BIOS",,48)
For Each objItem in colItems
      Wscript.echo "SerialNumber: " & objItem.SerialNumber
      Next

However, this just outputs the serial # to the screen.  I need to put these serial numbers into a text file.  So I added some lines to do this:

Open ("C:\results.txt") For Output As #1
Write #1, "SerialNumber: " & objItem.SerialNumber

But I keep getting an error:  Expected End of Statement on the Open line right at the "For" part.

Am I doing this right?  I'm sure it's just something stupid I'm doing, any help is appreciated, thanks!
0
Question by:ericb1
    15 Comments
     
    LVL 28

    Expert Comment

    by:vinnyd79
    try

    Open "C:\results.txt" For Output As #1
    Print #1, "SerialNumber: " & objItem.SerialNumber
    Close #1
    0
     
    LVL 28

    Expert Comment

    by:vinnyd79
    or you can open for append if you want to add to the file:

    Open "C:\results.txt" For append As #1
    Print #1, "SerialNumber: " & objItem.SerialNumber
    Close #1
    0
     
    LVL 32

    Expert Comment

    by:Erick37
    strComputer = "."
    Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
    Set colItems = objWMIService.ExecQuery("Select * from Win32_BIOS", , 48)

    Open "C:\results.txt" For Output As #1

    For Each objItem In colItems
         Print #1, "SerialNumber: " & objItem.SerialNumber
    Next

    Close #1
    0
     

    Author Comment

    by:ericb1
    I still get the same thing:  a compilation error:  Expected End of Statement on line 5,  Character 23 which is the F in For Output statement.

    I'm running this directly from my pc as a .vbs file, not sure if that makes a difference?  Thanks!
    0
     
    LVL 28

    Expert Comment

    by:vinnyd79
    use fso:

    Dim fso,txtFile
    Set fso = CreateObject("Scripting.FileSystemObject")

    Set txtFile = fso.CreateTextFile("C:\results.txt", True)
        txtFile.WriteLine "SerialNumber: " & objItem.SerialNumber
        txtFile.Close
       
    Set txtFile = Nothing
    Set fso = Nothing
    0
     
    LVL 28

    Expert Comment

    by:vinnyd79
    or maybe:

    Dim fso,txtFile

    On Error Resume Next
    StrComputer = "."
    Set objWMIService = GetObject("winmgmts:\\" & strComputer & "\root\cimv2")
    Set colItems = objWMIService.ExecQuery("Select * from Win32_BIOS",,48)

    Set fso = CreateObject("Scripting.FileSystemObject")
    Set txtFile = fso.CreateTextFile("C:\results.txt", True)

    For Each objItem in colItems
         txtFile.WriteLine "SerialNumber: " & objItem.SerialNumber
    next

    txtFile.Close
    Set txtFile = Nothing
    Set fso = Nothing
    0
     
    LVL 14

    Expert Comment

    by:aelatik
    Don't use anything. If its plain VBS just PIPE it to a file like :

    C:\cscript yourfile.vbs >> result.txt
    0
     
    LVL 14

    Expert Comment

    by:aelatik
    Hiding the scripting logo would be like :

    C:\cscript yourfile.vbs >> result.txt //nologo

    note : In batch or scripting the ECHO command parses the text to screen. The parsed text can always be PIPED to a textfile.
    0
     

    Author Comment

    by:ericb1
    no dice.  The fso method seemed to work, it didn't give any errors, but the txt file wasn't created.
    0
     
    LVL 28

    Expert Comment

    by:vinnyd79
    If you remove the On Error line,does it cause an error?
    0
     

    Author Comment

    by:ericb1
    Oops, yes it does.  I get an error on creating the text file:  ActiveX component can't create object: 'Scripting.FileSystemObject'
    0
     
    LVL 28

    Expert Comment

    by:vinnyd79
    0
     

    Author Comment

    by:ericb1
    Not sure how to allow the file to be created, do I have to allow ActiveX permissions somewhere?  Any help is appreciated, thanks!
    0
     
    LVL 28

    Accepted Solution

    by:
    I think you might be missing the scripting runtime files (Scrrun.dll) which is included in the above download link.
    0
     
    LVL 32

    Expert Comment

    by:Erick37
    vinnyd79 has the correct answer.  Remove "On Error Resume Next" to see what if anything is causing an error for you...
    0

    Write Comment

    Please enter a first name

    Please enter a last name

    We will never share this with anyone. Privacy Policy Terms of Use

    Featured Post

    Threat Intelligence Starter Resources

    Integrating threat intelligence can be challenging, and not all companies are ready. These resources can help you build awareness and prepare for defense.

    I’ve seen a number of people looking for examples of how to access web services from VB6.  I’ve been using a test harness I built in VB6 (using many resources I found online) that I use for small projects to work out how to communicate with web serv…
    The debugging module of the VB 6 IDE can be accessed by way of the Debug menu item. That menu item can normally be found in the IDE's main menu line as shown in this picture.   There is also a companion Debug Toolbar that looks like the followin…
    Get people started with the process of using Access VBA to control Outlook using automation, Microsoft Access can control other applications. An example is the ability to programmatically talk to Microsoft Outlook. Using automation, an Access applic…
    This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

    877 members asked questions and received personalized solutions in the past 7 days.

    Join the community of 500,000 technology professionals and ask your questions.

    Join & Ask a Question

    Need Help in Real-Time?

    Connect with top rated Experts

    19 Experts available now in Live!

    Get 1:1 Help Now